Changeset f2b2029

Timestamp:

Dec 2, 2015, 11:55:55 AM (9 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, gc_noraii, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, string, with_gc

Children:

0ddb713, e58be8e

Parents:

ed1065c

Message:

documentation in Box.cc

File:

• src/GenPoly/Box.cc (modified) (4 diffs)

src/GenPoly/Box.cc

@@ -10 +10 @@
 // Created On       : Mon May 18 07:44:20 2015
 // Last Modified By : Rob Schluntz
-// Last Modified On : Thu Nov 26 17:01:55 2015
-// Update Count     : 191
+// Last Modified On : Wed Dec 02 11:52:37 2015
+// Update Count     : 201
 //
 
@@ -183 +183 @@
                 }
 
+                // returns true if the given declaration is: (*?=?)(T *, T) for some T (return not checked, but maybe should be)
                 bool checkAssignment( DeclarationWithType *decl, std::string &name ) {
                         if ( decl->get_name() == "?=?" ) {
@@ -668 +669 @@
                                                 TypeInstType *typeInst1 = isPolyPtr( appExpr->get_args().front()->get_results().front(), env, scopeTyVars );
                                                 TypeInstType *typeInst2 = isPolyPtr( appExpr->get_args().back()->get_results().front(), env, scopeTyVars );
-                                                assert( ! typeInst1 || ! typeInst2 );
+                                                assert( ! typeInst1 || ! typeInst2 );  // the arguments cannot both be polymorphic pointers
                                                 UntypedExpr *ret = 0;
-                                                if ( typeInst1 || typeInst2 ) {
+                                                if ( typeInst1 || typeInst2 ) { // one of the arguments is a polymorphic pointer
                                                         ret = new UntypedExpr( new NameExpr( "?+?" ) );
                                                 } // if
@@ -866 +867 @@
 
                 Statement * Pass1::mutate(ReturnStmt *retStmt) {
-                        // a cast expr on a polymorphic return value is either redundant or invalid
+                        // by this point, a cast expr on a polymorphic return value is redundant
                         while ( CastExpr *castExpr = dynamic_cast< CastExpr *>( retStmt->get_expr() ) ) {
                                 retStmt->set_expr( castExpr->get_arg() );