Changeset ef9988b for src/ResolvExpr

Timestamp:

Aug 18, 2020, 4:26:19 PM (5 years ago)

Author:

Fangren Yu <f37yu@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

13d33a75

Parents:

4fe6224

Message:

fix lost typeinst in resolved assertions

Location:

src/ResolvExpr

Files:

• CandidateFinder.cpp (modified) (2 diffs)
• Unify.cc (modified) (3 diffs)

src/ResolvExpr/CandidateFinder.cpp

@@ -1473 +1473 @@
                                         // unification run for side-effects
                                         unify( toType, cand->expr->result, env, need, have, open, symtab );
-                                        Cost thisCost = castCost( cand->expr->result, toType, cand->expr->get_lvalue(),
+                                        Cost thisCost = computeConversionCost( cand->expr->result, toType, cand->expr->get_lvalue(),
                                                         symtab, env );
 
@@ -1483 +1483 @@
                                                                 initExpr->location, restructureCast( cand->expr, toType ),
                                                                 initAlt.designation },
-                                                        copy( cand->env ), move( open ), move( need ), cand->cost, thisCost );
+                                                        move(env), move( open ), move( need ), cand->cost, thisCost );
                                                 inferParameters( newCand, matches );
                                         }

src/ResolvExpr/Unify.cc

@@ -791 +791 @@
                         for ( const ast::DeclWithType * d : src ) {
                                 ast::Pass<TtypeExpander_new> expander{ env };
-                                d = d->accept( expander );
-                                auto types = flatten( d->get_type() );
+                                // TtypeExpander pass is impure (may mutate nodes in place)
+                                // need to make nodes shared to prevent accidental mutation
+                                ast::ptr<ast::DeclWithType> dc = d;
+                                dc = dc->accept( expander );
+                                auto types = flatten( dc->get_type() );
                                 for ( ast::ptr< ast::Type > & t : types ) {
                                         // outermost const, volatile, _Atomic qualifiers in parameters should not play
@@ -801 +804 @@
                                         // requirements than a non-mutex function
                                         remove_qualifiers( t, ast::CV::Const | ast::CV::Volatile | ast::CV::Atomic );
-                                        dst.emplace_back( new ast::ObjectDecl{ d->location, "", t } );
+                                        dst.emplace_back( new ast::ObjectDecl{ dc->location, "", t } );
                                 }
                         }
@@ -1110 +1113 @@
 
                         ast::Pass<TtypeExpander_new> expander{ tenv };
-                        const ast::Type * flat = tuple->accept( expander );
-                        const ast::Type * flat2 = tuple2->accept( expander );
+
+                        ast::ptr<ast::TupleType> tuplec = tuple;
+                        ast::ptr<ast::TupleType> tuple2c = tuple2;
+                        const ast::Type * flat = tuplec->accept( expander );
+                        const ast::Type * flat2 = tuple2c->accept( expander );
 
                         auto types = flatten( flat );