Changeset ed8a0d2 for src

Timestamp:

May 2, 2017, 7:09:44 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

9042795

Parents:

2055098

Message:

constructor taking an array parameter is now an error

Location:

src

Files:

• SymTab/Validate.cc (modified) (2 diffs)
• SynTree/PointerType.cc (modified) (2 diffs)
• SynTree/Type.h (modified) (1 diff)

src/SymTab/Validate.cc

@@ -240 +240 @@
                 ReturnTypeFixer::fix( translationUnit ); // must happen before autogen
                 acceptAll( translationUnit, lrt ); // must happen before autogen, because sized flag needs to propagate to generated functions
+                acceptAll( translationUnit, epc ); // must happen before VerifyCtorDtorAssign, because void return objects should not exist
+                VerifyCtorDtorAssign::verify( translationUnit );  // must happen before autogen, because autogen examines existing ctor/dtors
                 Concurrency::applyKeywords( translationUnit );
                 autogenerateRoutines( translationUnit ); // moved up, used to be below compoundLiteral - currently needs EnumAndPointerDecayPass
                 Concurrency::implementMutexFuncs( translationUnit );
                 Concurrency::implementThreadStarter( translationUnit );
-                acceptAll( translationUnit, epc );
                 ReturnChecker::checkFunctionReturns( translationUnit );
                 compoundliteral.mutateDeclarationList( translationUnit );
                 acceptAll( translationUnit, pass3 );
-                VerifyCtorDtorAssign::verify( translationUnit );
                 ArrayLength::computeLength( translationUnit );
         }
@@ -817 +817 @@
                                 throw SemanticError( "Constructors, destructors, and assignment functions require at least one parameter ", funcDecl );
                         }
-                        if ( ! dynamic_cast< PointerType * >( params.front()->get_type() ) ) {
+                        PointerType * ptrType = dynamic_cast< PointerType * >( params.front()->get_type() );
+                        if ( ! ptrType || ptrType->is_array() ) {
                                 throw SemanticError( "First parameter of a constructor, destructor, or assignment function must be a pointer ", funcDecl );
                         }

src/SynTree/PointerType.cc

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// PointerType.cc -- 
+// PointerType.cc --
 //
 // Author           : Richard C. Bilson
@@ -38 +38 @@
 void PointerType::print( std::ostream &os, int indent ) const {
         Type::print( os, indent );
-        os << "pointer to ";
-        if ( isStatic ) {
-                os << "static ";
-        } // if
-        if ( isVarLen ) {
-                os << "variable length array of ";
-        } else if ( dimension ) {
-                os << "array of ";
-                dimension->print( os, indent );
-        } // if
+        if ( ! is_array() ) {
+                os << "pointer to ";
+        } else {
+                os << "decayed ";
+                if ( isStatic ) {
+                        os << "static ";
+                } // if
+                if ( isVarLen ) {
+                        os << "variable length array of ";
+                } else if ( dimension ) {
+                        os << "array of ";
+                        dimension->print( os, indent );
+                        os << " ";
+                } // if
+        }
         if ( base ) {
                 base->print( os, indent );

src/SynTree/Type.h

@@ -247 +247 @@
         void set_isStatic( bool newValue ) { isStatic = newValue; }
 
+        bool is_array() const { return isStatic || isVarLen || dimension; }
+
         virtual PointerType *clone() const { return new PointerType( *this ); }
         virtual void accept( Visitor & v ) { v.visit( this ); }