Changeset ec6c040

Timestamp:

Mar 19, 2018, 2:07:42 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, with_gc

Children:

2348881

Parents:

6470882

git-author:

Rob Schluntz <rschlunt@…> (03/15/18 14:48:28)

git-committer:

Rob Schluntz <rschlunt@…> (03/19/18 14:07:42)

Message:

Add warning for rvalue-to-reference conversion

Location:

src

Files:

• Common/SemanticError.h (modified) (2 diffs)
• GenPoly/Lvalue.cc (modified) (1 diff)

src/Common/SemanticError.h

@@ -38 +38 @@
 constexpr const char * const WarningFormats[] = {
         "self assignment of expression: %s",
+        "rvalue to reference conversion",
 };
 
 enum class Warning {
         SelfAssignment,
+        RvalueToReferenceConversion,
         NUMBER_OF_WARNINGS, //This MUST be the last warning
 };
@@ -50 +52 @@
 );
 
-#define SemanticWarning(loc, id, ...) SemanticWarningImpl(loc, id, WarningFormats[(int)id], __VA_ARGS__)
+// ## used here to allow empty __VA_ARGS__
+#define SemanticWarning(loc, id, ...) SemanticWarningImpl(loc, id, WarningFormats[(int)id], ## __VA_ARGS__)
 
 void SemanticWarningImpl (CodeLocation loc, Warning warn, const char * const fmt, ...) __attribute__((format(printf, 3, 4)));

src/GenPoly/Lvalue.cc

@@ -296 +296 @@
                                 //   int && __ref_tmp_2 = &__ref_tmp_1;
                                 //   &__ref_tmp_2;
+                                SemanticWarning( castExpr->arg->location, Warning::RvalueToReferenceConversion );
 
                                 static UniqueName tempNamer( "__ref_tmp_" );