Changes in / [713905fd:e6e1a12]

Files:

• libcfa/src/concurrency/coroutine.cfa (modified) (2 diffs)
• libcfa/src/concurrency/coroutine.hfa (modified) (2 diffs)
• libcfa/src/concurrency/invoke.h (modified) (2 diffs)
• src/AST/Decl.hpp (modified) (1 diff)
• src/AST/SymbolTable.cpp (modified) (2 diffs)
• src/GenPoly/SpecializeNew.cpp (modified) (2 diffs)
• src/InitTweak/FixInitNew.cpp (modified) (2 diffs)
• src/ResolvExpr/CommonType.cc (modified) (3 diffs)
• src/ResolvExpr/Unify.cc (modified) (2 diffs)
• src/Validate/LinkReferenceToTypes.cpp (modified) (1 diff)
• tests/exceptions/.expect/fibonacci_nonlocal.txt (deleted)
• tests/exceptions/.expect/pingpong_nonlocal.txt (deleted)
• tests/exceptions/fibonacci_nonlocal.cfa (deleted)
• tests/exceptions/pingpong_nonlocal.cfa (deleted)

libcfa/src/concurrency/coroutine.cfa

@@ -121 +121 @@
         last = 0p;
         cancellation = 0p;
-    ehm_state.ehm_buffer{};
-    ehm_state.buffer_lock{};
-    ehm_state.ehm_enabled = false;
 }
 
@@ -286 +283 @@
 }
 
-
-////////////////////////////////////////////////////////////////////////////////////////////////////
-// non local ehm routines
-
-// helper for popping from coroutine's ehm buffer
-inline nonlocal_exception * pop_ehm_head( coroutine$ * this ) {
-    lock( this->ehm_state.buffer_lock __cfaabi_dbg_ctx2 );
-    nonlocal_exception * nl_ex = pop_head( this->ehm_state.ehm_buffer );
-    unlock( this->ehm_state.buffer_lock );
-    return nl_ex;
-}
-
-// user facing ehm operations
-forall(T & | is_coroutine(T)) {
-    // enable/disable non-local exceptions
-    void enable_ehm( T & cor ) libcfa_public { get_coroutine( cor )->ehm_state.ehm_enabled = true; }
-    void disable_ehm( T & cor ) libcfa_public { get_coroutine( cor )->ehm_state.ehm_enabled = false; }
-
-    // poll for non-local exceptions
-    bool poll( T & cor ) libcfa_public {
-        coroutine$ * base_cor = get_coroutine( cor );
-        nonlocal_exception * nl_ex = pop_ehm_head( base_cor );
-
-        // if no exceptions return false
-        if ( nl_ex == 0p ) return false;
-        
-        // otherwise loop and throwResume all pending exceptions
-        while ( nl_ex != 0p ){
-            exception_t * ex = nl_ex->the_exception;
-            free( nl_ex );
-            throwResume *ex;
-            nl_ex = pop_ehm_head( base_cor );
-        }
-        
-        return true;
-    }
-
-    // poll iff nonlocal ehm is enabled
-    bool checked_poll( T & cor ) libcfa_public { return get_coroutine( cor )->ehm_state.ehm_enabled ? poll( cor ) : false; }
-}
-
-// resume non local exception at receiver (i.e. enqueue in ehm buffer)
-forall(exceptT &, T & | ehm_resume_at( exceptT, T ))
-void resumeAt( T & receiver, exceptT & ex )  libcfa_public {
-    coroutine$ * cor = get_coroutine( receiver );
-    nonlocal_exception * nl_ex = alloc();
-    (*nl_ex){ (exception_t *)&ex };
-    lock( cor->ehm_state.buffer_lock __cfaabi_dbg_ctx2 );
-    append( cor->ehm_state.ehm_buffer, nl_ex ); 
-    unlock( cor->ehm_state.buffer_lock );
-}
-
 // Local Variables: //
 // mode: c //

libcfa/src/concurrency/coroutine.hfa

@@ -19 +19 @@
 #include "invoke.h"
 #include "../exception.hfa"
-
-//-----------------------------------------------------------------------------
-// Type used to store and queue nonlocal exceptions on coroutines
-struct nonlocal_exception {
-    exception_t * the_exception;
-    nonlocal_exception * next;
-};
-static inline void ?{} ( nonlocal_exception & this, exception_t * ex ) with(this) {
-    the_exception = ex;
-    next = 0p;
-}
-
-static inline nonlocal_exception *& get_next( nonlocal_exception & this ) __attribute__((const)) {
-    return this.next;
-}
 
 //-----------------------------------------------------------------------------
@@ -218 +203 @@
 }
 
-// non local ehm routines
-forall(T & | is_coroutine(T)) {
-    void enable_ehm( T & cor );
-    void disable_ehm( T & cor );
-    bool poll( T & cor );
-    bool checked_poll( T & cor );
-}
-
-// trait for exceptions able to be resumed at another coroutine
-forall(exceptT &, T & | is_coroutine(T))
-trait ehm_resume_at { void $throwResume(exceptT &); };
-
-forall(exceptT &, T & | ehm_resume_at( exceptT, T ))
-void resumeAt( T & receiver, exceptT & ex );
-
 // Local Variables: //
 // mode: c //

libcfa/src/concurrency/invoke.h

@@ -74 +74 @@
         };
 
-    struct nonlocal_ehm {
-        // list of pending nonlocal exceptions
-        __queue_t(struct nonlocal_exception) ehm_buffer;
-
-        // lock to protect the buffer
-        struct __spinlock_t buffer_lock;
-
-        // enable/disabled flag
-        bool ehm_enabled;
-    };
-
         enum __Coroutine_State { Halted, Start, Primed, Blocked, Ready, Active, Cancelled, Halting };
 
@@ -109 +98 @@
                 struct _Unwind_Exception * cancellation;
 
-        // Non-local exception handling information
-        struct nonlocal_ehm ehm_state;
         };
         // Wrapper for gdb

src/AST/Decl.hpp

@@ -69 +69 @@
 public:
         /// Represents the type with all types and typedefs expanded.
+        /// This field is generated by SymTab::Validate::Pass2
         std::string mangleName;
         /// Stores the scope level at which the variable was declared.

src/AST/SymbolTable.cpp

@@ -19 +19 @@
 
 #include "Copy.hpp"
+#include <iostream>
+#include <algorithm>
+
 #include "Decl.hpp"
 #include "Expr.hpp"
@@ -203 +206 @@
                         out.push_back(decl.second);
                 }
+
+                // std::cerr << otypeKey << ' ' << out.size() << std::endl;
         }
 

src/GenPoly/SpecializeNew.cpp

@@ -104 +104 @@
 
 bool needsPolySpecialization(
-                const ast::Type * /*formalType*/,
+                const ast::Type * formalType,
                 const ast::Type * actualType,
                 const ast::TypeSubstitution * subs ) {
@@ -126 +126 @@
                         if ( closedVars.find( *inst ) == closedVars.end() ) {
                                 return true;
-                        } else {
+                        }
+                        else {
                                 assertf(false, "closed: %s", inst->name.c_str());
                         }

src/InitTweak/FixInitNew.cpp

@@ -22 +22 @@
 #include "AST/SymbolTable.hpp"
 #include "AST/Type.hpp"
-#include "CodeGen/OperatorTable.h"     // for isConstructor, isCtorDtor, isD...
+#include "CodeGen/GenType.h"           // for genPrettyType
+#include "CodeGen/OperatorTable.h"
+#include "Common/PassVisitor.h"        // for PassVisitor, WithStmtsToAdd
 #include "Common/SemanticError.h"      // for SemanticError
 #include "Common/ToString.hpp"         // for toCString
@@ -31 +33 @@
 #include "ResolvExpr/Resolver.h"       // for findVoidExpression
 #include "ResolvExpr/Unify.h"          // for typesCompatible
+#include "SymTab/Autogen.h"            // for genImplicitCall
 #include "SymTab/GenImplicitCall.hpp"  // for genImplicitCall
+#include "SymTab/Indexer.h"            // for Indexer
+#include "SymTab/Mangler.h"            // for Mangler
+#include "SynTree/LinkageSpec.h"       // for C, Spec, Cforall, isBuiltin
+#include "SynTree/Attribute.h"         // for Attribute
+#include "SynTree/Constant.h"          // for Constant
+#include "SynTree/Declaration.h"       // for ObjectDecl, FunctionDecl, Decl...
+#include "SynTree/Expression.h"        // for UniqueExpr, VariableExpr, Unty...
+#include "SynTree/Initializer.h"       // for ConstructorInit, SingleInit
+#include "SynTree/Label.h"             // for Label, operator<
+#include "SynTree/Mutator.h"           // for mutateAll, Mutator, maybeMutate
+#include "SynTree/Statement.h"         // for ExprStmt, CompoundStmt, Branch...
+#include "SynTree/Type.h"              // for Type, Type::StorageClasses
+#include "SynTree/TypeSubstitution.h"  // for TypeSubstitution, operator<<
+#include "SynTree/DeclReplacer.h"      // for DeclReplacer
+#include "SynTree/Visitor.h"           // for acceptAll, maybeAccept
+#include "Validate/FindSpecialDecls.h" // for dtorStmt, dtorStructDestroy
 
 extern bool ctordtorp; // print all debug

src/ResolvExpr/CommonType.cc

@@ -696 +696 @@
                 void postvisit( const ast::BasicType * basic ) {
                         if ( auto basic2 = dynamic_cast< const ast::BasicType * >( type2 ) ) {
+                                #warning remove casts when `commonTypes` moved to new AST
+                                
+                                /*
+                                ast::BasicType::Kind kind = (ast::BasicType::Kind)(int)commonTypes[ (BasicType::Kind)(int)basic->kind ][ (BasicType::Kind)(int)basic2->kind ];
+                                if (
+                                        ( ( kind == basic->kind && basic->qualifiers >= basic2->qualifiers )
+                                                || widen.first )
+                                        && ( ( kind == basic2->kind && basic->qualifiers <= basic2->qualifiers )
+                                                || widen.second )
+                                ) {
+                                        result = new ast::BasicType{ kind, basic->qualifiers | basic2->qualifiers };
+                                }
+                                */
                                 ast::BasicType::Kind kind;
                                 if (basic->kind != basic2->kind && !widen.first && !widen.second) return;
@@ -706 +719 @@
                                         result = new ast::BasicType{ kind, basic->qualifiers | basic2->qualifiers };
                                 }
+                                
                         } else if (
                                 dynamic_cast< const ast::ZeroType * >( type2 )
                                 || dynamic_cast< const ast::OneType * >( type2 )
                         ) {
+                                #warning remove casts when `commonTypes` moved to new AST
+                                ast::BasicType::Kind kind = (ast::BasicType::Kind)(int)commonTypes[ (BasicType::Kind)(int)basic->kind ][ (BasicType::Kind)(int)ast::BasicType::SignedInt ];
+                                /*
+                                if ( // xxx - what does qualifier even do here??
+                                        ( ( basic->qualifiers >= type2->qualifiers )
+                                                || widen.first )
+                                         && ( ( /* kind != basic->kind && basic->qualifiers <= type2->qualifiers )
+                                                || widen.second )
+                                ) 
+                                */
                                 if (widen.second) {
                                         result = new ast::BasicType{ basic->kind, basic->qualifiers | type2->qualifiers };
                                 }
                         } else if ( const ast::EnumInstType * enumInst = dynamic_cast< const ast::EnumInstType * >( type2 ) ) {
+                                #warning remove casts when `commonTypes` moved to new AST
                                 const ast::EnumDecl* enumDecl = enumInst->base;
                                 if ( enumDecl->base ) {
                                         result = enumDecl->base.get();
                                 } else {
-                                        #warning remove casts when `commonTypes` moved to new AST
                                         ast::BasicType::Kind kind = (ast::BasicType::Kind)(int)commonTypes[ (BasicType::Kind)(int)basic->kind ][ (BasicType::Kind)(int)ast::BasicType::SignedInt ];
                                         if (
@@ -739 +763 @@
                                 auto entry = open.find( *var );
                                 if ( entry != open.end() ) {
+                                // if (tenv.lookup(*var)) {
                                         ast::AssertionSet need, have;
                                         if ( ! tenv.bindVar(

src/ResolvExpr/Unify.cc

@@ -1298 +1298 @@
                 auto var1 = dynamic_cast< const ast::TypeInstType * >( type1 );
                 auto var2 = dynamic_cast< const ast::TypeInstType * >( type2 );
+                ast::OpenVarSet::const_iterator
+                        entry1 = var1 ? open.find( *var1 ) : open.end(),
+                        entry2 = var2 ? open.find( *var2 ) : open.end();
+                // bool isopen1 = entry1 != open.end();
+                // bool isopen2 = entry2 != open.end();
                 bool isopen1 = var1 && env.lookup(*var1);
                 bool isopen2 = var2 && env.lookup(*var2);
 
+                /*
+                if ( isopen1 && isopen2 ) {
+                        if ( entry1->second.kind != entry2->second.kind ) return false;
+                        return env.bindVarToVar(
+                                var1, var2, ast::TypeData{ entry1->second, entry2->second }, need, have,
+                                open, widen );
+                } else if ( isopen1 ) {
+                        return env.bindVar( var1, type2, entry1->second, need, have, open, widen );
+                } else if ( isopen2 ) {
+                        return env.bindVar( var2, type1, entry2->second, need, have, open, widen, symtab );
+                } */
                 if ( isopen1 && isopen2 ) {
                         if ( var1->base->kind != var2->base->kind ) return false;
@@ -1310 +1326 @@
                 } else if ( isopen2 ) {
                         return env.bindVar( var2, type1, ast::TypeData{var2->base}, need, have, open, widen );
-                } else {
+                }else {
                         return ast::Pass<Unify_new>::read(
                                 type1, type2, env, need, have, open, widen );
                 }
+                
         }
 

src/Validate/LinkReferenceToTypes.cpp

@@ -80 +80 @@
 ast::EnumInstType const * LinkTypesCore::postvisit( ast::EnumInstType const * type ) {
         ast::EnumDecl const * decl = symtab.lookupEnum( type->name );
-        ast::EnumInstType * mut = ast::mutate( type );
         // It's not a semantic error if the enum is not found, just an implicit forward declaration.
         if ( decl ) {
                 // Just linking in the node.
+                auto mut = ast::mutate( type );
                 mut->base = decl;
+                type = mut;
         }
         if ( !decl || !decl->body ) {
+                auto mut = ast::mutate( type );
                 forwardEnums[ mut->name ].push_back( mut );
-        }
-        return mut;
+                type = mut;
+        }
+        return type;
 }
 
 ast::StructInstType const * LinkTypesCore::postvisit( ast::StructInstType const * type ) {
         ast::StructDecl const * decl = symtab.lookupStruct( type->name );
-        ast::StructInstType * mut = ast::mutate( type );
         // It's not a semantic error if the struct is not found, just an implicit forward declaration.
         if ( decl ) {
                 // Just linking in the node.
+                auto mut = ast::mutate( type );
                 mut->base = decl;
+                type = mut;
         }
         if ( !decl || !decl->body ) {
+                auto mut = ast::mutate( type );
                 forwardStructs[ mut->name ].push_back( mut );
-        }
-        return mut;
+                type = mut;
+        }
+        return type;
 }
 
 ast::UnionInstType const * LinkTypesCore::postvisit( ast::UnionInstType const * type ) {
         ast::UnionDecl const * decl = symtab.lookupUnion( type->name );
-        ast::UnionInstType * mut = ast::mutate( type );
         // It's not a semantic error if the union is not found, just an implicit forward declaration.
         if ( decl ) {
                 // Just linking in the node.
+                auto mut = ast::mutate( type );
                 mut->base = decl;
+                type = mut;
         }
         if ( !decl || !decl->body ) {
+                auto mut = ast::mutate( type );
                 forwardUnions[ mut->name ].push_back( mut );
-        }
-        return mut;
+                type = mut;
+        }
+        return type;
 }