Changes in src/InitTweak/GenInit.cc [be9aa0f:e35f30a]

File:

• src/InitTweak/GenInit.cc (modified) (8 diffs)

src/InitTweak/GenInit.cc

@@ -30 +30 @@
 #include "InitTweak.h"             // for isConstExpr, InitExpander, checkIn...
 #include "Parser/LinkageSpec.h"    // for isOverridable, C
-#include "ResolvExpr/Resolver.h"
 #include "SymTab/Autogen.h"        // for genImplicitCall, SizeType
 #include "SymTab/Mangler.h"        // for Mangler
@@ -41 +40 @@
 #include "SynTree/Type.h"          // for Type, ArrayType, Type::Qualifiers
 #include "SynTree/Visitor.h"       // for acceptAll, maybeAccept
-#include "Tuples/Tuples.h"         // for maybeImpure
 
 namespace InitTweak {
@@ -91 +89 @@
         };
 
-        struct HoistArrayDimension final : public WithDeclsToAdd, public WithShortCircuiting, public WithGuards, public WithIndexer {
+        struct HoistArrayDimension final : public WithDeclsToAdd, public WithShortCircuiting, public WithGuards {
                 /// hoist dimension from array types in object declaration so that it uses a single
                 /// const variable of type size_t, so that side effecting array dimensions are only
@@ -106 +104 @@
                 void premutate( FunctionType * ) { visit_children = false; }
 
-                // need this so that enumerators are added to the indexer, due to premutate(AggregateDecl *)
-                void premutate( EnumDecl * ) {}
-
                 void hoist( Type * type );
 
@@ -140 +135 @@
                                 if ( varExpr->var == retVal ) return;
                         }
-                        Statement * stmt = genCtorDtor( "?{}", retVal, returnStmt->expr );
-                        assertf( stmt, "ReturnFixer: genCtorDtor returned nullptr: %s / %s", toString( retVal ).c_str(), toString( returnStmt->expr ).c_str() );
-                        stmtsToAddBefore.push_back( stmt );
+                        stmtsToAddBefore.push_back( genCtorDtor( "?{}", retVal, returnStmt->get_expr() ) );
 
                         // return the retVal object
@@ -185 +178 @@
                         if ( ! arrayType->get_dimension() ) return; // xxx - recursive call to hoist?
 
-                        // need to resolve array dimensions in order to accurately determine if constexpr
-                        ResolvExpr::findSingleExpression( arrayType->dimension, SymTab::SizeType->clone(), indexer );
-                        // array is variable-length when the dimension is not constexpr
-                        arrayType->isVarLen = ! isConstExpr( arrayType->dimension );
-                        // don't need to hoist dimension if it's definitely pure - only need to if there's potential for side effects.
-                        if ( ! Tuples::maybeImpure( arrayType->dimension ) ) return;
+                        // don't need to hoist dimension if it's a constexpr - only need to if there's potential for side effects.
+                        if ( isConstExpr( arrayType->get_dimension() ) ) return;
 
                         ObjectDecl * arrayDimension = new ObjectDecl( dimensionName.newName(), storageClasses, LinkageSpec::C, 0, SymTab::SizeType->clone(), new SingleInit( arrayType->get_dimension() ) );
@@ -205 +194 @@
         void HoistArrayDimension::premutate( FunctionDecl * ) {
                 GuardValue( inFunction );
-                inFunction = true;
         }
 
@@ -232 +220 @@
                 Type * type = objDecl->get_type();
                 while ( ArrayType * at = dynamic_cast< ArrayType * >( type ) ) {
-                        // must always construct VLAs with an initializer, since this is an error in C
-                        if ( at->isVarLen && objDecl->init ) return true;
                         type = at->get_base();
                 }