Changeset e20eaf4 for libcfa/src/concurrency

Timestamp:

Mar 29, 2021, 2:15:59 PM (3 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

976bc68

Parents:

31fc80f

Message:

Fixed incorrect comment in locks code.

File:

• libcfa/src/concurrency/locks.hfa (modified) (2 diffs)

libcfa/src/concurrency/locks.hfa

@@ -82 +82 @@
 
         // returns true if no blocking needed
-        bool P(BinaryBenaphore & this) { return __atomic_fetch_sub(&this.counter, 1, __ATOMIC_SEQ_CST) > 0; }
+        bool P(BinaryBenaphore & this) {
+                return __atomic_fetch_sub(&this.counter, 1, __ATOMIC_SEQ_CST) > 0;
+        }
+
         bool tryP(BinaryBenaphore & this) {
                 ssize_t c = this.counter;
@@ -115 +118 @@
 static inline void ?{}(ThreadBenaphore & this, one_t ) { (this.ben){ 1 }; }
 
-static inline bool P(ThreadBenaphore & this)              { return /* P(this.ben) ? false : */ P(this.sem); }
-static inline bool P(ThreadBenaphore & this, $thread * t) { return /* P(this.ben) ? false : */ P(this.sem, t ); }
+static inline bool P(ThreadBenaphore & this)              { return P(this.ben) ? false : P(this.sem); }
+static inline bool P(ThreadBenaphore & this, $thread * t) { return P(this.ben) ? false : P(this.sem, t ); }
 static inline bool tryP(ThreadBenaphore & this)           { return tryP(this.ben); }
 static inline bool P(ThreadBenaphore & this, bool wait)   { return wait ? P(this) : tryP(this); }
 
 static inline $thread * V(ThreadBenaphore & this, const bool doUnpark = true) {
-        // if (V(this.ben)) return 0p;
+        if (V(this.ben)) return 0p;
         return V(this.sem, doUnpark);
 }