Changeset e1358c0

Timestamp:

Mar 19, 2025, 1:34:12 PM (3 days ago)

Author:

kyoung <lseo@…>

Branches:

master

Children:

fd3be42

Parents:

048dde4

git-author:

kyoung <lseo@…> (03/19/25 12:01:52)

git-committer:

kyoung <lseo@…> (03/19/25 13:34:12)

Message:

create waituntil timeout node as literal via macro as a workaround for upcoming change in dlist copy ctor/raii changes

Files:

• libcfa/src/concurrency/select.cfa (modified) (2 diffs)
• libcfa/src/concurrency/select.hfa (modified) (2 diffs)
• tests/concurrency/waituntil/all_types.cfa (modified) (3 diffs)
• tests/concurrency/waituntil/timeout.cfa (modified) (1 diff)

libcfa/src/concurrency/select.cfa ¶

@@ -10 +10 @@
 // Author           : Colby Alexander Parsons
 // Created On       : Thu Apr 21 19:46:50 2023
-// Last Modified By :
-// Last Modified On :
-// Update Count     :
+// Last Modified By : Kyoung Seo
+// Last Modified On : Wed Mar 19 12:00:00 2025
+// Update Count     : 1
 //
 
@@ -51 +51 @@
 bool on_selected( select_timeout_node & this, select_node & node ) { return true; }
 
-// Gateway routine to wait on duration
-select_timeout_node timeout( Duration duration ) {
-        select_timeout_node node{ duration, timeout_handler_select_cast };
-    return node;
-}
-select_timeout_node sleep( Duration duration ) { return timeout( duration ); }
-

libcfa/src/concurrency/select.hfa ¶

@@ -10 +10 @@
 // Author           : Colby Alexander Parsons
 // Created On       : Thu Jan 21 19:46:50 2023
-// Last Modified By :
-// Last Modified On :
-// Update Count     :
+// Last Modified By : Kyoung Seo
+// Last Modified On : Wed Mar 19 12:00:00 2025
+// Update Count     : 1
 //
 
@@ -214 +214 @@
 select_timeout_node __CFA_select_get_type( select_timeout_node this );
 
-// Gateway routines to waituntil on duration
-select_timeout_node timeout( Duration duration );
-select_timeout_node sleep( Duration duration );
-
+// Timer macro for waituntil
+#define _timeout(D) (select_timeout_node) { D, timeout_handler_select_cast }

tests/concurrency/waituntil/all_types.cfa ¶

@@ -39 +39 @@
         or when( i % 4 < 2 ) waituntil( B ) { consume_b_val( myTotal ); }
         or waituntil( c << C ) { if ( c == -1 ) break; myTotal += c; }
-        or when( i % 3 ) waituntil( timeout( 1`ms ) ) {}
+        or when( i % 3 ) waituntil( _timeout( 1`ms ) ) {}
         or when( i % 8 < 4 ) else {}
     }
@@ -53 +53 @@
         or waituntil( c << C ) { if ( c == -1 ) break; myTotal += c; }
         or waituntil( B ) { consume_b_val( myTotal ); }
-        or waituntil( timeout( 100`ns ) ) { }
+        or waituntil( _timeout( 100`ns ) ) { }
     }
     __atomic_fetch_add( &globalTotal, myTotal, __ATOMIC_SEQ_CST );
@@ -99 +99 @@
                 or when( j % 4 < 2 ) waituntil( B ) { produce_b_val( total ); }
                 and when( j % 8 < 4 ) waituntil( C << j ) { total += j; }
-                and waituntil( timeout( 1`ns ) ) {}
+                and waituntil( _timeout( 1`ns ) ) {}
                 if ( j == numtimes / 2 )
                     fulfil( F, val_to_deliver );

tests/concurrency/waituntil/timeout.cfa ¶

@@ -6 +6 @@
 
 int main() {
-    waituntil( sleep( 1`ms ) ) { printf("timeout\n"); }
-    waituntil( timeout( 1`s ) ) { printf("timeout\n"); } or waituntil( timeout( 2`s ) ) { printf("timeout\n"); }
-    waituntil( timeout( 100`s ) ) { printf("timeout 1\n"); } or else { printf("else\n"); }
-    waituntil( timeout( 1`ns ) ) { printf("timeout\n"); } and waituntil( timeout( 2`s ) ) { printf("timeout\n"); }
+    waituntil( _timeout( 1`ms ) ) { printf("timeout\n"); }
+    waituntil( _timeout( 1`s ) ) { printf("timeout\n"); } or waituntil( _timeout( 2`s ) ) { printf("timeout\n"); }
+    waituntil( _timeout( 100`s ) ) { printf("timeout 1\n"); } or else { printf("else\n"); }
+    waituntil( _timeout( 1`ns ) ) { printf("timeout\n"); } and waituntil( _timeout( 2`s ) ) { printf("timeout\n"); }
     int count = 0;
     for ( i; 1000 )
-        waituntil( timeout( 1`ns ) ) { count++; } or else { count++; }
+        waituntil( _timeout( 1`ns ) ) { count++; } or else { count++; }
 
     assert( count == 1000 );
-    sleep( 1`ms );
+    _timeout( 1`ms );
     printf("done\n");
 }