Changeset e10714a

Timestamp:

Mar 27, 2023, 9:58:08 PM (20 months ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

ADT, ast-experimental, master

Children:

60380a1

Parents:

4eebbcc

Message:

update interpose code, and document 32-bit interpose bug in glibc

Location:

libcfa/src

Files:

• interpose.cfa (modified) (3 diffs)
• interpose_thread.cfa (modified) (2 diffs)

libcfa/src/interpose.cfa

@@ -10 +10 @@
 // Created On       : Wed Mar 29 16:10:31 2017
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Mon Mar 13 22:39:12 2023
-// Update Count     : 193
+// Last Modified On : Mon Mar 27 21:09:03 2023
+// Update Count     : 196
 //
 
@@ -40 +40 @@
         union { generic_fptr_t fptr; void * ptr; } originalFunc;
 
+        #if defined( _GNU_SOURCE )
+        if ( version ) {
+                originalFunc.ptr = dlvsym( library, symbol, version );
+        } else {
+                originalFunc.ptr = dlsym( library, symbol );
+        } // if
+        #else
         originalFunc.ptr = dlsym( library, symbol );
-        if ( ! originalFunc.ptr ) {                                                             // == nullptr
+        #endif // _GNU_SOURCE
+
+        if ( ! originalFunc.ptr ) {                                                     // == nullptr
                 abort( "interpose_symbol : internal error, %s\n", dlerror() );
         } // if
@@ -49 +58 @@
 static generic_fptr_t interpose_symbol( const char symbol[], const char version[] ) {
         void * library;
+
         #if defined( RTLD_NEXT )
         library = RTLD_NEXT;

libcfa/src/interpose_thread.cfa

@@ -14 +14 @@
 //
 
+// BUG in 32-bit gcc with interpose: fixed in >= gcc-9.5, gcc-10.4, gcc-12.2
 #ifdef __i386__                                                                                 // 32-bit architecture
 #undef _GNU_SOURCE
@@ -33 +34 @@
 typedef void (* generic_fptr_t)(void);
 
-generic_fptr_t interpose_symbol(
+generic_fptr_t libcfa_public interpose_symbol(
         generic_fptr_t (*do_interpose_symbol)( void * library, const char symbol[], const char version[] ),
         const char symbol[],
         const char version[]
-) libcfa_public {
+) {
         void * library;