Changeset e0330d2c

Timestamp:

Dec 18, 2024, 6:37:11 PM (5 weeks ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

master

Children:

e0f3bd2

Parents:

faf9e19

Message:

Remove unnecessary special case for zero_t in code gen that caused unused-variable warning in thunks.

Add instructions for tidying warnings (with the present zero_t case as its running example) as a "proposal."

The code gen change is safe because a corresponding case for one_t was always "missing" and the the variable at issue is never used meaningfully. (Prior work has size_t lowered as int. While that's a dubious choice, it's beyond what I'm fixing here.)

Mark these tests as now clean of warnings:

array-collections/array-basic
ctrl-flow/loopctrl
vector
vector_math/vec2_int
vector_math/vec2_float
vector_math/vec3_float
vector_math/vec4_float
zero_one

Files:

• doc/proposals/nowarn.md (added)
• src/CodeGen/CodeGenerator.cpp (modified) (1 diff)
• tests/Makefile.am (modified) (3 diffs)
• tests/array-collections/array-basic.cfa (modified) (1 diff)
• tests/nowarn/.expect/zero-thunk.txt (added)
• tests/nowarn/zero-thunk.cfa (added)

src/CodeGen/CodeGenerator.cpp

@@ -742 +742 @@
         extension( expr );
         const OperatorInfo * opInfo;
-        if ( dynamic_cast<ast::ZeroType const *>( expr->var->get_type() ) ) {
-                output << "0";
-        } else if ( expr->var->linkage == ast::Linkage::Intrinsic
+        if ( expr->var->linkage == ast::Linkage::Intrinsic
                         && ( opInfo = operatorLookup( expr->var->name ) )
                         && opInfo->type == OT_CONSTANT ) {

tests/Makefile.am

@@ -50 +50 @@
 # Indented list entries are finer-grained targets under the test.
 # Making this association implicit would be ideal, but requires learning more automake than is affordable.
-WFLGAS_OPT_LAX = \
+WFLGAS_OPT_LAX =  \
         abs \
         alloc \
         alloc2 \
         array \
-        array-collections/array-basic \
         array-collections/array-raii-c \
         array-collections/array-raii-cfa \
@@ -188 +187 @@
         ctrl-flow/ifwhileCtl \
         ctrl-flow/labelledExit \
-        ctrl-flow/loopctrl \
         ctrl-flow/loop_else \
         designations \
@@ -306 +304 @@
         variableDeclarator \
         vector \
-        vector_math/vec2_int \
-        vector_math/vec2_float \
-        vector_math/vec3_float \
-        vector_math/vec4_float \
-        warnings/self-assignment \
-        zero_one
+        warnings/self-assignment
 
 WFLAGS=${if ${filter ${WFLGAS_OPT_LAX},${@}},${WFLAGS_LAX},${WFLAGS_STRICT}}

tests/array-collections/array-basic.cfa

@@ -12 +12 @@
     // numeric subscripts
     ptrdiff_t ix = 1, iy = 2, iz = 3;
-    array( float, Ny, Nz ) & yz = xyz[ix];
-    array( float, Nz ) & z = xyz[ix][iy];
-    float & val = xyz[ix][iy][iz];
+    array( float, Ny, Nz ) & yz = xyz[ix];      (void) yz;
+    array( float, Nz ) & z = xyz[ix][iy];       (void) z;
+    float & val = xyz[ix][iy][iz];              (void) val;
 
     // deferral subscript