Changeset ded018f

Timestamp:

Jul 7, 2023, 9:55:34 AM (11 months ago)

Author:

caparsons <caparson@…>

Branches:

master

Children:

555c599

Parents:

bef2245

Message:

refactored to fix bug in channel_close test. As a consquence can no longer break out of waituntil statements that have an and

File:

• src/Concurrency/Waituntil.cpp (modified) (4 diffs)

src/Concurrency/Waituntil.cpp

@@ -884 +884 @@
                 )
             );
-        else // we reuse the when_cond bools later during unregister so init to false if initially unused
-            body->push_back(
-                new DeclStmt( cLoc,
-                    new ObjectDecl( cLoc,
-                        currClause->whenName,
-                        new BasicType( BasicType::Kind::Bool ),
-                        new SingleInit( cLoc, ConstantExpr::from_bool( cLoc, false ) )
-                    )
-                )
-            );
         
         // select_node clause1;
@@ -1306 +1296 @@
     CompoundStmt * unregisters = new CompoundStmt( loc );
 
-    // Collection of optional statement executions following finally clause
-    // for each clause:
-    // if ( when_cond_i ) clausei->stmt;
-    // when_cond_i is repurposed in the finally to store if any statements need to be run after unregisters
-    // the statements need to be run outside a finally clause since they may contain non-local transfers
-    CompoundStmt * unregisterStmts = new CompoundStmt( loc );
-
-    UntypedExpr * statusExpr; // !__CFA_has_clause_run( clause_statuses[i] )
-    ExprStmt * assignStmt; // when_cond_i = (!__CFA_has_clause_run( clause_statuses[i] )) && unregister_select( ... , clausei );
+
+    Expr * statusExpr; // !__CFA_has_clause_run( clause_statuses[i] )
     for ( int i = 0; i < numClauses; i++ ) {
         const CodeLocation & cLoc = stmt->clauses.at(i)->location;
@@ -1332 +1315 @@
         
         // Generates:
-        // when_cond_i = (!__CFA_has_clause_run( clause_statuses[i] )) && unregister_select( ... , clausei );
-        assignStmt = new ExprStmt( cLoc, 
-            UntypedExpr::createAssign( cLoc,
-                new NameExpr( cLoc, clauseData.at(i)->whenName ),
-                new LogicalExpr( cLoc,
-                    new CastExpr( cLoc,
-                        statusExpr, 
-                        new BasicType( BasicType::Kind::Bool ), GeneratedFlag::ExplicitCast 
-                    ),
-                    new CastExpr( cLoc,
-                        genSelectTraitCall( stmt->clauses.at(i), clauseData.at(i), "unregister_select" ),
-                        new BasicType( BasicType::Kind::Bool ), GeneratedFlag::ExplicitCast 
-                    ),
-                    LogicalFlag::AndExpr
-                )
-            )
-        );
-
-        if ( stmt->clauses.at(i)->when_cond ) // if ( when_cond_i ) assignStmt
-            unregisters->push_back( 
-                new IfStmt( cLoc,
-                    new NameExpr( cLoc, clauseData.at(i)->whenName ),
-                    new CompoundStmt( cLoc, { assignStmt } )
-                )
+        // (!__CFA_has_clause_run( clause_statuses[i] )) && unregister_select( ... , clausei );
+        statusExpr = new LogicalExpr( cLoc,
+            new CastExpr( cLoc,
+                statusExpr, 
+                new BasicType( BasicType::Kind::Bool ), GeneratedFlag::ExplicitCast 
+            ),
+            new CastExpr( cLoc,
+                genSelectTraitCall( stmt->clauses.at(i), clauseData.at(i), "unregister_select" ),
+                new BasicType( BasicType::Kind::Bool ), GeneratedFlag::ExplicitCast 
+            ),
+            LogicalFlag::AndExpr
+        );
+        
+        // if when cond defined generates:
+        // when_cond_i && (!__CFA_has_clause_run( clause_statuses[i] )) && unregister_select( ... , clausei );
+        if ( stmt->clauses.at(i)->when_cond )
+            statusExpr = new LogicalExpr( cLoc,
+                new CastExpr( cLoc,
+                    new NameExpr( cLoc, clauseData.at(i)->whenName ), 
+                    new BasicType( BasicType::Kind::Bool ), GeneratedFlag::ExplicitCast 
+                ),
+                new CastExpr( cLoc,
+                    statusExpr,
+                    new BasicType( BasicType::Kind::Bool ), GeneratedFlag::ExplicitCast 
+                ),
+                LogicalFlag::AndExpr
             );
-        else
-            unregisters->push_back( assignStmt );
-
-        unregisterStmts->push_back(
+
+        // generates:
+        // if ( statusExpr ) { ... clausei stmt ... }
+        unregisters->push_back( 
             new IfStmt( cLoc,
-                new NameExpr( cLoc, clauseData.at(i)->whenName ),
+                statusExpr,
                 genStmtBlock( stmt->clauses.at(i), clauseData.at(i) )
             )
@@ -1376 +1361 @@
         )
     );
-
-    body->push_back( unregisterStmts );
-    
 
     for ( ClauseData * datum : clauseData )