Changeset d9162ec for doc/proposals

Timestamp:

Dec 20, 2024, 1:56:12 PM (4 weeks ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

master

Children:

584612d

Parents:

b05d79d

Message:

Fix test-classification commands to detect more strict-capable tests. Remove such tests from the lax list.

Nothing about how to use the document is different, just what to paste.

Also, add back tests that give warnings only on release mode.

File:

• doc/proposals/nowarn.md (modified) (2 diffs)

doc/proposals/nowarn.md

@@ -52 +52 @@
    2. autogen, configure, make (as before)
 3. Rerun all the tests, expecting many failures.  Each failure represents a test that cannot handle strict wflags.
-   1. `./tests/test.py --all -j12 2>&1 | tee test-status.txt`
-   2. `grep 'PASSED  ' test-status.txt | sed -E 's/\s+(\.\.\.)?([^ ]+).*$/\2/g' > test-passes.txt`
-   3. `grep 'FAILED with' test-status.txt | sed -E 's/\s+(\.\.\.)?([^ ]+).*$/\2/g' > test-fails.txt`
+   1. `./tests/test.py --all ... 2>&1 | tee test-status.txt`
+   2. `grep 'PASSED  ' test-status.txt | sed -E 's/\s+([^ ]+).*$/\1/g' > test-passes.txt`
+   3. `grep 'FAILED with' test-status.txt | sed -E 's/\s+([^ ]+).*$/\1/g' > test-fails.txt`
 4. Trim the WFLGAS_OPT_LAX list, reconciling with the pass/fail status just obtained.
-   1. Copy-paste just the WFLAGS list items into `wflags-lax.txt`.  Keeping leading pounds and trailing backslashes is optional.
+   1. Copy-paste just the WFLGAS_OPT_LAX items into `wflags-lax.txt`.  Keeping leading pounds and trailing backslashes is optional.
    2. Print a list of tests found in `wflags-lax.txt` and also in `test-passes.txt`.  These tests were originally on WFLGAS_OPT_LAX, but can now pass without being on it.
-      - `sed -E 's/#|( *\\)//g' wflags-lax.txt | xargs -n 1 -I _ bash -c 'a=_;echo ${a:${#a}<32?0:-32}' | xargs -n 1 -I _ echo "grep -E '^_$' test-passes.txt" | sh`
+      - `sed -E 's/^([a-zA-Z])/(^|\\\\s|#)\1/g;s/\.\.\.//g;s/$/($|\\\\s|\\\\\\\\)/g' test-passes.txt | xargs -n 1 -I % echo "grep -E '%' wflags-lax.txt" | sh | sort`
    3. Note that in the running array-basic example, the resulting list was:
+      - array-collections/array-sbscr-types (*)
       - ctrl-flow/loopctrl
       - userLiterals
@@ -70 +71 @@
    5. autogen, configure, make (as before)
 5. Ensure that all tests pass, now under the reduced WFLGAS_OPT_LAX list.  Be deliberate about release mode and alternate architectures; i.e. that you aren't claiming to have fixed a test that always worked in x64-debug, but failed on a different configuration.  (Note that the overnight build will still catch that.)
+
+(*) This test was found later, upon fixing a problem in these instructions, so the original commit does not show it as fixed, like it does for the others.