Changeset d529ad0

Timestamp:

Mar 3, 2022, 3:17:05 PM (3 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, enum, master, pthread-emulation, qualifiedEnum

Children:

fc01219

Parents:

9cd44ba

Message:

Pending/Dirty? flags now use relaxed atomics since they can be set remotely

Location:

libcfa/src/concurrency

Files:

• io.cfa (modified) (3 diffs)
• kernel.cfa (modified) (1 diff)
• kernel.hfa (modified) (1 diff)

libcfa/src/concurrency/io.cfa

@@ -175 +175 @@
                         /* paranoid */ verify( ! __preemption_enabled() );
 
-                        ctx.proc->io.pending = false;
+                        __atomic_store_n(&ctx.proc->io.pending, false, __ATOMIC_RELAXED);
                 }
 
@@ -304 +304 @@
                 sq.to_submit += have;
 
-                ctx->proc->io.pending = true;
-                ctx->proc->io.dirty   = true;
+                __atomic_store_n(&ctx->proc->io.pending, true, __ATOMIC_RELAXED);
+                __atomic_store_n(&ctx->proc->io.dirty  , true, __ATOMIC_RELAXED);
         }
 
@@ -499 +499 @@
                 bool we = enqueue(ctx->ext_sq, (__outstanding_io&)ei);
 
-                ctx->proc->io.pending = true;
+                __atomic_store_n(&ctx->proc->io.pending, true, __ATOMIC_SEQ_CST);
 
                 if( we ) {

libcfa/src/concurrency/kernel.cfa

@@ -251 +251 @@
                         if( __atomic_load_n(&this->do_terminate, __ATOMIC_SEQ_CST) ) break MAIN_LOOP;
 
-                        if(this->io.pending && !this->io.dirty) {
+                        if(__atomic_load_n(&this->io.pending, __ATOMIC_RELAXED) && !__atomic_load_n(&this->io.dirty, __ATOMIC_RELAXED)) {
                                 __IO_STATS__(true, io.flush.dirty++; )
                                 __cfa_io_flush( this, 0 );

libcfa/src/concurrency/kernel.hfa

@@ -92 +92 @@
         struct {
                 $io_context * ctx;
-                bool pending;
-                bool dirty;
+                volatile bool pending;
+                volatile bool dirty;
         } io;