Changeset d3ba775 for libcfa/src

Timestamp:

May 3, 2021, 5:04:05 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

9fa538c

Parents:

eeb9f9f

Message:

More clean-up after new subqueue

Location:

libcfa/src/concurrency

Files:

• invoke.h (modified) (2 diffs)
• kernel/startup.cfa (modified) (1 diff)
• ready_queue.cfa (modified) (7 diffs)
• ready_subqueue.hfa (modified) (1 diff)
• thread.cfa (modified) (1 diff)

libcfa/src/concurrency/invoke.h

@@ -154 +154 @@
                 struct __stack_context_t context;
 
+                // Link lists fields
+                // instrusive link field for threads
+                struct __thread_desc_link link;
+
                 // current execution status for coroutine
                 // Possible values are:
@@ -168 +172 @@
                 struct cluster * curr_cluster;
 
-                // Link lists fields
-                // instrusive link field for threads
-                struct __thread_desc_link link;
+                // preferred ready-queue
+                unsigned preferred;
 
                 // coroutine body used to store context

libcfa/src/concurrency/kernel/startup.cfa

@@ -462 +462 @@
         link.next = 0p;
         link.ts   = 0;
-        link.preferred = -1u;
+        preferred = -1u;
         last_proc = 0p;
         #if defined( __CFA_WITH_VERIFY__ )

libcfa/src/concurrency/ready_queue.cfa

@@ -17 +17 @@
 // #define __CFA_DEBUG_PRINT_READY_QUEUE__
 
-// #define USE_MPSC
 
 #define USE_RELAXED_FIFO
@@ -274 +273 @@
                         #endif
 
-                #if defined(USE_MPSC)
-                        // mpsc always succeeds
-                } while( false );
-                #else
                         // If we can't lock it retry
                 } while( !__atomic_try_acquire( &lanes.data[i].lock ) );
-                #endif
 
                 // Actually push it
                 push(lanes.data[i], thrd);
 
-                #if !defined(USE_MPSC)
                         // Unlock and return
                         __atomic_unlock( &lanes.data[i].lock );
-                #endif
 
                 // Mark the current index in the tls rng instance as having an item
@@ -347 +339 @@
                 __cfadbg_print_safe(ready_queue, "Kernel : Pushing %p on cluster %p\n", thrd, cltr);
 
+                // #define USE_PREFERRED
+                #if !defined(USE_PREFERRED)
                 const bool external = (!kernelTLS().this_processor) || (cltr != kernelTLS().this_processor->cltr);
                 /* paranoid */ verify(external || kernelTLS().this_processor->rdq.id < lanes.count );
-
-                // write timestamp
-                #if !defined(USE_NEW_SUBQUEUE)
-                        thrd->link.ts = rdtscl();
+                #else
+                        unsigned preferred = thrd->preferred;
+                        const bool external = (!kernelTLS().this_processor) || preferred == -1u || thrd->curr_cluster != cltr;
+                        /* paranoid */ verifyf(external || preferred < lanes.count, "Invalid preferred queue %u for %u lanes", preferred, lanes.count );
+
+                        unsigned r = preferred % READYQ_SHARD_FACTOR;
+                        const unsigned start = preferred - r;
                 #endif
 
@@ -367 +364 @@
                         }
                         else {
+                                #if !defined(USE_PREFERRED)
                                 processor * proc = kernelTLS().this_processor;
                                 unsigned r = proc->rdq.its++;
                                 i =  proc->rdq.id + (r % READYQ_SHARD_FACTOR);
+                #else
+                                        i = start + (r++ % READYQ_SHARD_FACTOR);
+                                #endif
                         }
-
-
-                #if defined(USE_MPSC)
-                        // mpsc always succeeds
-                } while( false );
-                #else
                         // If we can't lock it retry
                 } while( !__atomic_try_acquire( &lanes.data[i].lock ) );
-                #endif
 
                 // Actually push it
                 push(lanes.data[i], thrd);
 
-                #if !defined(USE_MPSC)
                         // Unlock and return
                         __atomic_unlock( &lanes.data[i].lock );
-                #endif
 
                 #if !defined(__CFA_NO_STATISTICS__)
@@ -491 +483 @@
                 lanes.tscs[w].tv = thrd->link.ts;
         #endif
+
+        thrd->preferred = w;
 
         // return the popped thread
@@ -518 +512 @@
 // Check that all the intrusive queues in the data structure are still consistent
 static void check( __ready_queue_t & q ) with (q) {
-        #if defined(__CFA_WITH_VERIFY__) && !defined(USE_MPSC)
+        #if defined(__CFA_WITH_VERIFY__)
                 {
                         for( idx ; lanes.count ) {
@@ -553 +547 @@
 // fixes the list so that the pointers back to anchors aren't left dangling
 static inline void fix(__intrusive_lane_t & ll) {
-        #if !defined(USE_MPSC)
                         if(is_empty(ll)) {
                                 verify(ll.anchor.next == 0p);
                                 ll.prev = mock_head(ll);
                         }
-        #endif
 }
 

libcfa/src/concurrency/ready_subqueue.hfa

@@ -31 +31 @@
 
         // We add a boat-load of assertions here because the anchor code is very fragile
+        /* paranoid */ verify( offsetof( $thread, link ) == offsetof(__intrusive_lane_t, anchor) );
         /* paranoid */ verify( ((uintptr_t)( mock_head(this) ) + offsetof( $thread, link )) == (uintptr_t)(&this.anchor) );
         /* paranoid */ verify( &mock_head(this)->link.next == &this.anchor.next );

libcfa/src/concurrency/thread.cfa

@@ -39 +39 @@
         link.next = 0p;
         link.ts   = 0;
-        link.preferred = -1u;
+        preferred = -1u;
         last_proc = 0p;
         #if defined( __CFA_WITH_VERIFY__ )