Changeset ceedde6

Timestamp:

May 29, 2018, 4:15:33 PM (6 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, with_gc

Children:

1134b80

Parents:

8638cef

Message:

Fixed checks for number of mutex paramters on destructors and constructors

File:

• src/Concurrency/Keywords.cc (modified) (1 diff)

src/Concurrency/Keywords.cc

@@ -443 +443 @@
                 bool first = false;
                 std::list<DeclarationWithType*> mutexArgs = findMutexArgs( decl, first );
-                if( mutexArgs.empty() ) return;
-
-                if( CodeGen::isConstructor(decl->name) && first ) SemanticError( decl, "constructors cannot have mutex parameters" );
-
                 bool isDtor = CodeGen::isDestructor( decl->name );
 
+                // Is this function relevant to monitors
+                if( mutexArgs.empty() ) {
+                        // If this is the destructor for a monitor it must be mutex
+                        if(isDtor) {
+                                Type* ty = decl->get_functionType()->get_parameters().front()->get_type();
+
+                                // If it's a copy, it's not a mutex
+                                ReferenceType* rty = dynamic_cast< ReferenceType * >( ty );
+                                if( ! rty ) return;
+
+                                // If we are not pointing directly to a type, it's not a mutex
+                                Type* base = rty->get_base();
+                                if( dynamic_cast< ReferenceType * >( base ) ) return;
+                                if( dynamic_cast< PointerType * >( base ) ) return;
+
+                                // Check if its a struct
+                                StructInstType * baseStruct = dynamic_cast< StructInstType * >( base );
+                                if( !baseStruct ) return;
+
+                                // Check if its a monitor
+                                if(baseStruct->baseStruct->is_monitor() || baseStruct->baseStruct->is_thread())
+                                        SemanticError( decl, "destructors for structures declared as \"monitor\" must use mutex parameters\n" );
+                        }
+                        return;
+                }
+
+                // Monitors can't be constructed with mutual exclusion
+                if( CodeGen::isConstructor(decl->name) && !first ) SemanticError( decl, "constructors cannot have mutex parameters" );
+
+                // It makes no sense to have multiple mutex parameters for the destructor
                 if( isDtor && mutexArgs.size() != 1 ) SemanticError( decl, "destructors can only have 1 mutex argument" );
 
+                // Make sure all the mutex arguments are monitors
                 for(auto arg : mutexArgs) {
                         validate( arg );
                 }
 
+                // Check if we need to instrument the body
                 CompoundStmt* body = decl->get_statements();
                 if( ! body ) return;
 
+                // Do we have the required headers
                 if( !monitor_decl || !guard_decl || !dtor_guard_decl )
-                        SemanticError( decl, "mutex keyword requires monitors to be in scope, add #include <monitor>" );
-
+                        SemanticError( decl, "mutex keyword requires monitors to be in scope, add #include <monitor>\n" );
+
+                // Instrument the body
                 if( isDtor ) {
                         addDtorStatments( decl, body, mutexArgs );