Changeset ced5e2a for libcfa

Timestamp:

Jun 8, 2022, 4:22:24 PM (23 months ago)

Author:

caparsons <caparson@…>

Branches:

ADT, ast-experimental, master, pthread-emulation, qualifiedEnum

Children:

ae06e0b

Parents:

e5d9274

Message:

removed debug fields from spinlock_t

Location:

libcfa/src

Files:

• bits/locks.hfa (modified) (3 diffs)
• concurrency/kernel.cfa (modified) (1 diff)
• startup.cfa (modified) (1 diff)

libcfa/src/bits/locks.hfa

@@ -26 +26 @@
         // Wrap in struct to prevent false sharing with debug info
         volatile bool lock;
-        #ifdef __CFA_DEBUG__
-                // previous function to acquire the lock
-                const char * prev_name;
-                // previous thread to acquire the lock
-                void* prev_thrd;
-                // keep track of number of times we had to spin, just in case the number is unexpectedly huge
-                size_t spin_count;
-        #endif
 };
 
@@ -40 +32 @@
                 extern void disable_interrupts() OPTIONAL_THREAD;
                 extern void enable_interrupts( bool poll = true ) OPTIONAL_THREAD;
-
-                #ifdef __CFA_DEBUG__
-                        void __cfaabi_dbg_record_lock(__spinlock_t & this, const char prev_name[]);
-                #else
-                        #define __cfaabi_dbg_record_lock(x, y)
-                #endif
+                #define __cfaabi_dbg_record_lock(x, y)
         }
 
         static inline void ?{}( __spinlock_t & this ) {
                 this.lock = 0;
-                #ifdef __CFA_DEBUG__
-                        this.spin_count = 0;
-                #endif
         }
 
@@ -77 +61 @@
                 for ( unsigned int i = 1;; i += 1 ) {
                         if ( (this.lock == 0) && (__atomic_test_and_set( &this.lock, __ATOMIC_ACQUIRE ) == 0) ) break;
-                        #ifdef __CFA_DEBUG__
-                                this.spin_count++;
-                        #endif
                         #ifndef NOEXPBACK
                                 // exponential spin

libcfa/src/concurrency/kernel.cfa

@@ -834 +834 @@
 #endif
 
-
-
-//-----------------------------------------------------------------------------
-// Debug
-__cfaabi_dbg_debug_do(
-        extern "C" {
-                void __cfaabi_dbg_record_lock(__spinlock_t & this, const char prev_name[]) {
-                        this.prev_name = prev_name;
-                        this.prev_thrd = kernelTLS().this_thread;
-                }
-        }
-)
-
 //-----------------------------------------------------------------------------
 // Debug

libcfa/src/startup.cfa

@@ -63 +63 @@
 
 struct __spinlock_t;
-extern "C" {
-        void __cfaabi_dbg_record_lock(struct __spinlock_t & this, const char prev_name[]) __attribute__(( weak )) libcfa_public {}
-}
 
 // Local Variables: //