Changes in / [18d7aaf:ce0b8b8]

File:

• src/ResolvExpr/CandidateFinder.cpp (modified) (5 diffs)

src/ResolvExpr/CandidateFinder.cpp

@@ -522 +522 @@
                                                                 CandidateFinder subFinder( context, env );
                                                                 expr = subFinder.makeEnumOffsetCast(argAsEnum, paramAsEnum, expr, c);
-                                                                if ( expr )
-                                                                        results.emplace_back(
-                                                                                i, expr, std::move( env ), std::move( need ), std::move( have ), std::move( open ),
-                                                                                nextArg + 1, nTuples, expl.cost + c, expl.exprs.size() == 1 ? 0 : 1, j );
+                                                                results.emplace_back(
+                                                                        i, expr, std::move( env ), std::move( need ), std::move( have ), std::move( open ),
+                                                                        nextArg + 1, nTuples, expl.cost + c, expl.exprs.size() == 1 ? 0 : 1, j );
                                                                 continue;
                                                         } else {
@@ -1266 +1265 @@
                                 CandidateFinder subFinder(context, tenv);
                                 ast::ptr<ast::Expr> offsetExpr = subFinder.makeEnumOffsetCast(argAsEnum, toAsEnum, cand->expr, thisCost);
-                                if ( offsetExpr )
-                                        cand->expr = offsetExpr;
+                                cand->expr = offsetExpr;
                         }
 
@@ -2153 +2151 @@
 
 const ast::Expr * CandidateFinder::makeEnumOffsetCast( const ast::EnumInstType * src, 
-        const ast::EnumInstType * dst, const ast::Expr * expr, Cost minCost ) {
+        const ast::EnumInstType * dst,
+        const ast::Expr * expr,
+        Cost minCost ) {
+        
         auto srcDecl = src->base;
         auto dstDecl = dst->base;
@@ -2178 +2179 @@
                                 CandidateRef & choice = winners.front();
                                 choice->expr = new ast::CastExpr(expr->location, choice->expr, dstChild, ast::GeneratedFlag::ExplicitCast);
-                                auto destExpr = makeEnumOffsetCast( src, dstChild, choice->expr, minCost );
-                                if ( !destExpr ) continue;
-                                castToDst = new ast::CastExpr( destExpr, dst );
+                                castToDst = new ast::CastExpr( 
+                                        makeEnumOffsetCast( src, dstChild, choice->expr, minCost ),
+                                        dst);
                         } else {
                                 castToDst = new ast::CastExpr( expr, dst );
@@ -2187 +2188 @@
                 }
         }
+        SemanticError(expr, src->base->name + " is not a subtype of " + dst->base->name);
         return nullptr;
 }