Changeset cccc534

Timestamp:

Sep 1, 2017, 10:27:39 AM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

7d9ad510

Parents:

058f549

Message:

Minor cleanup in Box and GenPoly?

Location:

src

Files:

• GenPoly/Box.cc (modified) (2 diffs)
• GenPoly/GenPoly.cc (modified) (3 diffs)
• Parser/ExpressionNode.cc (modified) (1 diff)

src/GenPoly/Box.cc

@@ -896 +896 @@
                                 addAdapterParams( adapteeApp, arg, param, adapterType->get_parameters().end(), realParam, tyVars );
                                 bodyStmt = new ExprStmt( noLabels, adapteeApp );
-//                      } else if ( isPolyType( adaptee->get_returnVals().front()->get_type(), tyVars ) ) {
                         } else if ( isDynType( adaptee->get_returnVals().front()->get_type(), tyVars ) ) {
                                 // return type T
@@ -1550 +1549 @@
                                         // (alloca was previously used, but can't be safely used in loops)
                                         Type *declType = objectDecl->get_type();
-                                        std::string bufName = bufNamer.newName();
-                                        ObjectDecl *newBuf = new ObjectDecl( bufName, Type::StorageClasses(), LinkageSpec::C, 0,
+                                        ObjectDecl *newBuf = new ObjectDecl( bufNamer.newName(), Type::StorageClasses(), LinkageSpec::C, 0,
                                                 new ArrayType( Type::Qualifiers(), new BasicType( Type::Qualifiers(), BasicType::Kind::Char), new NameExpr( sizeofName( mangleType(declType) ) ),
-                                                true, false, std::list<Attribute*>{ new Attribute( std::string{"aligned"}, std::list<Expression*>{ new ConstantExpr( Constant::from_int(8) ) } ) } ), 0 );
+                                                true, false, std::list<Attribute*>{ new Attribute( "aligned", std::list<Expression*>{ new ConstantExpr( Constant::from_int(8) ) } ) } ), 0 );
                                         stmtsToAdd.push_back( new DeclStmt( noLabels, newBuf ) );
 
                                         delete objectDecl->get_init();
-
-                                        objectDecl->set_init( new SingleInit( new NameExpr( bufName ) ) );
+                                        objectDecl->set_init( new SingleInit( new VariableExpr( newBuf ) ) );
                                 }
                         }

src/GenPoly/GenPoly.cc

@@ -336 +336 @@
                                 assertf(bparam, "Aggregate parameters should be type expressions");
 
-                                // xxx - might need to let VoidType be a wildcard here too; could have some voids 
+                                // xxx - might need to let VoidType be a wildcard here too; could have some voids
                                 // stuffed in for dtype-statics.
                                 // if ( is<VoidType>( aparam->get_type() ) || is<VoidType>( bparam->get_type() ) ) continue;
                                 if ( ! typesPolyCompatible( aparam->get_type(), bparam->get_type() ) ) return false;
                         }
-                        
+
                         return true;
                 }
@@ -350 +350 @@
                 // polymorphic types always match
                 if ( aid == type_index{typeid(TypeInstType)} ) return true;
-                
+
                 type_index bid{ typeid(*b) };
                 // polymorphic types always match
                 if ( bid == type_index{typeid(TypeInstType)} ) return true;
-                
+
                 // can't match otherwise if different types
                 if ( aid != bid ) return false;
@@ -377 +377 @@
                                 ConstantExpr *ad = dynamic_cast<ConstantExpr*>( aa->get_dimension() );
                                 ConstantExpr *bd = dynamic_cast<ConstantExpr*>( ba->get_dimension() );
-                                if ( ad && bd 
+                                if ( ad && bd
                                                 && ad->get_constant()->get_value() != bd->get_constant()->get_value() )
                                         return false;

src/Parser/ExpressionNode.cc

@@ -314 +314 @@
 Expression * build_unary_ptr( OperKinds op, ExpressionNode * expr_node ) {
         std::list< Expression * > args;
-        args.push_back(  maybeMoveBuild< Expression >(expr_node) ); // xxx
+        args.push_back(  maybeMoveBuild< Expression >(expr_node) ); // xxx -- this is exactly the same as the val case now, refactor this code.
         return new UntypedExpr( new NameExpr( OperName[ (int)op ] ), args );
 } // build_unary_ptr