Changeset caf06aa

Timestamp:

Jun 20, 2023, 3:59:33 PM (17 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

132e4c1, da0edec

Parents:

70d8e2f2

Message:

Added the check for bitfields in sized polymorphic types. It was folded into a logically related but implimentationally seprate pass.

Files:

• src/Validate/GenericParameter.cpp (modified) (2 diffs)
• tests/.expect/polybits.txt (added)
• tests/polybits.cfa (added)

src/Validate/GenericParameter.cpp

@@ -120 +120 @@
 }
 
-struct ValidateGenericParamsCore : public ast::WithCodeLocation {
+bool isSizedPolymorphic( const ast::AggregateDecl * decl ) {
+        for ( const auto & param : decl->params ) {
+                if ( param->sized ) return true;
+        }
+        return false;
+}
+
+struct ValidateGenericParamsCore :
+                public ast::WithCodeLocation, public ast::WithGuards {
+        // Generic parameter filling and checks:
         const ast::StructInstType * previsit( const ast::StructInstType * type ) {
                 assert( location );
@@ -129 +138 @@
                 assert( location );
                 return validateGeneric( *location, type );
+        }
+
+        // Check parameter and bitfield combinations:
+        bool insideSized = false;
+        void previsit( const ast::StructDecl * decl ) {
+                if ( isSizedPolymorphic( decl ) && !insideSized ) {
+                        GuardValue( insideSized ) = true;
+                }
+        }
+
+        void previsit( const ast::UnionDecl * decl ) {
+                if ( isSizedPolymorphic( decl ) && !insideSized ) {
+                        GuardValue( insideSized ) = true;
+                }
+        }
+
+        void previsit( const ast::ObjectDecl * decl ) {
+                if ( insideSized && decl->bitfieldWidth ) {
+                        SemanticError( decl->location, decl,
+                                "Cannot have bitfields inside a sized polymorphic structure." );
+                }
         }
 };