Changeset c92c09c for src/Tuples

Timestamp:

Aug 8, 2017, 2:50:30 PM (8 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

43f8fd8

Parents:

acd7c5dd

Message:

Add tuple parameter bindings to type substitution

File:

• src/Tuples/TupleExpansion.cc (modified) (6 diffs)

src/Tuples/TupleExpansion.cc

@@ -66 +66 @@
                 };
 
-                class TupleTypeReplacer : public GenPoly::DeclMutator {
-                  public:
-                        typedef GenPoly::DeclMutator Parent;
-                        using Parent::mutate;
-
-                        virtual Type * mutate( TupleType * tupleType ) override;
-
-                        virtual CompoundStmt * mutate( CompoundStmt * stmt ) override {
-                                typeMap.beginScope();
-                                stmt = Parent::mutate( stmt );
-                                typeMap.endScope();
-                                return stmt;
+                struct TupleTypeReplacer : public WithDeclsToAdd, public WithGuards, public WithTypeSubstitution {
+                        Type * postmutate( TupleType * tupleType );
+
+                        void premutate( CompoundStmt * ) {
+                                GuardScope( typeMap );
                         }
                   private:
@@ -111 +104 @@
                 mutateAll( translationUnit, assnExpander );
 
-                TupleTypeReplacer replacer;
-                replacer.mutateDeclarationList( translationUnit );
+                PassVisitor<TupleTypeReplacer> replacer;
+                mutateAll( translationUnit, replacer );
 
                 PassVisitor<TupleIndexExpander> idxExpander;
@@ -218 +211 @@
         }
 
-        Type * TupleTypeReplacer::mutate( TupleType * tupleType ) {
-                tupleType = safe_dynamic_cast< TupleType * > ( Parent::mutate( tupleType ) );
+        Type * TupleTypeReplacer::postmutate( TupleType * tupleType ) {
                 unsigned tupleSize = tupleType->size();
                 if ( ! typeMap.count( tupleSize ) ) {
@@ -226 +218 @@
                         decl->set_body( true );
                         for ( size_t i = 0; i < tupleSize; ++i ) {
-                                TypeDecl * tyParam = new TypeDecl( toString( "tuple_param_", i ), Type::StorageClasses(), nullptr, TypeDecl::Any );
+                                TypeDecl * tyParam = new TypeDecl( toString( "tuple_param_", tupleSize, "_", i ), Type::StorageClasses(), nullptr, TypeDecl::Any );
                                 decl->get_members().push_back( new ObjectDecl( toString("field_", i ), Type::StorageClasses(), LinkageSpec::C, nullptr, new TypeInstType( Type::Qualifiers(), tyParam->get_name(), tyParam ), nullptr ) );
                                 decl->get_parameters().push_back( tyParam );
@@ -235 +227 @@
                         }
                         typeMap[tupleSize] = decl;
-                        addDeclaration( decl );
+                        declsToAddBefore.push_back( decl );
                 }
                 Type::Qualifiers qualifiers = tupleType->get_qualifiers();
@@ -241 +233 @@
                 StructDecl * decl = typeMap[tupleSize];
                 StructInstType * newType = new StructInstType( qualifiers, decl );
-                for ( Type * t : *tupleType ) {
+                for ( auto p : group_iterate( tupleType->get_types(), decl->get_parameters() ) ) {
+                        Type * t = std::get<0>(p);
+                        TypeDecl * td = std::get<1>(p);
                         newType->get_parameters().push_back( new TypeExpr( t->clone() ) );
+                        if ( env ) {
+                                // add bindings to the type environment.
+                                // xxx - This may not be sufficient, it may be necessary to rename type variables on StructInstType?
+                                env->add( td->get_name(), t->clone() );
+                        }
                 }
                 delete tupleType;