Changes in src/ResolvExpr/Unify.cc [07de76b:c7f834e]

File:

• src/ResolvExpr/Unify.cc (modified) (9 diffs)

src/ResolvExpr/Unify.cc

@@ -25 +25 @@
 #include <vector>
 
+#include "AST/Copy.hpp"
 #include "AST/Decl.hpp"
 #include "AST/Node.hpp"
 #include "AST/Pass.hpp"
+#include "AST/Print.hpp"
 #include "AST/Type.hpp"
 #include "AST/TypeEnvironment.hpp"
@@ -135 +137 @@
                 findOpenVars( newSecond, open, closed, need, have, FirstOpen );
 
-                return unifyExact(
-                        newFirst, newSecond, newEnv, need, have, open, noWiden(), symtab );
+                return unifyExact(newFirst, newSecond, newEnv, need, have, open, noWiden(), symtab );
         }
 
@@ -148 +149 @@
                 newFirst->get_qualifiers() = Type::Qualifiers();
                 newSecond->get_qualifiers() = Type::Qualifiers();
-///   std::cerr << "first is ";
-///   first->print( std::cerr );
-///   std::cerr << std::endl << "second is ";
-///   second->print( std::cerr );
-///   std::cerr << std::endl << "newFirst is ";
-///   newFirst->print( std::cerr );
-///   std::cerr << std::endl << "newSecond is ";
-///   newSecond->print( std::cerr );
-///   std::cerr << std::endl;
+
                 bool result = unifyExact( newFirst, newSecond, newEnv, needAssertions, haveAssertions, openVars, WidenMode( false, false ), indexer );
                 delete newFirst;
@@ -170 +163 @@
                 ast::AssertionSet need, have;
 
-                ast::ptr<ast::Type> newFirst{ first }, newSecond{ second };
-                env.apply( newFirst );
-                env.apply( newSecond );
-                reset_qualifiers( newFirst );
-                reset_qualifiers( newSecond );
+                ast::Type * newFirst  = shallowCopy( first  );
+                ast::Type * newSecond = shallowCopy( second );
+                newFirst ->qualifiers = {};
+                newSecond->qualifiers = {};
+                ast::ptr< ast::Type > t1_(newFirst );
+                ast::ptr< ast::Type > t2_(newSecond);
+
+                ast::ptr< ast::Type > subFirst = env.apply(newFirst).node;
+                ast::ptr< ast::Type > subSecond = env.apply(newSecond).node;
 
                 return unifyExact(
-                        newFirst, newSecond, newEnv, need, have, open, noWiden(), symtab );
+                        subFirst,
+                        subSecond,
+                        newEnv, need, have, open, noWiden(), symtab );
         }
 
@@ -326 +325 @@
 
         void markAssertionSet( AssertionSet &assertions, DeclarationWithType *assert ) {
-///   std::cerr << "assertion set is" << std::endl;
-///   printAssertionSet( assertions, std::cerr, 8 );
-///   std::cerr << "looking for ";
-///   assert->print( std::cerr );
-///   std::cerr << std::endl;
                 AssertionSet::iterator i = assertions.find( assert );
                 if ( i != assertions.end() ) {
-///     std::cerr << "found it!" << std::endl;
                         i->second.isUsed = true;
                 } // if
@@ -943 +936 @@
 
         private:
-                template< typename RefType >
-                const RefType * handleRefType( const RefType * inst, const ast::Type * other ) {
+                // Returns: other, cast as XInstType
+                // Assigns this->result: whether types are compatible (up to generic parameters)
+                template< typename XInstType >
+                const XInstType * handleRefType( const XInstType * inst, const ast::Type * other ) {
                         // check that the other type is compatible and named the same
-                        auto otherInst = dynamic_cast< const RefType * >( other );
-                        result = otherInst && inst->name == otherInst->name;
+                        auto otherInst = dynamic_cast< const XInstType * >( other );
+                        this->result = otherInst && inst->name == otherInst->name;
                         return otherInst;
                 }
@@ -968 +963 @@
                 }
 
-                template< typename RefType >
-                void handleGenericRefType( const RefType * inst, const ast::Type * other ) {
+                template< typename XInstType >
+                void handleGenericRefType( const XInstType * inst, const ast::Type * other ) {
                         // check that other type is compatible and named the same
-                        const RefType * inst2 = handleRefType( inst, other );
-                        if ( ! inst2 ) return;
+                        const XInstType * otherInst = handleRefType( inst, other );
+                        if ( ! this->result ) return;
 
                         // check that parameters of types unify, if any
                         const std::vector< ast::ptr< ast::Expr > > & params = inst->params;
-                        const std::vector< ast::ptr< ast::Expr > > & params2 = inst2->params;
+                        const std::vector< ast::ptr< ast::Expr > > & params2 = otherInst->params;
 
                         auto it = params.begin();
@@ -1202 +1197 @@
                 // force t1 and t2 to be cloned if their qualifiers must be stripped, so that type1 and
                 // type2 are left unchanged; calling convention forces type{1,2}->strong_ref >= 1
-                ast::ptr<ast::Type> t1{ type1 }, t2{ type2 };
-                reset_qualifiers( t1 );
-                reset_qualifiers( t2 );
+                ast::Type * t1 = shallowCopy(type1.get());
+                ast::Type * t2 = shallowCopy(type2.get());
+                t1->qualifiers = {};
+                t2->qualifiers = {};
+                ast::ptr< ast::Type > t1_(t1);
+                ast::ptr< ast::Type > t2_(t2);
 
                 if ( unifyExact( t1, t2, env, need, have, open, widen, symtab ) ) {
-                        t1 = nullptr; t2 = nullptr; // release t1, t2 to avoid spurious clones
-
                         // if exact unification on unqualified types, try to merge qualifiers
                         if ( q1 == q2 || ( ( q1 > q2 || widen.first ) && ( q2 > q1 || widen.second ) ) ) {
-                                common = type1;
-                                reset_qualifiers( common, q1 | q2 );
+                                t1->qualifiers = q1 | q2;
+                                common = t1;
                                 return true;
                         } else {
@@ -1219 +1215 @@
 
                 } else if (( common = commonType( t1, t2, widen, symtab, env, open ) )) {
-                        t1 = nullptr; t2 = nullptr; // release t1, t2 to avoid spurious clones
-
                         // no exact unification, but common type
-                        reset_qualifiers( common, q1 | q2 );
+                        auto c = shallowCopy(common.get());
+                        c->qualifiers = q1 | q2;
+                        common = c;
                         return true;
                 } else {