Changeset c519942 for src/ResolvExpr

Timestamp:

May 28, 2019, 2:22:03 PM (5 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

eba615c

Parents:

6f4b7f2

git-author:

Aaron Moss <a3moss@…> (05/28/19 14:21:58)

git-committer:

Aaron Moss <a3moss@…> (05/28/19 14:22:03)

Message:

Fix bugs in assertion satisfaction costing

• Calculate vars/spec cost based on satisfying decl not assn decl
• Correct caching behaviour for defer combo costs

File:

• src/ResolvExpr/ResolveAssertions.cc (modified) (3 diffs)

src/ResolvExpr/ResolveAssertions.cc

@@ -103 +103 @@
                         OpenVarSet openVars;
                         std::vector<DeferRef> assns;
+                        Cost cost;
 
                         OutType( const TypeEnvironment& env, const OpenVarSet& openVars, 
                                 const std::vector<DeferRef>& assns )
-                        : env(env), openVars(openVars), assns(assns) {}
+                        : env(env), openVars(openVars), assns(assns), cost(Cost::infinity) {}
                 };
 
@@ -140 +141 @@
                 using Element = CandidateEnvMerger::OutType;
         private:
-                using Memo = std::unordered_map<const Element*, Cost>;
-                mutable Memo cache;              ///< cache of element costs
                 const SymTab::Indexer& indexer;  ///< Indexer for costing
 
@@ -148 +147 @@
 
                 /// reports the cost of an element
-                Cost get( const Element& x ) const {
-                        Memo::const_iterator it = cache.find( &x );
-                        if ( it == cache.end() ) {
-                                Cost k = Cost::zero;
-                                for ( const auto& assn : x.assns ) {
-                                        k += computeConversionCost( 
-                                                assn.match.adjType, assn.decl->get_type(), indexer, x.env );
-                                        
-                                        // mark vars+specialization cost on function-type assertions
-                                        PointerType* ptr = dynamic_cast< PointerType* >( assn.decl->get_type() );
-                                        if ( ! ptr ) continue;
-                                        FunctionType* func = dynamic_cast< FunctionType* >( ptr->base );
-                                        if ( ! func ) continue;
-                                        
-                                        for ( DeclarationWithType* formal : func->parameters ) {
-                                                k.decSpec( specCost( formal->get_type() ) );
-                                        }
-                                        k.incVar( func->forall.size() );
-                                        for ( TypeDecl* td : func->forall ) {
-                                                k.decSpec( td->assertions.size() );
-                                        }
-                                }
-                                it = cache.emplace_hint( it, &x, k );
+                Cost get( Element& x ) const {
+                        // check cached cost
+                        if ( x.cost != Cost::infinity ) return x.cost;
+
+                        // generate cost
+                        Cost k = Cost::zero;
+                        for ( const auto& assn : x.assns ) {
+                                k += computeConversionCost( 
+                                        assn.match.adjType, assn.decl->get_type(), indexer, x.env );
+                                
+                                // mark vars+specialization cost on function-type assertions
+                                Type* assnType = assn.match.cdata.id->get_type();
+                                FunctionType* func;
+                                if ( PointerType* ptr = dynamic_cast< PointerType* >( assnType ) ) {
+                                        func = dynamic_cast< FunctionType* >( ptr->base );
+                                } else {
+                                        func = dynamic_cast< FunctionType* >( assnType );
+                                }
+                                if ( ! func ) continue;
+                                
+                                for ( DeclarationWithType* formal : func->parameters ) {
+                                        k.decSpec( specCost( formal->get_type() ) );
+                                }
+                                k.incVar( func->forall.size() );
+                                for ( TypeDecl* td : func->forall ) {
+                                        k.decSpec( td->assertions.size() );
+                                }
                         }
-                        return it->second;
+
+                        // cache and return
+                        x.cost = k;
+                        return k;
                 }
                 
                 /// compares elements by cost
-                bool operator() ( const Element& a, const Element& b ) const {
+                bool operator() ( Element& a, Element& b ) const {
                         return get( a ) < get( b );
                 }