Changeset c4241b6

Timestamp:

Jan 5, 2021, 2:51:53 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

ed1a6374

Parents:

abc2a643

Message:

Minor benchmark fixes and added locality implementation for libfibre

Location:

benchmark/readyQ

Files:

• cycle.cpp (modified) (1 diff)
• locality.cfa (modified) (3 diffs)
• locality.cpp (added)
• rq_bench.hpp (modified) (6 diffs)

benchmark/readyQ/cycle.cpp

@@ -71 +71 @@
                 { 'r', "ringsize", "Number of threads in a cycle", ring_size }
         };
-        BENCH_OPT_PARSE("cforall cycle benchmark");
+        BENCH_OPT_PARSE("libfibre cycle benchmark");
 
         {

benchmark/readyQ/locality.cfa

@@ -8 +8 @@
 
 // ==================================================
-thread MyThread {
+thread __attribute__((aligned(128))) MyThread {
         struct MyData * volatile data;
 
@@ -35 +35 @@
 
 // ==================================================
-struct MyData {
+struct __attribute__((aligned(128))) MyData {
         uint64_t _p1[16];  // padding
         uint64_t * data;
@@ -71 +71 @@
 // Atomic object where a single thread can wait
 // May exchanges data
-struct MySpot {
+struct __attribute__((aligned(128))) MySpot {
         MyThread * volatile ptr;
         size_t id;

benchmark/readyQ/rq_bench.hpp

@@ -97 +97 @@
 }
 
+bool parse_truefalse(const char * arg, bool & value) {
+        if(strcmp(arg, "true") == 0) {
+                value = true;
+                return true;
+        }
+
+        if(strcmp(arg, "false") == 0) {
+                value = false;
+                return true;
+        }
+
+        return false;
+}
+
 bool parse_settrue (const char *, bool & value ) {
         value = true;
@@ -226 +240 @@
         {
                 int idx = 0;
-                for(int i = 0; i < opt_count; i++) {
+                for(size_t i = 0; i < opt_count; i++) {
                         if(options[i].long_name) {
                                 optarr[idx].name = options[i].long_name;
@@ -256 +270 @@
         {
                 int idx = 0;
-                for(int i = 0; i < opt_count; i++) {
+                for(size_t i = 0; i < opt_count; i++) {
                         optstring[idx] = options[i].short_name;
                         idx++;
@@ -279 +293 @@
                         case 'h':
                                 out = stdout;
+                                [[fallthrough]];
                         case '?':
                                 usage(argv[0], options, opt_count, usage_msg, out);
                         default:
-                                for(int i = 0; i < opt_count; i++) {
+                                for(size_t i = 0; i < opt_count; i++) {
                                         if(opt == options[i].short_name) {
                                                 const char * arg = optarg ? optarg : "";
+                                                if( arg[0] == '=' ) { arg++; }
                                                 bool success = options[i].parse_fun( arg, options[i].variable );
                                                 if(success) goto NEXT_ARG;
@@ -319 +335 @@
         int width = 0;
         {
-                for(int i = 0; i < opt_count; i++) {
+                for(size_t i = 0; i < opt_count; i++) {
                         if(options[i].long_name) {
                                 int w = strlen(options[i].long_name);
@@ -338 +354 @@
         fprintf(out, "Usage:\n  %s %s\n", cmd, help);
 
-        for(int i = 0; i < opt_count; i++) {
+        for(size_t i = 0; i < opt_count; i++) {
                 printopt(out, width, max_width, options[i].short_name, options[i].long_name, options[i].help);
         }