Changeset c36a419

Timestamp:

Nov 21, 2023, 2:27:10 PM (6 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

8984003

Parents:

4883712

Message:

Removed Decl::fromId as it was unused. There are a few places that use uniqueId directly.

Location:

src/AST

Files:

• Decl.cpp (modified) (1 diff)
• Decl.hpp (modified) (1 diff)

src/AST/Decl.cpp

@@ -33 +33 @@
 static UniqueId lastUniqueId = 0;
 
-using IdMapType = std::unordered_map< UniqueId, readonly<Decl> >;
-static IdMapType idMap;
-
 void Decl::fixUniqueId() {
         if ( uniqueId ) return;  // ensure only set once
         uniqueId = ++lastUniqueId;
-        // The extra readonly pointer is causing some reference counting issues.
-        // idMap[ uniqueId ] = this;
-}
-
-readonly<Decl> Decl::fromId( UniqueId id ) {
-        // Right now this map is always empty, so don't use it.
-        assert( false );
-        IdMapType::const_iterator i = idMap.find( id );
-        if ( i != idMap.end() ) return i->second;
-        return {};
 }
 

src/AST/Decl.hpp

@@ -56 +56 @@
         /// Ensures this node has a unique ID
         void fixUniqueId();
-        /// Get canonical declaration for unique ID
-        static readonly<Decl> fromId( UniqueId id );
 
         const Decl * accept( Visitor & v ) const override = 0;