Changeset c248b39 for src

Timestamp:

Jul 18, 2024, 12:52:39 PM (5 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

f107afe

Parents:

6804f38

Message:

Unlabelled breaks were not targetting the correct enclosing control structures. Also added a test and improved error messages.

File:

• src/ControlStruct/MultiLevelExit.cpp (modified) (4 diffs)

src/ControlStruct/MultiLevelExit.cpp

@@ -84 +84 @@
         bool isFallDefaultTarget() const { return kind == SwitchStmtK; }
 
+        // Check if this entry can be the target of an unlabelled break.
+        bool isUnlabelledBreakTarget() const { return kind <= WhileDoStmtK || kind == SwitchStmtK; }
+
         // These routines set a target as being "used" by a BranchStmt
         Label useContExit() { assert( kind <= WhileDoStmtK ); return useTarget(secondTarget); }
@@ -114 +117 @@
 bool isFallthroughDefaultTarget( const Entry & entry ) {
         return entry.isFallDefaultTarget();
+}
+
+bool isUnlabelledBreakTarget( const Entry & entry ) {
+        return entry.isUnlabelledBreakTarget();
 }
 
@@ -247 +254 @@
         case BranchStmt::Break: {
                 bool isContinue = stmt->kind == BranchStmt::Continue;
-                // Handle unlabeled break and continue.
-                if ( stmt->target.empty() ) {
-                        if ( isContinue ) {
-                                targetEntry = findEnclosingControlStructure( isContinueTarget );
-                        } else {
-                                if ( enclosing_control_structures.empty() ) {
-                                          SemanticError( stmt->location,
-                                                                         "\"break\" outside a loop, \"switch\", or labelled block" );
-                                }
-                                targetEntry = findEnclosingControlStructure( isBreakTarget );
+                // Handle unlabeled continue.
+                if ( isContinue && stmt->target.empty() ) {
+                        targetEntry = findEnclosingControlStructure( isContinueTarget );
+                        if ( targetEntry == enclosing_control_structures.rend() ) {
+                                SemanticError( stmt->location,
+                                               "\"continue\" outside a loop" );
                         }
-                        // Handle labeled break and continue.
+                // Handle unlabeled break.
+                } else if ( stmt->target.empty() ) {
+                        targetEntry = findEnclosingControlStructure( isUnlabelledBreakTarget );
+                        if ( targetEntry == enclosing_control_structures.rend() ) {
+                                SemanticError( stmt->location,
+                                               "\"break\" outside a loop or \"switch\"" );
+                        }
+                // Handle labeled break and continue.
                 } else {
                         // Lookup label in table to find attached control structure.
@@ -265 +275 @@
                                           return entry.stmt == targetStmt;
                                 } );
-                }
-                // Ensure that selected target is valid.
-                if ( targetEntry == enclosing_control_structures.rend() || ( isContinue && ! isContinueTarget( *targetEntry ) ) ) {
-                        SemanticError( stmt->location, toString( (isContinue ? "\"continue\"" : "\"break\""),
-                                                        " target must be an enclosing ", (isContinue ? "loop: " : "control structure: "),
-                                                        stmt->originalTarget ) );
+                        // Ensure that selected target is valid.
+                        if ( targetEntry == enclosing_control_structures.rend()
+                                        || ( isContinue ? !isContinueTarget( *targetEntry ) : !isBreakTarget( *targetEntry ) ) ) {
+                                SemanticError( stmt->location, toString( (isContinue ? "\"continue\"" : "\"break\""),
+                                               " target must be an enclosing ", (isContinue ? "loop: " : "control structure: "),
+                                               stmt->originalTarget ) );
+                        }
                 }
                 break;