Changeset c0ec8b6 for libcfa/src/concurrency

Timestamp:

May 15, 2023, 1:15:43 PM (21 months ago)

Author:

caparsons <caparson@…>

Branches:

ADT, ast-experimental, master

Children:

e23b3ce

Parents:

629c95a

Message:

fixed bug in waituntil and future interop where signals could be lost

File:

• libcfa/src/concurrency/future.hfa (modified) (3 diffs)

libcfa/src/concurrency/future.hfa

@@ -52 +52 @@
         }
 
-        void ?{}(future(T) & this) {
+        void ?{}( future(T) & this ) {
                         this.waiters{};
             this.state = FUTURE_EMPTY;
@@ -59 +59 @@
 
                 // Reset future back to original state
-                void reset(future(T) & this) with(this)
+                void reset( future(T) & this ) with(this)
         {
             lock( lock );
@@ -85 +85 @@
                 select_node &s = try_pop_front( waiters );
 
-                if ( s.clause_status == 0p )
-                    // poke in result so that woken threads do not need to reacquire any locks
+                if ( s.clause_status == 0p ) // poke in result so that woken threads do not need to reacquire any locks
                     copy_T( result, *(((future_node(T) &)s).my_result) );
-                else if ( !__make_select_node_available( s ) ) continue;
                 
-                // only unpark if future is not selected
-                // or if it is selected we only unpark if we win the race
-                unpark( s.blocked_thread );
+                wake_one( waiters, s );
             }
         }