Changeset bfeb37a6

Timestamp:

Sep 13, 2023, 11:46:22 AM (16 months ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

efe420f3

Parents:

1ed5e9e

Message:

Added another check to the invariants for SizeofExpr/AlignofExpr?.

File:

• src/AST/Util.cpp (modified) (3 diffs)

src/AST/Util.cpp

@@ -104 +104 @@
         }
         assertf( false, "Member not found." );
+}
+
+template<typename node_t>
+void oneOfExprOrType( const node_t * node ) {
+        if ( node->expr ) {
+                assertf( node->expr && !node->type, "Exactly one of expr or type should be set." );
+        } else {
+                assertf( !node->expr && node->type, "Exactly one of expr or type should be set." );
+        }
 }
 
@@ -152 +161 @@
         }
 
+        void previsit( const SizeofExpr * node ) {
+                previsit( (const ParseNode *)node );
+                oneOfExprOrType( node );
+        }
+
+        void previsit( const AlignofExpr * node ) {
+                previsit( (const ParseNode *)node );
+                oneOfExprOrType( node );
+        }
+
         void previsit( const StructInstType * node ) {
                 previsit( (const Node *)node );
@@ -181 +200 @@
 /// referring to is in scope by the structural rules of code.
 // Any escapes marked with a bug should be removed once the bug is fixed.
+// This is a separate pass because of it changes the visit pattern and
+// must always be run on the entire translation unit.
 struct InScopeCore : public ast::WithShortCircuiting {
         ScopedSet<DeclWithType const *> typedDecls;