Changes in src/SynTree/CommaExpr.cc [b4f8808:bf4b4cf]

File:

• src/SynTree/CommaExpr.cc (modified) (3 diffs)

src/SynTree/CommaExpr.cc

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Mon May 18 07:44:20 2015
-// Last Modified By : Andrew Beach
-// Last Modified On : Mon Arg 12 16:11:00 2016
-// Update Count     : 2
+// Last Modified By : Rob Schluntz
+// Last Modified On : Mon May 02 15:19:44 2016
+// Update Count     : 1
 //
 
@@ -23 +23 @@
 CommaExpr::CommaExpr( Expression *arg1, Expression *arg2 )
                 : Expression(), arg1( arg1 ), arg2( arg2 ) {
+        // xxx - result of a comma expression is never an lvalue, so should set lvalue
+        // to false on all result types. Actually doing this causes some strange things
+        // to happen in later passes (particularly, Specialize, Lvalue, and Box). This needs to be looked into.
         set_result( maybeClone( arg2->get_result() ) );
+        // get_type->set_isLvalue( false );
 }
 
@@ -33 +37 @@
         delete arg1;
         delete arg2;
-}
-
-bool CommaExpr::get_lvalue() const {
-        // This is wrong by C, but the current implementation uses it.
-        // (ex: Specialize, Lvalue and Box)
-        return arg2->get_lvalue();
 }