Changeset bf4b4cf for src/Parser

Timestamp:

Oct 2, 2017, 4:53:32 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

d29fa5f

Parents:

50377a4

git-author:

Rob Schluntz <rschlunt@…> (10/02/17 16:53:28)

git-committer:

Rob Schluntz <rschlunt@…> (10/02/17 16:53:32)

Message:

Remove argName from Expression.

If named arguments are ever considered again, they should be added in UntypedExpr? (and maybe also ApplicationExpr?) to avoid unnecessary fields in every Expression. Like designators on initializers, it should be much easier to work with argument names at the call expression level.

File:

• src/Parser/ExpressionNode.cc (modified) (3 diffs)

src/Parser/ExpressionNode.cc

@@ -87 +87 @@
                 } else {
                         assertf( false, "internal error, bad integral length %s", str.c_str() );
-                } // if         
+                } // if
                 posn += 1;
         } // if
@@ -396 +396 @@
 
 NameExpr * build_varref( const string * name ) {
-        NameExpr * expr = new NameExpr( *name, nullptr );
+        NameExpr * expr = new NameExpr( *name );
         delete name;
         return expr;
@@ -487 +487 @@
         list< Expression * > args;
         buildMoveList( expr_node, args );
-        return new UntypedExpr( maybeMoveBuild< Expression >(function), args, nullptr );
+        return new UntypedExpr( maybeMoveBuild< Expression >(function), args );
 } // build_func