Changeset be567e9 for src/AST

Timestamp:

May 15, 2019, 10:15:52 AM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

54db6ba, 69bafd2

Parents:

6d51bd7 (diff), 62315a0 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

Location:

src/AST

Files:

• Node.hpp (modified) (1 diff)
• porting.md (modified) (3 diffs)

src/AST/Node.hpp

@@ -139 +139 @@
         operator const node_t * const() const { return node; }
 
+        template<typename o_node_t>
+        const o_node_t * as() const { return dynamic_cast<o_node_t *>(node); }
+
         using ptr = const node_t *;
 

src/AST/porting.md

@@ -3 +3 @@
 ## Pointer Types ##
 * raw pointer `T*` is used for construction, but not storage
-* strong pointer `ast::ptr<T>` is used for an ownership relationship
-* weak pointer `ast::readonly<T>` is used for an observation relationship
+* `ast::ptr_base<T,R>` is a pointer to AST node `T` with reference type `R`
+  * specialization: strong pointer `ast::ptr<T>` is used for an ownership relationship
+  * specialization: weak pointer `ast::readonly<T>` is used for an observation relationship
+  * added `ast::ptr_base<T,R>::as<S>()` with same semantics as `dynamic_cast<S*>(p)`
 
 ## Visitors ##
@@ -60 +62 @@
 * Strong justification required for private fields
   * No `get_` prefix on getters (including for generated fields)
+    * exception is `DeclWithType::get_type()`
 * Notable changes:
   * for concision and consistency with subclasses:
@@ -112 +115 @@
 * Still a `std::list` for children, rather than `std::vector`
   * allows more-efficient splicing for purposes of later code generation
+
+`Type`
+* `forall` field split off into `ParameterizedType` subclass
+  * any type that needs it can inherit from `ParameterizedType`
+* `get_qualifiers()` replaced with accessor `qualifiers()` and mutator `set_qualifiers()`
+  * `get_CV()` replaced with `is_CV()` variants
+* A number of features only supported on aggregates pushed down to `ReferenceToType`:
+  * `attributes`: per docs [1] GCC only supports type attributes on aggregates and typedefs
+    * suggest adding a `TypeWithAttributes` wrapper type if this proves insufficient
+  * `getAggr()`
+  * `genericSubstitution()`
+
+`BasicType`
+* does not inherit from `Type` to allow pointer inlining
+* moved `Kind` before qualifiers in constructor to allow for default
+* **TODO** move `kind`, `typeNames` into code generator
+
+[1] https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Type-Attributes.html#Type-Attributes
+