Changeset be36ec3

Timestamp:

Aug 11, 2020, 2:09:08 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

7ed1d8f

Parents:

9f1c286

Message:

No longer hold the submit lock when doing the io_uring_enter system call

File:

• libcfa/src/concurrency/io.cfa (modified) (2 diffs)

libcfa/src/concurrency/io.cfa

@@ -359 +359 @@
 
                         // We got the lock
+                        // Collect the submissions
                         unsigned to_submit = __collect_submitions( ring );
+
+                        // Release the lock now so syscalls can overlap
+                        unlock(ring.submit_q.lock);
+
+                        // Actually submit
                         int ret = __io_uring_enter( ring, to_submit, false );
-                        if( ret < 0 ) {
-                                unlock(ring.submit_q.lock);
-                                return;
-                        }
-
-                        /* paranoid */ verify( ret > 0 || to_submit == 0 || (ring.ring_flags & IORING_SETUP_SQPOLL) );
+                        if( ret < 0 ) return;
 
                         // Release the consumed SQEs
@@ -372 +373 @@
 
                         // update statistics
-                        __STATS__( true,
+                        __STATS__( false,
                                 io.submit_q.submit_avg.rdy += to_submit;
                                 io.submit_q.submit_avg.csm += ret;
                                 io.submit_q.submit_avg.cnt += 1;
                         )
-
-                        unlock(ring.submit_q.lock);
                 }
                 else {