Changeset bbfe226

Timestamp:

Jan 26, 2022, 6:15:16 PM (2 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, enum, forall-pointer-decay, master, pthread-emulation, qualifiedEnum

Children:

00a8e19

Parents:

70b4aeb9 (diff), a488783 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

Files:

• libcfa/src/concurrency/mutex_stmt.hfa (modified) (1 diff)
• src/AST/Copy.hpp (modified) (2 diffs)
• src/AST/Node.hpp (modified) (1 diff)
• src/ControlStruct/HoistControlDecls.cpp (added)
• src/ControlStruct/HoistControlDecls.hpp (added)
• src/ControlStruct/module.mk (modified) (1 diff)
• src/SymTab/Validate.cc (modified) (2 diffs)
• src/SymTab/Validate.h (modified) (1 diff)
• src/Validate/Autogen.cpp (added)
• src/Validate/Autogen.hpp (added)
• src/Validate/module.mk (modified) (1 diff)
• src/main.cc (modified) (7 diffs)
• tests/concurrent/mutexstmt/.expect/locks.txt (modified) (1 diff)
• tests/concurrent/mutexstmt/locks.cfa (modified) (3 diffs)

libcfa/src/concurrency/mutex_stmt.hfa

@@ -38 +38 @@
     }
 
+    struct scoped_lock {
+        L * internal_lock;
+    };
+
+    static inline void ?{}( scoped_lock(L) & this, L & internal_lock ) {
+        this.internal_lock = &internal_lock;
+        lock(internal_lock);
+    }
+    
+    static inline void ^?{}( scoped_lock(L) & this ) with(this) {
+        unlock(*internal_lock);
+    }
+
     static inline L * __get_ptr( L & this ) {
         return &this;

src/AST/Copy.hpp

@@ -10 +10 @@
 // Created On       : Wed Jul 10 16:13:00 2019
 // Last Modified By : Andrew Beach
-// Last Modified On : Thr Nov 11  9:22:00 2021
-// Update Count     : 2
+// Last Modified On : Wed Dec 15 11:07:00 2021
+// Update Count     : 3
 //
 
@@ -52 +52 @@
 Node * deepCopy<Node>( const Node * localRoot );
 
+template<typename node_t, enum Node::ref_type ref_t>
+node_t * shallowCopy( const ptr_base<node_t, ref_t> & localRoot ) {
+        return shallowCopy( localRoot.get() );
+}
+
+template<typename node_t, enum Node::ref_type ref_t>
+node_t * deepCopy( const ptr_base<node_t, ref_t> & localRoot ) {
+        return deepCopy( localRoot.get() );
+}
+
 }
 

src/AST/Node.hpp

@@ -188 +188 @@
         }
 
+        ptr_base & operator=( const node_t * node ) {
+                assign( node );
+                return *this;
+        }
+
         template<typename o_node_t>
         ptr_base & operator=( const o_node_t * node ) {

src/ControlStruct/module.mk

@@ -22 +22 @@
         ControlStruct/ForExprMutator.cc \
         ControlStruct/ForExprMutator.h \
+        ControlStruct/HoistControlDecls.cpp \
+        ControlStruct/HoistControlDecls.hpp \
         ControlStruct/LabelFixer.cc \
         ControlStruct/LabelFixer.h \

src/SymTab/Validate.cc

@@ -453 +453 @@
         }
 
+        void decayForallPointers( std::list< Declaration * > & translationUnit ) {
+                PassVisitor<ForallPointerDecay_old> fpd;
+                acceptAll( translationUnit, fpd );
+        }
+
         void validate( std::list< Declaration * > &translationUnit, __attribute__((unused)) bool doDebug ) {
                 validate_A( translationUnit );
@@ -470 +475 @@
                 type->accept( fpd );
         }
-
 
         void HoistTypeDecls::handleType( Type * type ) {

src/SymTab/Validate.h

@@ -42 +42 @@
         void validate_E( std::list< Declaration * > &translationUnit );
         void validate_F( std::list< Declaration * > &translationUnit );
+        void decayForallPointers( std::list< Declaration * > & translationUnit );
 
         const ast::Type * validateType(

src/Validate/module.mk

@@ -16 +16 @@
 
 SRC_VALIDATE = \
+        Validate/Autogen.cpp \
+        Validate/Autogen.hpp \
         Validate/CompoundLiteral.cpp \
         Validate/CompoundLiteral.hpp \

src/main.cc

@@ -10 +10 @@
 // Created On       : Fri May 15 23:12:02 2015
 // Last Modified By : Andrew Beach
-// Last Modified On : Tue Nov 30 10:25:00 2021
-// Update Count     : 659
+// Last Modified On : Wed Jan 26 14:09:00 2022
+// Update Count     : 670
 //
 
@@ -55 +55 @@
 #include "ControlStruct/ExceptTranslate.h"  // for translateEHM
 #include "ControlStruct/FixLabels.hpp"      // for fixLabels
+#include "ControlStruct/HoistControlDecls.hpp" //  hoistControlDecls
 #include "ControlStruct/Mutate.h"           // for mutate
 #include "GenPoly/Box.h"                    // for box
@@ -73 +74 @@
 #include "SynTree/Visitor.h"                // for acceptAll
 #include "Tuples/Tuples.h"                  // for expandMemberTuples, expan...
+#include "Validate/Autogen.hpp"             // for autogenerateRoutines
 #include "Validate/FindSpecialDecls.h"      // for findGlobalDecls
 #include "Validate/CompoundLiteral.hpp"     // for handleCompoundLiterals
@@ -78 +80 @@
 #include "Validate/LabelAddressFixer.hpp"   // for fixLabelAddresses
 #include "Virtual/ExpandCasts.h"            // for expandCasts
-
 
 static void NewPass( const char * const name ) {
@@ -326 +327 @@
                 PASS( "Validate-B", SymTab::validate_B( translationUnit ) );
                 PASS( "Validate-C", SymTab::validate_C( translationUnit ) );
-                PASS( "Validate-D", SymTab::validate_D( translationUnit ) );
 
                 CodeTools::fillLocations( translationUnit );
 
                 if( useNewAST ) {
+                        PASS( "Apply Concurrent Keywords", Concurrency::applyKeywords( translationUnit ) );
+                        PASS( "Forall Pointer Decay", SymTab::decayForallPointers( translationUnit ) );
+                        CodeTools::fillLocations( translationUnit );
+
                         if (Stats::Counters::enabled) {
                                 ast::pass_visitor_stats.avg = Stats::Counters::build<Stats::Counters::AverageCounter<double>>("Average Depth - New");
@@ -338 +342 @@
 
                         forceFillCodeLocations( transUnit );
+
+                        // Must happen before autogen routines are added.
+                        PASS( "Hoist Control Declarations", ControlStruct::hoistControlDecls( transUnit ) );
+
+                        // Must be after enum and pointer decay.
+                        // Must be before compound literals.
+                        PASS( "Generate Autogen Routines", Validate::autogenerateRoutines( transUnit ) );
 
                         PASS( "Implement Mutex", Concurrency::implementMutex( transUnit ) );
@@ -406 +417 @@
                         translationUnit = convert( move( transUnit ) );
                 } else {
+                        PASS( "Validate-D", SymTab::validate_D( translationUnit ) );
                         PASS( "Validate-E", SymTab::validate_E( translationUnit ) );
                         PASS( "Validate-F", SymTab::validate_F( translationUnit ) );

tests/concurrent/mutexstmt/.expect/locks.txt

@@ -3 +3 @@
 Start Test: multi lock deadlock/mutual exclusion
 End Test: multi lock deadlock/mutual exclusion
+Start Test: single scoped lock mutual exclusion
+End Test: single scoped lock mutual exclusion
+Start Test: multi scoped lock deadlock/mutual exclusion
+End Test: multi scoped lock deadlock/mutual exclusion

tests/concurrent/mutexstmt/locks.cfa

@@ -59 +59 @@
 }
 
+thread T_Mutex_Scoped {};
 
+void main( T_Mutex_Scoped & this ) {
+        for (unsigned int i = 0; i < num_times; i++) {
+                {
+                        scoped_lock(single_acquisition_lock) s{m1};
+                        count++;
+                }
+                {
+                        scoped_lock(single_acquisition_lock) s{m1};
+                        assert(!insideFlag);
+                        insideFlag = true;
+                        assert(insideFlag);
+                        insideFlag = false;
+                }
+        }
+}
+
+thread T_Multi_Scoped {};
+
+void main( T_Multi_Scoped & this ) {
+        for (unsigned int i = 0; i < num_times; i++) {
+                {
+                        scoped_lock(single_acquisition_lock) s{m1};
+                        assert(!insideFlag);
+                        insideFlag = true;
+                        assert(insideFlag);
+                        insideFlag = false;
+                }
+                {
+                        scoped_lock(single_acquisition_lock) s1{m1};
+                        scoped_lock(single_acquisition_lock) s2{m2};
+                        scoped_lock(single_acquisition_lock) s3{m3};
+                        scoped_lock(single_acquisition_lock) s4{m4};
+                        scoped_lock(single_acquisition_lock) s5{m5};
+                        assert(!insideFlag);
+                        insideFlag = true;
+                        assert(insideFlag);
+                        insideFlag = false;
+                }
+                {
+                        scoped_lock(single_acquisition_lock) s1{m1};
+                        scoped_lock(single_acquisition_lock) s3{m3};
+                        assert(!insideFlag);
+                        insideFlag = true;
+                        assert(insideFlag);
+                        insideFlag = false;
+                }
+                {
+                        scoped_lock(single_acquisition_lock) s1{m1};
+                        scoped_lock(single_acquisition_lock) s2{m2};
+                        scoped_lock(single_acquisition_lock) s4{m4};
+                        assert(!insideFlag);
+                        insideFlag = true;
+                        assert(insideFlag);
+                        insideFlag = false;
+                }
+                {
+                        scoped_lock(single_acquisition_lock) s1{m1};
+                        scoped_lock(single_acquisition_lock) s3{m3};
+                        scoped_lock(single_acquisition_lock) s4{m4};
+                        scoped_lock(single_acquisition_lock) s5{m5};
+                        assert(!insideFlag);
+                        insideFlag = true;
+                        assert(insideFlag);
+                        insideFlag = false;
+                }
+        }
+}
+
+int num_tasks = 10;
 int main() {
         processor p[10];
@@ -67 +137 @@
                 T_Mutex t[10];
         }
+        assert(count == num_tasks * num_times);
         printf("End Test: single lock mutual exclusion\n");
         printf("Start Test: multi lock deadlock/mutual exclusion\n");
@@ -73 +144 @@
         }
         printf("End Test: multi lock deadlock/mutual exclusion\n");
+        
+        count = 0;
+        printf("Start Test: single scoped lock mutual exclusion\n");
+        {
+                T_Mutex_Scoped t[10];
+        }
+        assert(count == num_tasks * num_times);
+        printf("End Test: single scoped lock mutual exclusion\n");
+        printf("Start Test: multi scoped lock deadlock/mutual exclusion\n");
+        {
+                T_Multi_Scoped t[10];
+        }
+        printf("End Test: multi scoped lock deadlock/mutual exclusion\n");      
 }