Changes in src/ResolvExpr/SatisfyAssertions.cpp [07d867b:b69233ac]

File:

• src/ResolvExpr/SatisfyAssertions.cpp (modified) (9 diffs)

src/ResolvExpr/SatisfyAssertions.cpp

@@ -9 +9 @@
 // Author           : Aaron B. Moss
 // Created On       : Mon Jun 10 17:45:00 2019
-// Last Modified By : Andrew Beach
-// Last Modified On : Tue Oct  1 13:56:00 2019
-// Update Count     : 2
+// Last Modified By : Aaron B. Moss
+// Last Modified On : Mon Jun 10 17:45:00 2019
+// Update Count     : 1
 //
 
@@ -188 +188 @@
 
                                 matches.emplace_back( 
-                                        cdata, adjType, std::move( newEnv ), std::move( have ), std::move( newNeed ),
+                                        cdata, adjType, std::move( newEnv ), std::move( newNeed ), std::move( have ), 
                                         std::move( newOpen ), crntResnSlot );
                         }
@@ -229 +229 @@
                 InferMatcher( InferCache & inferred ) : inferred( inferred ) {}
 
-                const ast::Expr * postvisit( const ast::Expr * expr ) {
+                const ast::Expr * postmutate( const ast::Expr * expr ) {
                         // Skip if no slots to find
-                        if ( !expr->inferred.hasSlots() ) return expr;
-                        // if ( expr->inferred.mode != ast::Expr::InferUnion::Slots ) return expr;
-                        std::vector<UniqueId> missingSlots;
+                        if ( expr->inferred.mode != ast::Expr::InferUnion::Slots ) return expr;
+
                         // find inferred parameters for resolution slots
-                        ast::InferredParams * newInferred = new ast::InferredParams();
+                        ast::InferredParams newInferred;
                         for ( UniqueId slot : expr->inferred.resnSlots() ) {
                                 // fail if no matching assertions found
                                 auto it = inferred.find( slot );
                                 if ( it == inferred.end() ) {
-                                        std::cerr << "missing assertion " << slot << std::endl;
-                                        missingSlots.push_back(slot);
-                                        continue;
+                                        assert(!"missing assertion");
                                 }
 
@@ -248 +245 @@
                                 for ( auto & entry : it->second ) {
                                         // recurse on inferParams of resolved expressions
-                                        entry.second.expr = postvisit( entry.second.expr );
-                                        auto res = newInferred->emplace( entry );
+                                        entry.second.expr = postmutate( entry.second.expr );
+                                        auto res = newInferred.emplace( entry );
                                         assert( res.second && "all assertions newly placed" );
                                 }
@@ -255 +252 @@
 
                         ast::Expr * ret = mutate( expr );
-                        ret->inferred.set_inferParams( newInferred );
-                        if (!missingSlots.empty()) ret->inferred.resnSlots() = missingSlots;
+                        ret->inferred.set_inferParams( std::move( newInferred ) );
                         return ret;
                 }
@@ -303 +299 @@
                         Cost cost;
 
-                        OutType(
-                                const ast::TypeEnvironment & e, const ast::OpenVarSet & o,
+                        OutType( 
+                                const ast::TypeEnvironment & e, const ast::OpenVarSet & o, 
                                 const std::vector< DeferRef > & as, const ast::SymbolTable & symtab )
                         : env( e ), open( o ), assns( as ), cost( Cost::zero ) {
@@ -310 +306 @@
                                 for ( const DeferRef & assn : assns ) {
                                         // compute conversion cost from satisfying decl to assertion
-                                        cost += computeConversionCost(
-                                                assn.match.adjType, assn.decl->get_type(), false, symtab, env );
-
+                                        cost += computeConversionCost( 
+                                                assn.match.adjType, assn.decl->get_type(), symtab, env );
+                                        
                                         // mark vars+specialization on function-type assertions
-                                        const ast::FunctionType * func =
+                                        const ast::FunctionType * func = 
                                                 GenPoly::getFunctionType( assn.match.cdata.id->get_type() );
                                         if ( ! func ) continue;
@@ -321 +317 @@
                                                 cost.decSpec( specCost( param->get_type() ) );
                                         }
-
+                                        
                                         cost.incVar( func->forall.size() );
-
+                                        
                                         for ( const ast::TypeDecl * td : func->forall ) {
                                                 cost.decSpec( td->assertions.size() );
@@ -333 +329 @@
                 };
 
-                CandidateEnvMerger(
-                        const ast::TypeEnvironment & env, const ast::OpenVarSet & open,
+                CandidateEnvMerger( 
+                        const ast::TypeEnvironment & env, const ast::OpenVarSet & open, 
                         const ast::SymbolTable & syms )
                 : crnt(), envs{ env }, opens{ open }, symtab( syms ) {}