Changeset aff3af4

Timestamp:

Jun 1, 2017, 7:26:04 PM (8 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

b1d4d60

Parents:

676cc8c

Message:

convert FixInit? to PassVisitor?

Location:

src

Files:

• Common/PassVisitor.h (modified) (1 diff)
• InitTweak/FixInit.cc (modified) (4 diffs)

src/Common/PassVisitor.h

@@ -26 +26 @@
 
         template< typename... Args >
-        PassVisitor(Args &&... args) 
+        PassVisitor(Args &&... args)
                 : pass( std::forward<Args>( args )... )
         {}
 
         virtual ~PassVisitor() = default;
-private:
+
         pass_type pass;
-
-public:
 
         virtual void visit( ObjectDecl *objectDecl ) override final;

src/InitTweak/FixInit.cc

@@ -192 +192 @@
                 };
 
-                class FixInit final : public GenPoly::PolyMutator {
+                class FixInit {
                   public:
                         /// expand each object declaration to use its constructor after it is declared.
                         static void fixInitializers( std::list< Declaration * > &translationUnit );
 
-                        typedef GenPoly::PolyMutator Parent;
-                        using Parent::mutate;
-                        virtual DeclarationWithType * mutate( ObjectDecl *objDecl ) override;
+                        DeclarationWithType * postmutate( ObjectDecl *objDecl );
 
                         std::list< Declaration * > staticDtorDecls;
+                        std::list< Statement * > stmtsToAddAfter; // found by PassVisitor
                 };
 
@@ -312 +311 @@
 
                 void FixInit::fixInitializers( std::list< Declaration * > & translationUnit ) {
-                        FixInit fixer;
+                        PassVisitor<FixInit> fixer;
 
                         // can't use mutateAll, because need to insert declarations at top-level
@@ -320 +319 @@
                                 try {
                                         *i = maybeMutate( *i, fixer );
-                                        translationUnit.splice( i, fixer.staticDtorDecls );
+                                        translationUnit.splice( i, fixer.pass.staticDtorDecls );
                                 } catch( SemanticError &e ) {
                                         e.set_location( (*i)->location );
@@ -696 +695 @@
                 }
 
-                DeclarationWithType *FixInit::mutate( ObjectDecl *objDecl ) {
-                        // first recursively handle pieces of ObjectDecl so that they aren't missed by other visitors when the init
-                        // is removed from the ObjectDecl
-                        objDecl = dynamic_cast< ObjectDecl * >( Parent::mutate( objDecl ) );
+                DeclarationWithType *FixInit::postmutate( ObjectDecl *objDecl ) {
+                        // since this removes the init field from objDecl, it must occur after children are mutated (i.e. postmutate)
                         if ( ConstructorInit * ctorInit = dynamic_cast< ConstructorInit * >( objDecl->get_init() ) ) {
                                 // a decision should have been made by the resolver, so ctor and init are not both non-NULL