Changes in src/SymTab/Validate.cc [06edda0:af397ef8]

File:

• src/SymTab/Validate.cc (modified) (19 diffs)

src/SymTab/Validate.cc

@@ -66 +66 @@
 #include "ResolvExpr/typeops.h"
 
-#include "SynTree/Attribute.h"
 #include "SynTree/Expression.h"
 #include "SynTree/Mutator.h"
@@ -115 +114 @@
 
         /// Replaces enum types by int, and function or array types in function parameter and return lists by appropriate pointers.
-        class EnumAndPointerDecay {
-        public:
-                void previsit( EnumDecl *aggregateDecl );
-                void previsit( FunctionType *func );
+        class EnumAndPointerDecayPass final : public Visitor {
+                typedef Visitor Parent;
+                virtual void visit( EnumDecl *aggregateDecl );
+                virtual void visit( FunctionType *func );
         };
 
@@ -126 +125 @@
           public:
                 LinkReferenceToTypes( bool doDebug, const Indexer *indexer );
+          private:
                 using Parent::visit;
                 void visit( EnumInstType *enumInst ) final;
@@ -135 +135 @@
                 void visit( UnionDecl *unionDecl ) final;
                 void visit( TypeInstType *typeInst ) final;
-          private:
+
                 const Indexer *indexer;
 
@@ -146 +146 @@
         };
 
-        /// Replaces array and function types in forall lists by appropriate pointer type and assigns each Object and Function declaration a unique ID.
-        class ForallPointerDecay final : public Indexer {
+        /// Replaces array and function types in forall lists by appropriate pointer type
+        class Pass3 final : public Indexer {
                 typedef Indexer Parent;
           public:
                 using Parent::visit;
-                ForallPointerDecay( const Indexer *indexer );
-
+                Pass3( const Indexer *indexer );
+          private:
                 virtual void visit( ObjectDecl *object ) override;
                 virtual void visit( FunctionDecl *func ) override;
@@ -159 +159 @@
         };
 
-        class ReturnChecker : public WithScopes {
+        class ReturnChecker {
           public:
                 /// Checks that return statements return nothing if their return type is void
@@ -166 +166 @@
           private:
                 void previsit( FunctionDecl * functionDecl );
+                void postvisit( FunctionDecl * functionDecl );
                 void previsit( ReturnStmt * returnStmt );
 
                 typedef std::list< DeclarationWithType * > ReturnVals;
                 ReturnVals returnVals;
+                std::stack< ReturnVals > returnValsStack;
         };
 
@@ -245 +247 @@
 
         void validate( std::list< Declaration * > &translationUnit, bool doDebug ) {
-                PassVisitor<EnumAndPointerDecay> epc;
+                EnumAndPointerDecayPass epc;
                 LinkReferenceToTypes lrt( doDebug, 0 );
-                ForallPointerDecay fpd( 0 );
+                Pass3 pass3( 0 );
                 CompoundLiteral compoundliteral;
                 PassVisitor<ValidateGenericParameters> genericParams;
@@ -259 +261 @@
                 VerifyCtorDtorAssign::verify( translationUnit );  // must happen before autogen, because autogen examines existing ctor/dtors
                 Concurrency::applyKeywords( translationUnit );
-                autogenerateRoutines( translationUnit ); // moved up, used to be below compoundLiteral - currently needs EnumAndPointerDecay
+                autogenerateRoutines( translationUnit ); // moved up, used to be below compoundLiteral - currently needs EnumAndPointerDecayPass
                 Concurrency::implementMutexFuncs( translationUnit );
                 Concurrency::implementThreadStarter( translationUnit );
                 ReturnChecker::checkFunctionReturns( translationUnit );
                 compoundliteral.mutateDeclarationList( translationUnit );
-                acceptAll( translationUnit, fpd );
+                acceptAll( translationUnit, pass3 );
                 ArrayLength::computeLength( translationUnit );
         }
 
         void validateType( Type *type, const Indexer *indexer ) {
-                PassVisitor<EnumAndPointerDecay> epc;
+                EnumAndPointerDecayPass epc;
                 LinkReferenceToTypes lrt( false, indexer );
-                ForallPointerDecay fpd( indexer );
+                Pass3 pass3( indexer );
                 type->accept( epc );
                 type->accept( lrt );
-                type->accept( fpd );
+                type->accept( pass3 );
         }
 
@@ -353 +355 @@
         }
 
-        void EnumAndPointerDecay::previsit( EnumDecl *enumDecl ) {
+        void EnumAndPointerDecayPass::visit( EnumDecl *enumDecl ) {
                 // Set the type of each member of the enumeration to be EnumConstant
                 for ( std::list< Declaration * >::iterator i = enumDecl->get_members().begin(); i != enumDecl->get_members().end(); ++i ) {
@@ -360 +362 @@
                         obj->set_type( new EnumInstType( Type::Qualifiers( Type::Const ), enumDecl->get_name() ) );
                 } // for
+                Parent::visit( enumDecl );
         }
 
@@ -366 +369 @@
                 void fixFunctionList( DWTList & dwts, FunctionType * func ) {
                         // the only case in which "void" is valid is where it is the only one in the list; then it should be removed
-                        // entirely. other fix ups are handled by the FixFunction class
+                        // entirely other fix ups are handled by the FixFunction class
                         typedef typename DWTList::iterator DWTIterator;
                         DWTIterator begin( dwts.begin() ), end( dwts.end() );
@@ -385 +388 @@
                                 for ( ; i != end; ++i ) {
                                         FixFunction fixer;
-                                        *i = (*i)->acceptMutator( fixer );
+                                        *i = (*i )->acceptMutator( fixer );
                                         if ( fixer.get_isVoid() ) {
                                                 throw SemanticError( "invalid type void in function type ", func );
@@ -394 +397 @@
         }
 
-        void EnumAndPointerDecay::previsit( FunctionType *func ) {
+        void EnumAndPointerDecayPass::visit( FunctionType *func ) {
                 // Fix up parameters and return types
                 fixFunctionList( func->get_parameters(), func );
                 fixFunctionList( func->get_returnVals(), func );
+                Visitor::visit( func );
         }
 
@@ -544 +548 @@
         }
 
-        ForallPointerDecay::ForallPointerDecay( const Indexer *other_indexer ) :  Indexer( false ) {
+        Pass3::Pass3( const Indexer *other_indexer ) :  Indexer( false ) {
                 if ( other_indexer ) {
                         indexer = other_indexer;
@@ -582 +586 @@
         }
 
-        void ForallPointerDecay::visit( ObjectDecl *object ) {
+        void Pass3::visit( ObjectDecl *object ) {
                 forallFixer( object->get_type() );
                 if ( PointerType *pointer = dynamic_cast< PointerType * >( object->get_type() ) ) {
@@ -591 +595 @@
         }
 
-        void ForallPointerDecay::visit( FunctionDecl *func ) {
+        void Pass3::visit( FunctionDecl *func ) {
                 forallFixer( func->get_type() );
                 Parent::visit( func );
@@ -603 +607 @@
 
         void ReturnChecker::previsit( FunctionDecl * functionDecl ) {
-                GuardValue( returnVals );
+                returnValsStack.push( returnVals );
                 returnVals = functionDecl->get_functionType()->get_returnVals();
+        }
+        void ReturnChecker::postvisit( __attribute__((unused)) FunctionDecl * functionDecl ) {
+                returnVals = returnValsStack.top();
+                returnValsStack.pop();
         }
 
@@ -919 +927 @@
                                 ret->set_name( toString( "_retval_", CodeGen::genName( functionDecl ) ) );
                         }
-                        ret->get_attributes().push_back( new Attribute( "unused" ) );
                 }
         }