Changeset ae4038d for src/GenPoly

Timestamp:

Aug 15, 2017, 12:08:53 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

322b97e, bd098ea, f710aca

Parents:

6a36975

Message:

Fix tuple specialize check to more precisely determine where tuple specialization is necessary [fixes #35]

File:

• src/GenPoly/Specialize.cc (modified) (2 diffs)

src/GenPoly/Specialize.cc

@@ -93 +93 @@
         }
 
+        // walk into tuple type and find the number of components
+        size_t singleParameterSize( Type * type ) {
+                if ( TupleType * tt = dynamic_cast< TupleType * >( type ) ) {
+                        size_t sz = 0;
+                        for ( Type * t : *tt ) {
+                                sz += singleParameterSize( t );
+                        }
+                        return sz;
+                } else {
+                        return 1;
+                }
+        }
+
+        // find the total number of components in a parameter list
+        size_t functionParameterSize( FunctionType * ftype ) {
+                size_t sz = 0;
+                for ( DeclarationWithType * p : ftype->get_parameters() ) {
+                        sz += singleParameterSize( p->get_type() );
+                }
+                return sz;
+        }
+
         bool needsTupleSpecialization( Type *formalType, Type *actualType ) {
                 // Needs tuple specialization if the structure of the formal type and actual type do not match.
@@ -103 +125 @@
                         FunctionType * aftype = getFunctionType( actualType );
                         assertf( aftype, "formal type is a function type, but actual type is not." );
+                        // Can't tuple specialize if parameter sizes deeply-differ.
+                        if ( functionParameterSize( fftype ) != functionParameterSize( aftype ) ) return false;
+                        // tuple-parameter sizes are the same, but actual parameter sizes differ - must tuple specialize
                         if ( fftype->get_parameters().size() != aftype->get_parameters().size() ) return true;
+                        // total parameter size can be the same, while individual parameters can have different structure
                         for ( auto params : group_iterate( fftype->get_parameters(), aftype->get_parameters() ) ) {
                                 DeclarationWithType * formal = std::get<0>(params);