Changeset ac3362c for src

Timestamp:

Aug 3, 2018, 11:56:53 AM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, no_list, persistent-indexer, pthread-emulation, qualifiedEnum

Children:

f271bdd

Parents:

3537dd7

Message:

Resolve enumerator initializers early to allow other passes to determine if expression is constexpr and to evaluate constexprs

Location:

src

Files:

• SymTab/Validate.cc (modified) (1 diff)
• SynTree/AggregateDecl.cc (modified) (2 diffs)

src/SymTab/Validate.cc

@@ -738 +738 @@
                                 forwardEnums.erase( fwds );
                         } // if
+
+                        for ( Declaration * member : enumDecl->members ) {
+                                ObjectDecl * field = strict_dynamic_cast<ObjectDecl *>( member );
+                                if ( field->init ) {
+                                        // need to resolve enumerator initializers early so that other passes that determine if an expression is constexpr have the appropriate information.
+                                        SingleInit * init = strict_dynamic_cast<SingleInit *>( field->init );
+                                        ResolvExpr::findSingleExpression( init->value, new BasicType( Type::Qualifiers(), BasicType::SignedInt ), indexer );
+                                }
+                        }
                 } // if
         }

src/SynTree/AggregateDecl.cc

@@ -86 +86 @@
 std::string TraitDecl::typeString() const { return "trait"; }
 
-namespace {
-        long long int getConstValue( Expression * expr ) {
-                if ( CastExpr * castExpr = dynamic_cast< CastExpr * > ( expr ) ) {
-                        return getConstValue( castExpr->arg );
-                } else if ( ConstantExpr * constExpr = dynamic_cast< ConstantExpr * >( expr ) ) {
-                        return constExpr->intValue();
-                // can be -1, +1, etc.
-                // } else if ( UntypedExpr * untypedExpr = dynamic_cast< UntypedExpr * >( expr ) ) {
-                //      if ( untypedExpr-> )
-                } else {
-                        assertf( false, "Unhandled expression type in getConstValue for enumerators: %s", toString( expr ).c_str() );
-                }
-        }
-}
-
 bool EnumDecl::valueOf( Declaration * enumerator, long long int & value ) {
         if ( enumValues.empty() ) {
@@ -108 +93 @@
                         if ( field->init ) {
                                 SingleInit * init = strict_dynamic_cast< SingleInit * >( field->init );
-                                currentValue = getConstValue( init->value );
+                                auto result = eval( init->value );
+                                if ( ! result.second ) SemanticError( init->location, toString( "Non-constexpr in initialization of enumerator: ", field ) );
+                                currentValue = result.first;
                         }
                         assertf( enumValues.count( field->name ) == 0, "Enum %s has multiple members with the name %s", name.c_str(), field->name.c_str() );