Changeset a6c5d7c

Timestamp:

Sep 27, 2017, 11:11:25 PM (7 years ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

6e49f18

Parents:

5dc26f5

Message:

remove literal casts for signed integrals

Location:

src

Files:

• Parser/ExpressionNode.cc (modified) (2 diffs)
• tests/.expect/64/literals.txt (modified) (1 diff)

src/Parser/ExpressionNode.cc

@@ -10 +10 @@
 // Created On       : Sat May 16 13:17:07 2015
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Tue Sep 26 11:23:36 2017
-// Update Count     : 780
+// Last Modified On : Wed Sep 27 22:51:55 2017
+// Update Count     : 781
 //
 
@@ -207 +207 @@
 
         assert( 0 <= size && size < 6 );
+        // Constant type is correct for overload resolving.
         ret = new ConstantExpr( Constant( new BasicType( noQualifiers, kind[Unsigned][size] ), str, v ) );
-        if ( size < 2 ) {                                                                       // hh or h, less than int ?
+        if ( Unsigned && size < 2 ) {                                           // hh or h, less than int ?
                 // int i = -1uh => 65535 not -1, so cast is necessary for unsigned, which unfortunately eliminates warnings for large values.
                 ret = new CastExpr( ret, new BasicType( Type::Qualifiers(), kind[Unsigned][size] ) );

src/tests/.expect/64/literals.txt

@@ -1252 +1252 @@
     ((void)(-((long double )0x.0123456789p09)));
     ((void)__f__F_c__1('a'));
-    ((void)__f__F_Sc__1(((signed char )20)));
+    ((void)__f__F_Sc__1(20));
     ((void)__f__F_Uc__1(((unsigned char )21u)));
-    ((void)__f__F_s__1(((signed short int )22)));
+    ((void)__f__F_s__1(22));
     ((void)__f__F_Us__1(((unsigned short int )23u)));
     ((void)__f__F_Ul__1(((unsigned long int )24)));