Changes in benchmark/io/http/options.cfa [2cd784a:a6b587f]

File:

• benchmark/io/http/options.cfa (modified) (7 diffs)

benchmark/io/http/options.cfa

@@ -13 +13 @@
 #include <kernel.hfa>
 #include <parseargs.hfa>
-#include <stdlib.hfa>
 
 #include <stdlib.h>
@@ -20 +19 @@
 Options options @= {
         false, // log
-        false, // stats
 
         { // file_cache
@@ -38 +36 @@
 
         { // cluster
-                1,     // nclusters;
                 1,     // nprocs;
                 1,     // nworkers;
@@ -49 +46 @@
 
 void parse_options( int argc, char * argv[] ) {
-        // bool fixedfd = false;
-        // bool sqkpoll = false;
-        // bool iokpoll = false;
+        bool subthrd = false;
+        bool eagrsub = false;
+        bool fixedfd = false;
+        bool sqkpoll = false;
+        bool iokpoll = false;
+        unsigned sublen = 16;
         unsigned nentries = 16;
-        bool isolate = false;
 
 
@@ -60 +59 @@
                 { 'c', "cpus",           "Number of processors to use", options.clopts.nprocs},
                 { 't', "threads",        "Number of worker threads to use", options.clopts.nworkers},
-                {'\0', "isolate",        "Create one cluster per processor", isolate, parse_settrue},
                 {'\0', "log",            "Enable logs", options.log, parse_settrue},
-                {'\0', "stats",          "Enable statistics", options.stats, parse_settrue},
                 {'\0', "accept-backlog", "Maximum number of pending accepts", options.socket.backlog},
                 {'\0', "request_len",    "Maximum number of bytes in the http request, requests with more data will be answered with Http Code 414", options.socket.buflen},
@@ -68 +65 @@
                 {'\0', "cache-size",     "Size of the cache to use, if set to small, will uses closes power of 2", options.file_cache.size },
                 {'\0', "list-files",     "List the files in the specified path and exit", options.file_cache.list, parse_settrue },
-                // { 'f', "fixed-fds",      "If set, files are open eagerly and pre-registered with the cluster", fixedfd, parse_settrue},
-                // { 'k', "kpollsubmit",    "If set, cluster uses IORING_SETUP_SQPOLL, implies -f", sqkpoll, parse_settrue },
-                // { 'i', "kpollcomplete",  "If set, cluster uses IORING_SETUP_IOPOLL", iokpoll, parse_settrue },
-                {'e', "numentries",     "Number of I/O entries", nentries },
+                { 's', "submitthread",   "If set, cluster uses polling thread to submit I/O", subthrd, parse_settrue },
+                { 'e', "eagersubmit",    "If set, cluster submits I/O eagerly but still aggregates submits", eagrsub, parse_settrue},
+                { 'f', "fixed-fds",      "If set, files are open eagerly and pre-registered with the cluster", fixedfd, parse_settrue},
+                { 'k', "kpollsubmit",    "If set, cluster uses IORING_SETUP_SQPOLL, implies -f", sqkpoll, parse_settrue },
+                { 'i', "kpollcomplete",  "If set, cluster uses IORING_SETUP_IOPOLL", iokpoll, parse_settrue },
+                {'\0', "submitlength",   "Max number of submitions that can be submitted together", sublen },
+                {'\0', "numentries",     "Number of I/O entries", nentries },
 
         };
@@ -91 +91 @@
                 nentries = v;
         }
-        if(isolate) {
-                options.clopts.nclusters = options.clopts.nprocs;
-                options.clopts.nprocs = 1;
-        }
         options.clopts.params.num_entries = nentries;
-        options.clopts.instance = alloc(options.clopts.nclusters);
-        options.clopts.thrd_cnt = alloc(options.clopts.nclusters);
-        options.clopts.cltr_cnt = 0;
-        for(i; options.clopts.nclusters) {
-                options.clopts.thrd_cnt[i] = 0;
+
+        options.clopts.params.poller_submits = subthrd;
+        options.clopts.params.eager_submits  = eagrsub;
+
+        if( fixedfd ) {
+                options.file_cache.fixed_fds = true;
         }
 
+        if( sqkpoll ) {
+                options.clopts.params.poll_submit = true;
+                options.file_cache.fixed_fds = true;
+        }
 
-        // if( fixedfd ) {
-        //      options.file_cache.fixed_fds = true;
-        // }
+        if( iokpoll ) {
+                options.clopts.params.poll_complete = true;
+                options.file_cache.open_flags |= O_DIRECT;
+        }
 
-        // if( sqkpoll ) {
-        //      options.file_cache.fixed_fds = true;
-        // }
-
-        // if( iokpoll ) {
-        //      options.file_cache.open_flags |= O_DIRECT;
-        // }
+        options.clopts.params.num_ready = sublen;
 
         if( left[0] == 0p ) { return; }