Changes in src/SymTab/Autogen.cc [f30b2610:a4477db]

File:

• src/SymTab/Autogen.cc (modified) (19 diffs)

src/SymTab/Autogen.cc

@@ -43 +43 @@
 namespace SymTab {
         Type * SizeType = 0;
-
-        /// Data used to generate functions generically. Specifically, the name of the generated function and a function which generates the routine protoype
+        typedef ScopedMap< std::string, bool > TypeMap;
+
+        /// Data used to generate functions generically. Specifically, the name of the generated function, a function which generates the routine protoype, and a map which contains data to determine whether a function should be generated.
         struct FuncData {
                 typedef FunctionType * (*TypeGen)( Type * );
-                FuncData( const std::string & fname, const TypeGen & genType ) : fname( fname ), genType( genType ) {}
+                FuncData( const std::string & fname, const TypeGen & genType, TypeMap & map ) : fname( fname ), genType( genType ), map( map ) {}
                 std::string fname;
                 TypeGen genType;
+                TypeMap & map;
         };
 
-        struct AutogenerateRoutines final : public WithDeclsToAdd, public WithVisitorRef<AutogenerateRoutines>, public WithGuards, public WithShortCircuiting, public WithIndexer {
+        struct AutogenerateRoutines final : public WithDeclsToAdd, public WithVisitorRef<AutogenerateRoutines>, public WithGuards, public WithShortCircuiting {
                 AutogenerateRoutines();
 
@@ -68 +70 @@
 
           private:
-
                 GenPoly::ScopedSet< std::string > structsDone;
                 unsigned int functionNesting = 0;     // current level of nested functions
-
-                InitTweak::ManagedTypes managedTypes;
+                /// Note: the following maps could be ScopedSets, but it should be easier to work
+                /// deleted functions in if they are maps, since the value false can be inserted
+                /// at the current scope without affecting outer scopes or requiring copies.
+                TypeMap copyable, assignable, constructable, destructable;
                 std::vector< FuncData > data;
         };
@@ -78 +81 @@
         /// generates routines for tuple types.
         struct AutogenTupleRoutines : public WithDeclsToAdd, public WithVisitorRef<AutogenTupleRoutines>, public WithGuards, public WithShortCircuiting {
-                void previsit( FunctionDecl * functionDecl );
-
-                void postvisit( TupleType * tupleType );
-
-                void previsit( CompoundStmt * compoundStmt );
+                void previsit( FunctionDecl *functionDecl );
+
+                void postvisit( TupleType *tupleType );
+
+                void previsit( CompoundStmt *compoundStmt );
 
           private:
@@ -98 +101 @@
         }
 
-        //=============================================================================================
-        // FuncGenerator definitions
-        //=============================================================================================
-        class FuncGenerator {
-        public:
-                std::list< Declaration * > definitions, forwards;
-
-                FuncGenerator( Type * type, const std::vector< FuncData > & data, unsigned int functionNesting, SymTab::Indexer & indexer ) : type( type ), data( data ), functionNesting( functionNesting ), indexer( indexer ) {}
-
-                virtual bool shouldAutogen() const = 0;
-                void genStandardFuncs();
-                virtual void genFieldCtors() = 0;
-        protected:
-                Type * type;
-                const std::vector< FuncData > & data;
-                unsigned int functionNesting;
-                SymTab::Indexer & indexer;
-
-                virtual void genFuncBody( FunctionDecl * dcl ) = 0;
-                virtual bool isConcurrentType() const = 0;
-
-                void resolve( FunctionDecl * dcl );
-                void generatePrototypes( std::list< FunctionDecl * > & newFuncs );
-        };
-
-        class StructFuncGenerator : public FuncGenerator {
-                StructDecl * aggregateDecl;
-        public:
-                StructFuncGenerator( StructDecl * aggregateDecl, StructInstType * refType, const std::vector< FuncData > & data,  unsigned int functionNesting, SymTab::Indexer & indexer ) : FuncGenerator( refType, data, functionNesting, indexer ), aggregateDecl( aggregateDecl) {}
-
-                virtual bool shouldAutogen() const override;
-                virtual bool isConcurrentType() const override;
-
-                virtual void genFuncBody( FunctionDecl * dcl ) override;
-                virtual void genFieldCtors() override;
-
-        private:
-                /// generates a single struct member operation (constructor call, destructor call, assignment call)
-                void makeMemberOp( ObjectDecl * dstParam, Expression * src, DeclarationWithType * field, FunctionDecl * func, bool forward = true );
-
-                /// generates the body of a struct function by iterating the struct members (via parameters) - generates default ctor, copy ctor, assignment, and dtor bodies, but NOT field ctor bodies
-                template<typename Iterator>
-                void makeFunctionBody( Iterator member, Iterator end, FunctionDecl * func, bool forward = true );
-
-                /// generate the body of a constructor which takes parameters that match fields, e.g.
-                /// void ?{}(A *, int) and void?{}(A *, int, int) for a struct A which has two int fields.
-                template<typename Iterator>
-                void makeFieldCtorBody( Iterator member, Iterator end, FunctionDecl * func );
-        };
-
-        class UnionFuncGenerator : public FuncGenerator {
-                UnionDecl * aggregateDecl;
-        public:
-                UnionFuncGenerator( UnionDecl * aggregateDecl, UnionInstType * refType, const std::vector< FuncData > & data,  unsigned int functionNesting, SymTab::Indexer & indexer ) : FuncGenerator( refType, data, functionNesting, indexer ), aggregateDecl( aggregateDecl) {}
-
-                virtual bool shouldAutogen() const override;
-                virtual bool isConcurrentType() const override;
-
-                virtual void genFuncBody( FunctionDecl * dcl ) override;
-                virtual void genFieldCtors() override;
-
-        private:
-                /// generates a single struct member operation (constructor call, destructor call, assignment call)
-                template<typename OutputIterator>
-                void makeMemberOp( ObjectDecl * srcParam, ObjectDecl * dstParam, OutputIterator out );
-
-                /// generates the body of a struct function by iterating the struct members (via parameters) - generates default ctor, copy ctor, assignment, and dtor bodies, but NOT field ctor bodies
-                template<typename Iterator>
-                void makeFunctionBody( Iterator member, Iterator end, FunctionDecl * func, bool forward = true );
-
-                /// generate the body of a constructor which takes parameters that match fields, e.g.
-                /// void ?{}(A *, int) and void?{}(A *, int, int) for a struct A which has two int fields.
-                template<typename Iterator>
-                void makeFieldCtorBody( Iterator member, Iterator end, FunctionDecl * func );
-        };
-
-        class EnumFuncGenerator : public FuncGenerator {
-        public:
-                EnumFuncGenerator( EnumInstType * refType, const std::vector< FuncData > & data,  unsigned int functionNesting, SymTab::Indexer & indexer ) : FuncGenerator( refType, data, functionNesting, indexer ) {}
-
-                virtual bool shouldAutogen() const override;
-                virtual bool isConcurrentType() const override;
-
-                virtual void genFuncBody( FunctionDecl * dcl ) override;
-                virtual void genFieldCtors() override;
-
-        private:
-        };
-
-        class TypeFuncGenerator : public FuncGenerator {
-                TypeDecl * typeDecl;
-        public:
-                TypeFuncGenerator( TypeDecl * typeDecl, TypeInstType * refType, const std::vector<FuncData> & data, unsigned int functionNesting, SymTab::Indexer & indexer ) : FuncGenerator( refType, data, functionNesting, indexer ), typeDecl( typeDecl ) {}
-
-                virtual bool shouldAutogen() const override;
-                virtual void genFuncBody( FunctionDecl * dcl ) override;
-                virtual bool isConcurrentType() const override;
-                virtual void genFieldCtors() override;
-        };
-
-        //=============================================================================================
-        // helper functions
-        //=============================================================================================
-        void generateFunctions( FuncGenerator & gen, std::list< Declaration * > & declsToAdd ) {
-                if ( ! gen.shouldAutogen() ) return;
-
-                // generate each of the functions based on the supplied FuncData objects
-                gen.genStandardFuncs();
-                gen.genFieldCtors();
-
-                declsToAdd.splice( declsToAdd.end(), gen.forwards );
-                declsToAdd.splice( declsToAdd.end(), gen.definitions );
-        }
-
         bool isUnnamedBitfield( ObjectDecl * obj ) {
-                return obj != nullptr && obj->name == "" && obj->bitfieldWidth != nullptr;
+                return obj != nullptr && obj->get_name() == "" && obj->get_bitfieldWidth() != nullptr;
         }
 
@@ -219 +108 @@
         void addForwardDecl( FunctionDecl * functionDecl, std::list< Declaration * > & declsToAdd ) {
                 FunctionDecl * decl = functionDecl->clone();
-                delete decl->statements;
-                decl->statements = nullptr;
+                delete decl->get_statements();
+                decl->set_statements( nullptr );
                 declsToAdd.push_back( decl );
                 decl->fixUniqueId();
         }
 
-        const std::list< TypeDecl * > getGenericParams( Type * t ) {
-                std::list< TypeDecl * > * ret = nullptr;
-                if ( StructInstType * inst = dynamic_cast< StructInstType * > ( t ) ) {
-                        ret = inst->get_baseParameters();
-                } else if ( UnionInstType * inst = dynamic_cast< UnionInstType * >( t ) ) {
-                        ret = inst->get_baseParameters();
-                }
-                return ret ? *ret : std::list< TypeDecl * >();
-        }
-
         /// given type T, generate type of default ctor/dtor, i.e. function type void (*) (T *)
         FunctionType * genDefaultType( Type * paramType ) {
-                const auto & typeParams = getGenericParams( paramType );
                 FunctionType *ftype = new FunctionType( Type::Qualifiers(), false );
-                cloneAll( typeParams, ftype->forall );
                 ObjectDecl *dstParam = new ObjectDecl( "_dst", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, new ReferenceType( Type::Qualifiers(), paramType->clone() ), nullptr );
-                ftype->parameters.push_back( dstParam );
+                ftype->get_parameters().push_back( dstParam );
                 return ftype;
         }
@@ -249 +126 @@
                 FunctionType *ftype = genDefaultType( paramType );
                 ObjectDecl *srcParam = new ObjectDecl( "_src", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType->clone(), nullptr );
-                ftype->parameters.push_back( srcParam );
+                ftype->get_parameters().push_back( srcParam );
                 return ftype;
         }
@@ -257 +134 @@
                 FunctionType *ftype = genCopyType( paramType );
                 ObjectDecl *returnVal = new ObjectDecl( "_ret", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType->clone(), nullptr );
-                ftype->returnVals.push_back( returnVal );
+                ftype->get_returnVals().push_back( returnVal );
                 return ftype;
         }
@@ -274 +151 @@
         }
 
-        Type * declToType( Declaration * decl ) {
-                if ( DeclarationWithType * dwt = dynamic_cast< DeclarationWithType * >( decl ) ) {
-                        return dwt->get_type();
-                }
-                return nullptr;
-        }
-
-        Type * declToTypeDeclBase( Declaration * decl ) {
-                if ( TypeDecl * td = dynamic_cast< TypeDecl * >( decl ) ) {
-                        return td->base;
-                }
-                return nullptr;
-        }
-
-        //=============================================================================================
-        // FuncGenerator member definitions
-        //=============================================================================================
-        void FuncGenerator::genStandardFuncs() {
-                std::list< FunctionDecl * > newFuncs;
-                generatePrototypes( newFuncs );
-
-                for ( FunctionDecl * dcl : newFuncs ) {
-                        genFuncBody( dcl );
-                        if ( CodeGen::isAssignment( dcl->name ) ) {
-                                // assignment needs to return a value
-                                FunctionType * assignType = dcl->type;
-                                assert( assignType->parameters.size() == 2 );
-                                assert( assignType->returnVals.size() == 1 );
-                                ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( assignType->parameters.front() );
-                                dcl->statements->push_back( new ReturnStmt( noLabels, new VariableExpr( dstParam ) ) );
-                        }
-                        resolve( dcl );
-                }
-        }
-
-        void FuncGenerator::generatePrototypes( std::list< FunctionDecl * > & newFuncs ) {
-                bool concurrent_type = isConcurrentType();
-                for ( const FuncData & data : data ) {
-                        // generate a function (?{}, ?=?, ^?{}) based on the current FuncData.
-                        FunctionType * ftype = data.genType( type );
-
-                        // destructor for concurrent type must be mutex
+        /// inserts base type of first argument into map if pred(funcDecl) is true
+        void insert( FunctionDecl *funcDecl, TypeMap & map, FunctionDecl * (*pred)(Declaration *) ) {
+                // insert type into constructable, etc. map if appropriate
+                if ( pred( funcDecl ) ) {
+                        FunctionType * ftype = funcDecl->get_functionType();
+                        assert( ! ftype->get_parameters().empty() );
+                        Type * t = InitTweak::getPointerBase( ftype->get_parameters().front()->get_type() );
+                        assert( t );
+                        map.insert( Mangler::mangleType( t ), true );
+                }
+        }
+
+        /// using map and t, determines if is constructable, etc.
+        bool lookup( const TypeMap & map, Type * t ) {
+                assertf( t, "Autogenerate lookup was given non-type: %s", toString( t ).c_str() );
+                if ( dynamic_cast< PointerType * >( t ) ) {
+                        // will need more complicated checking if we want this to work with pointer types, since currently
+                        return true;
+                } else if ( ArrayType * at = dynamic_cast< ArrayType * >( t ) ) {
+                        // an array's constructor, etc. is generated on the fly based on the base type's constructor, etc.
+                        return lookup( map, at->get_base() );
+                }
+                TypeMap::const_iterator it = map.find( Mangler::mangleType( t ) );
+                if ( it != map.end() ) return it->second;
+                // something that does not appear in the map is by default not constructable, etc.
+                return false;
+        }
+
+        /// using map and aggr, examines each member to determine if constructor, etc. should be generated
+        template<typename Container>
+        bool shouldGenerate( const TypeMap & map, const Container & container ) {
+                for ( Type * t : container ) {
+                        if ( ! lookup( map, t ) ) return false;
+                }
+                return true;
+        }
+
+        /// data structure for abstracting the generation of special functions
+        template< typename OutputIterator, typename Container >
+        struct FuncGenerator {
+                const Container & container;
+                Type *refType;
+                unsigned int functionNesting;
+                const std::list< TypeDecl* > & typeParams;
+                OutputIterator out;
+                FuncGenerator( const Container & container, Type *refType, unsigned int functionNesting, const std::list< TypeDecl* > & typeParams, OutputIterator out ) : container( container ), refType( refType ), functionNesting( functionNesting ), typeParams( typeParams ), out( out ) {}
+
+                /// generates a function (?{}, ?=?, ^?{}) based on the data argument and members. If function is generated, inserts the type into the map.
+                void gen( const FuncData & data, bool concurrent_type ) {
+                        if ( ! shouldGenerate( data.map, container ) ) return;
+                        FunctionType * ftype = data.genType( refType );
+
                         if ( concurrent_type && CodeGen::isDestructor( data.fname ) ) {
                                 ftype->parameters.front()->get_type()->set_mutex( true );
                         }
 
-                        newFuncs.push_back( genFunc( data.fname, ftype, functionNesting ) );
-                }
-        }
-
-        void FuncGenerator::resolve( FunctionDecl * dcl ) {
-                try {
-                        ResolvExpr::resolveDecl( dcl, indexer );
-                        if ( functionNesting == 0 ) {
-                                // forward declare if top-level struct, so that
-                                // type is complete as soon as its body ends
-                                // Note: this is necessary if we want structs which contain
-                                // generic (otype) structs as members.
-                                addForwardDecl( dcl, forwards );
-                        }
-                        definitions.push_back( dcl );
-                        indexer.addId( dcl );
-                } catch ( SemanticError err ) {
-                        // okay if decl does not resolve - that means the function should not be generated
-                        delete dcl;
-                }
-        }
-
-        bool StructFuncGenerator::shouldAutogen() const {
-                // Builtins do not use autogeneration.
-                return ! aggregateDecl->linkage.is_builtin;
-        }
-        bool StructFuncGenerator::isConcurrentType() const { return aggregateDecl->is_thread() || aggregateDecl->is_monitor(); }
-
-        void StructFuncGenerator::genFuncBody( FunctionDecl * dcl ) {
-                // generate appropriate calls to member ctor, assignment
-                // destructor needs to do everything in reverse, so pass "forward" based on whether the function is a destructor
-                if ( ! CodeGen::isDestructor( dcl->name ) ) {
-                        makeFunctionBody( aggregateDecl->members.begin(), aggregateDecl->members.end(), dcl );
-                } else {
-                        makeFunctionBody( aggregateDecl->members.rbegin(), aggregateDecl->members.rend(), dcl, false );
-                }
-        }
-
-        void StructFuncGenerator::genFieldCtors() {
-                // field ctors are only generated if default constructor and copy constructor are both generated
-                unsigned numCtors = std::count_if( definitions.begin(), definitions.end(), [](Declaration * dcl) { return CodeGen::isConstructor( dcl->name ); } );
-
-                // Field constructors are only generated if default and copy constructor
-                // are generated, since they need access to both
-                if ( numCtors != 2 ) return;
-
-                // create constructors which take each member type as a parameter.
-                // for example, for struct A { int x, y; }; generate
-                //   void ?{}(A *, int) and void ?{}(A *, int, int)
-                FunctionType * memCtorType = genDefaultType( type );
-                for ( Declaration * member : aggregateDecl->members ) {
-                        DeclarationWithType * field = strict_dynamic_cast<DeclarationWithType *>( member );
-                        if ( isUnnamedBitfield( dynamic_cast< ObjectDecl * > ( field ) ) ) {
-                                // don't make a function whose parameter is an unnamed bitfield
-                                continue;
-                        }
-                        memCtorType->parameters.push_back( new ObjectDecl( field->name, Type::StorageClasses(), LinkageSpec::Cforall, 0, field->get_type()->clone(), 0 ) );
-                        FunctionDecl * ctor = genFunc( "?{}", memCtorType->clone(), functionNesting );
-                        makeFieldCtorBody( aggregateDecl->members.begin(), aggregateDecl->members.end(), ctor );
-                        resolve( ctor );
-                }
-                delete memCtorType;
-        }
-
-        void StructFuncGenerator::makeMemberOp( ObjectDecl * dstParam, Expression * src, DeclarationWithType * field, FunctionDecl * func, bool forward ) {
+                        cloneAll( typeParams, ftype->forall );
+                        *out++ = genFunc( data.fname, ftype, functionNesting );
+                        data.map.insert( Mangler::mangleType( refType ), true );
+                }
+        };
+
+        template< typename OutputIterator, typename Container >
+        FuncGenerator<OutputIterator, Container> makeFuncGenerator( const Container & container, Type *refType, unsigned int functionNesting, const std::list< TypeDecl* > & typeParams, OutputIterator out ) {
+                return FuncGenerator<OutputIterator, Container>( container, refType, functionNesting, typeParams, out );
+        }
+
+        /// generates a single enumeration assignment expression
+        ApplicationExpr * genEnumAssign( FunctionType * ftype, FunctionDecl * assignDecl ) {
+                // enum copy construct and assignment is just C-style assignment.
+                // this looks like a bad recursive call, but code gen will turn it into
+                // a C-style assignment.
+                // This happens before function pointer type conversion, so need to do it manually here
+                // NOTE: ftype is not necessarily the functionType belonging to assignDecl - ftype is the
+                // type of the function that this expression is being generated for (so that the correct
+                // parameters) are using in the variable exprs
+                assert( ftype->get_parameters().size() == 2 );
+                ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( ftype->get_parameters().front() );
+                ObjectDecl * srcParam = strict_dynamic_cast< ObjectDecl * >( ftype->get_parameters().back() );
+
+                VariableExpr * assignVarExpr = new VariableExpr( assignDecl );
+                Type * assignVarExprType = assignVarExpr->get_result();
+                assignVarExprType = new PointerType( Type::Qualifiers(), assignVarExprType );
+                assignVarExpr->set_result( assignVarExprType );
+                ApplicationExpr * assignExpr = new ApplicationExpr( assignVarExpr );
+                assignExpr->get_args().push_back( new VariableExpr( dstParam ) );
+                assignExpr->get_args().push_back( new VariableExpr( srcParam ) );
+                return assignExpr;
+        }
+
+        // E ?=?(E volatile*, int),
+        //   ?=?(E _Atomic volatile*, int);
+        void makeEnumFunctions( EnumInstType *refType, unsigned int functionNesting, std::list< Declaration * > &declsToAdd ) {
+
+                // T ?=?(E *, E);
+                FunctionType *assignType = genAssignType( refType );
+
+                // void ?{}(E *); void ^?{}(E *);
+                FunctionType * ctorType = genDefaultType( refType->clone() );
+                FunctionType * dtorType = genDefaultType( refType->clone() );
+
+                // void ?{}(E *, E);
+                FunctionType *copyCtorType = genCopyType( refType->clone() );
+
+                // add unused attribute to parameters of default constructor and destructor
+                ctorType->get_parameters().front()->get_attributes().push_back( new Attribute( "unused" ) );
+                dtorType->get_parameters().front()->get_attributes().push_back( new Attribute( "unused" ) );
+
+                // xxx - should we also generate void ?{}(E *, int) and E ?{}(E *, E)?
+                // right now these cases work, but that might change.
+
+                // xxx - Temporary: make these functions intrinsic so they codegen as C assignment.
+                // Really they're something of a cross between instrinsic and autogen, so should
+                // probably make a new linkage type
+                FunctionDecl *assignDecl = genFunc( "?=?", assignType, functionNesting, true );
+                FunctionDecl *ctorDecl = genFunc( "?{}", ctorType, functionNesting, true );
+                FunctionDecl *copyCtorDecl = genFunc( "?{}", copyCtorType, functionNesting, true );
+                FunctionDecl *dtorDecl = genFunc( "^?{}", dtorType, functionNesting, true );
+
+                // body is either return stmt or expr stmt
+                assignDecl->get_statements()->get_kids().push_back( new ReturnStmt( noLabels, genEnumAssign( assignType, assignDecl ) ) );
+                copyCtorDecl->get_statements()->get_kids().push_back( new ExprStmt( noLabels, genEnumAssign( copyCtorType, assignDecl ) ) );
+
+                declsToAdd.push_back( ctorDecl );
+                declsToAdd.push_back( copyCtorDecl );
+                declsToAdd.push_back( dtorDecl );
+                declsToAdd.push_back( assignDecl ); // assignment should come last since it uses copy constructor in return
+        }
+
+        /// generates a single struct member operation (constructor call, destructor call, assignment call)
+        void makeStructMemberOp( ObjectDecl * dstParam, Expression * src, DeclarationWithType * field, FunctionDecl * func, bool forward = true ) {
                 InitTweak::InitExpander srcParam( src );
 
                 // assign to destination
-                Expression *dstselect = new MemberExpr( field, new CastExpr( new VariableExpr( dstParam ), strict_dynamic_cast< ReferenceType* >( dstParam->get_type() )->base->clone() ) );
-                genImplicitCall( srcParam, dstselect, func->name, back_inserter( func->statements->kids ), field, forward );
-        }
-
+                Expression *dstselect = new MemberExpr( field, new CastExpr( new VariableExpr( dstParam ), strict_dynamic_cast< ReferenceType* >( dstParam->get_type() )->get_base()->clone() ) );
+                genImplicitCall( srcParam, dstselect, func->get_name(), back_inserter( func->get_statements()->get_kids() ), field, forward );
+        }
+
+        /// generates the body of a struct function by iterating the struct members (via parameters) - generates default ctor, copy ctor, assignment, and dtor bodies, but NOT field ctor bodies
         template<typename Iterator>
-        void StructFuncGenerator::makeFunctionBody( Iterator member, Iterator end, FunctionDecl * func, bool forward ) {
+        void makeStructFunctionBody( Iterator member, Iterator end, FunctionDecl * func, bool forward = true ) {
                 for ( ; member != end; ++member ) {
                         if ( DeclarationWithType *field = dynamic_cast< DeclarationWithType * >( *member ) ) { // otherwise some form of type declaration, e.g. Aggregate
@@ -403 +301 @@
                                 }
 
-                                if ( type->get_const() && CodeGen::isAssignment( func->name ) ) {
+                                if ( type->get_const() && func->get_name() == "?=?" ) {
                                         // don't assign const members, but do construct/destruct
+                                        continue;
+                                }
+
+                                if ( field->get_name() == "" ) {
+                                        // don't assign to anonymous members
+                                        // xxx - this is a temporary fix. Anonymous members tie into
+                                        // our inheritance model. I think the correct way to handle this is to
+                                        // cast the structure to the type of the member and let the resolver
+                                        // figure out whether it's valid and have a pass afterwards that fixes
+                                        // the assignment to use pointer arithmetic with the offset of the
+                                        // member, much like how generic type members are handled.
                                         continue;
                                 }
@@ -414 +323 @@
                                         srcParam = dynamic_cast<ObjectDecl*>( func->get_functionType()->get_parameters().back() );
                                 }
-
                                 // srcParam may be NULL, in which case we have default ctor/dtor
                                 assert( dstParam );
 
                                 Expression *srcselect = srcParam ? new MemberExpr( field, new VariableExpr( srcParam ) ) : nullptr;
-                                makeMemberOp( dstParam, srcselect, field, func, forward );
+                                makeStructMemberOp( dstParam, srcselect, field, func, forward );
                         } // if
                 } // for
-        } // makeFunctionBody
-
+        } // makeStructFunctionBody
+
+        /// generate the body of a constructor which takes parameters that match fields, e.g.
+        /// void ?{}(A *, int) and void?{}(A *, int, int) for a struct A which has two int fields.
         template<typename Iterator>
-        void StructFuncGenerator::makeFieldCtorBody( Iterator member, Iterator end, FunctionDecl * func ) {
-                FunctionType * ftype = func->type;
-                std::list<DeclarationWithType*> & params = ftype->parameters;
+        void makeStructFieldCtorBody( Iterator member, Iterator end, FunctionDecl * func ) {
+                FunctionType * ftype = func->get_functionType();
+                std::list<DeclarationWithType*> & params = ftype->get_parameters();
                 assert( params.size() >= 2 );  // should not call this function for default ctor, etc.
 
@@ -439 +349 @@
                                         // don't make a function whose parameter is an unnamed bitfield
                                         continue;
+                                } else if ( field->get_name() == "" ) {
+                                        // don't assign to anonymous members
+                                        // xxx - this is a temporary fix. Anonymous members tie into
+                                        // our inheritance model. I think the correct way to handle this is to
+                                        // cast the structure to the type of the member and let the resolver
+                                        // figure out whether it's valid and have a pass afterwards that fixes
+                                        // the assignment to use pointer arithmetic with the offset of the
+                                        // member, much like how generic type members are handled.
+                                        continue;
                                 } else if ( parameter != params.end() ) {
                                         // matching parameter, initialize field with copy ctor
                                         Expression *srcselect = new VariableExpr(*parameter);
-                                        makeMemberOp( dstParam, srcselect, field, func );
+                                        makeStructMemberOp( dstParam, srcselect, field, func );
                                         ++parameter;
                                 } else {
                                         // no matching parameter, initialize field with default ctor
-                                        makeMemberOp( dstParam, nullptr, field, func );
+                                        makeStructMemberOp( dstParam, nullptr, field, func );
                                 }
                         }
@@ -452 +371 @@
         }
 
-        bool UnionFuncGenerator::shouldAutogen() const {
+        Type * declToType( Declaration * decl ) {
+                if ( DeclarationWithType * dwt = dynamic_cast< DeclarationWithType * >( decl ) ) {
+                        return dwt->get_type();
+                }
+                return nullptr;
+        }
+
+        /// generates struct constructors, destructor, and assignment functions
+        void makeStructFunctions( StructDecl *aggregateDecl, StructInstType *refType, unsigned int functionNesting, std::list< Declaration * > & declsToAdd, const std::vector< FuncData > & data ) {
                 // Builtins do not use autogeneration.
-                return ! aggregateDecl->linkage.is_builtin;
-        }
-
-        // xxx - is this right?
-        bool UnionFuncGenerator::isConcurrentType() const { return false; };
+                if ( LinkageSpec::isBuiltin( aggregateDecl->get_linkage() ) ) {
+                        return;
+                }
+
+                // Make function polymorphic in same parameters as generic struct, if applicable
+                const std::list< TypeDecl * > & typeParams = aggregateDecl->get_parameters(); // List of type variables to be placed on the generated functions
+
+                // generate each of the functions based on the supplied FuncData objects
+                std::list< FunctionDecl * > newFuncs;
+                // structure that iterates aggregate decl members, returning their types
+                auto generator = makeFuncGenerator( lazy_map( aggregateDecl->members, declToType ), refType, functionNesting, typeParams, back_inserter( newFuncs ) );
+                for ( const FuncData & d : data ) {
+                        generator.gen( d, aggregateDecl->is_thread() || aggregateDecl->is_monitor() );
+                }
+
+                // field ctors are only generated if default constructor and copy constructor are both generated
+                unsigned numCtors = std::count_if( newFuncs.begin(), newFuncs.end(), [](FunctionDecl * dcl) { return CodeGen::isConstructor( dcl->get_name() ); } );
+
+                if ( functionNesting == 0 ) {
+                        // forward declare if top-level struct, so that
+                        // type is complete as soon as its body ends
+                        // Note: this is necessary if we want structs which contain
+                        // generic (otype) structs as members.
+                        for ( FunctionDecl * dcl : newFuncs ) {
+                                addForwardDecl( dcl, declsToAdd );
+                        }
+                }
+
+                for ( FunctionDecl * dcl : newFuncs ) {
+                        // generate appropriate calls to member ctor, assignment
+                        // destructor needs to do everything in reverse, so pass "forward" based on whether the function is a destructor
+                        if ( ! CodeGen::isDestructor( dcl->get_name() ) ) {
+                                makeStructFunctionBody( aggregateDecl->get_members().begin(), aggregateDecl->get_members().end(), dcl );
+                        } else {
+                                makeStructFunctionBody( aggregateDecl->get_members().rbegin(), aggregateDecl->get_members().rend(), dcl, false );
+                        }
+                        if ( CodeGen::isAssignment( dcl->get_name() ) ) {
+                                // assignment needs to return a value
+                                FunctionType * assignType = dcl->get_functionType();
+                                assert( assignType->get_parameters().size() == 2 );
+                                ObjectDecl * srcParam = strict_dynamic_cast< ObjectDecl * >( assignType->get_parameters().back() );
+                                dcl->get_statements()->get_kids().push_back( new ReturnStmt( noLabels, new VariableExpr( srcParam ) ) );
+                        }
+                        declsToAdd.push_back( dcl );
+                }
+
+                // create constructors which take each member type as a parameter.
+                // for example, for struct A { int x, y; }; generate
+                //   void ?{}(A *, int) and void ?{}(A *, int, int)
+                // Field constructors are only generated if default and copy constructor
+                // are generated, since they need access to both
+                if ( numCtors == 2 ) {
+                        FunctionType * memCtorType = genDefaultType( refType );
+                        cloneAll( typeParams, memCtorType->get_forall() );
+                        for ( std::list<Declaration *>::iterator i = aggregateDecl->get_members().begin(); i != aggregateDecl->get_members().end(); ++i ) {
+                                DeclarationWithType * member = dynamic_cast<DeclarationWithType *>( *i );
+                                assert( member );
+                                if ( isUnnamedBitfield( dynamic_cast< ObjectDecl * > ( member ) ) ) {
+                                        // don't make a function whose parameter is an unnamed bitfield
+                                        continue;
+                                } else if ( member->get_name() == "" ) {
+                                        // don't assign to anonymous members
+                                        // xxx - this is a temporary fix. Anonymous members tie into
+                                        // our inheritance model. I think the correct way to handle this is to
+                                        // cast the structure to the type of the member and let the resolver
+                                        // figure out whether it's valid/choose the correct unnamed member
+                                        continue;
+                                }
+                                memCtorType->get_parameters().push_back( new ObjectDecl( member->get_name(), Type::StorageClasses(), LinkageSpec::Cforall, 0, member->get_type()->clone(), 0 ) );
+                                FunctionDecl * ctor = genFunc( "?{}", memCtorType->clone(), functionNesting );
+                                makeStructFieldCtorBody( aggregateDecl->get_members().begin(), aggregateDecl->get_members().end(), ctor );
+                                declsToAdd.push_back( ctor );
+                        }
+                        delete memCtorType;
+                }
+        }
 
         /// generate a single union assignment expression (using memcpy)
         template< typename OutputIterator >
-        void UnionFuncGenerator::makeMemberOp( ObjectDecl * srcParam, ObjectDecl * dstParam, OutputIterator out ) {
+        void makeUnionFieldsAssignment( ObjectDecl * srcParam, ObjectDecl * dstParam, OutputIterator out ) {
                 UntypedExpr *copy = new UntypedExpr( new NameExpr( "__builtin_memcpy" ) );
-                copy->args.push_back( new AddressExpr( new VariableExpr( dstParam ) ) );
-                copy->args.push_back( new AddressExpr( new VariableExpr( srcParam ) ) );
-                copy->args.push_back( new SizeofExpr( srcParam->get_type()->clone() ) );
+                copy->get_args().push_back( new AddressExpr( new VariableExpr( dstParam ) ) );
+                copy->get_args().push_back( new AddressExpr( new VariableExpr( srcParam ) ) );
+                copy->get_args().push_back( new SizeofExpr( srcParam->get_type()->clone() ) );
                 *out++ = new ExprStmt( noLabels, copy );
         }
 
         /// generates the body of a union assignment/copy constructor/field constructor
-        void UnionFuncGenerator::genFuncBody( FunctionDecl * funcDecl ) {
-                FunctionType * ftype = funcDecl->type;
-                if ( InitTweak::isCopyConstructor( funcDecl ) || InitTweak::isAssignment( funcDecl ) ) {
-                        assert( ftype->parameters.size() == 2 );
-                        ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( ftype->parameters.front() );
-                        ObjectDecl * srcParam = strict_dynamic_cast< ObjectDecl * >( ftype->parameters.back() );
-                        makeMemberOp( srcParam, dstParam, back_inserter( funcDecl->statements->kids ) );
-                } else {
-                        // default ctor/dtor body is empty - add unused attribute to parameter to silence warnings
-                        assert( ftype->parameters.size() == 1 );
-                        ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( ftype->parameters.front() );
-                        dstParam->attributes.push_back( new Attribute( "unused" ) );
-                }
-        }
-
-        /// generate the body of a constructor which takes parameters that match fields, e.g.
-        /// void ?{}(A *, int) and void?{}(A *, int, int) for a struct A which has two int fields.
-        void UnionFuncGenerator::genFieldCtors() {
-                // field ctors are only generated if default constructor and copy constructor are both generated
-                unsigned numCtors = std::count_if( definitions.begin(), definitions.end(), [](Declaration * dcl) { return CodeGen::isConstructor( dcl->get_name() ); } );
-
-                // Field constructors are only generated if default and copy constructor
-                // are generated, since they need access to both
-                if ( numCtors != 2 ) return;
+        void makeUnionAssignBody( FunctionDecl * funcDecl ) {
+                FunctionType * ftype = funcDecl->get_functionType();
+                assert( ftype->get_parameters().size() == 2 );
+                ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( ftype->get_parameters().front() );
+                ObjectDecl * srcParam = strict_dynamic_cast< ObjectDecl * >( ftype->get_parameters().back() );
+
+                makeUnionFieldsAssignment( srcParam, dstParam, back_inserter( funcDecl->get_statements()->get_kids() ) );
+                if ( CodeGen::isAssignment( funcDecl->get_name() ) ) {
+                        // also generate return statement in assignment
+                        funcDecl->get_statements()->get_kids().push_back( new ReturnStmt( noLabels, new VariableExpr( srcParam ) ) );
+                }
+        }
+
+        /// generates union constructors, destructors, and assignment operator
+        void makeUnionFunctions( UnionDecl *aggregateDecl, UnionInstType *refType, unsigned int functionNesting, std::list< Declaration * > & declsToAdd ) {
+                // Make function polymorphic in same parameters as generic union, if applicable
+                const std::list< TypeDecl* > & typeParams = aggregateDecl->get_parameters(); // List of type variables to be placed on the generated functions
+
+                // default ctor/dtor need only first parameter
+                // void ?{}(T *); void ^?{}(T *);
+                FunctionType *ctorType = genDefaultType( refType );
+                FunctionType *dtorType = genDefaultType( refType );
+
+                // copy ctor needs both parameters
+                // void ?{}(T *, T);
+                FunctionType *copyCtorType = genCopyType( refType );
+
+                // assignment needs both and return value
+                // T ?=?(T *, T);
+                FunctionType *assignType = genAssignType( refType );
+
+                cloneAll( typeParams, ctorType->get_forall() );
+                cloneAll( typeParams, dtorType->get_forall() );
+                cloneAll( typeParams, copyCtorType->get_forall() );
+                cloneAll( typeParams, assignType->get_forall() );
+
+                // add unused attribute to parameters of default constructor and destructor
+                ctorType->get_parameters().front()->get_attributes().push_back( new Attribute( "unused" ) );
+                dtorType->get_parameters().front()->get_attributes().push_back( new Attribute( "unused" ) );
+
+                // Routines at global scope marked "static" to prevent multiple definitions is separate translation units
+                // because each unit generates copies of the default routines for each aggregate.
+                FunctionDecl *assignDecl = genFunc( "?=?", assignType, functionNesting );
+                FunctionDecl *ctorDecl = genFunc( "?{}",  ctorType, functionNesting );
+                FunctionDecl *copyCtorDecl = genFunc( "?{}", copyCtorType, functionNesting );
+                FunctionDecl *dtorDecl = genFunc( "^?{}", dtorType, functionNesting );
+
+                makeUnionAssignBody( assignDecl );
+
+                // body of assignment and copy ctor is the same
+                makeUnionAssignBody( copyCtorDecl );
 
                 // create a constructor which takes the first member type as a parameter.
@@ -500 +525 @@
                 // void ?{}(A *, int)
                 // This is to mimic C's behaviour which initializes the first member of the union.
-                FunctionType * memCtorType = genDefaultType( type );
-                for ( Declaration * member : aggregateDecl->members ) {
-                        DeclarationWithType * field = strict_dynamic_cast<DeclarationWithType *>( member );
-                        if ( isUnnamedBitfield( dynamic_cast< ObjectDecl * > ( field ) ) ) {
-                                // don't make a function whose parameter is an unnamed bitfield
+                std::list<Declaration *> memCtors;
+                for ( Declaration * member : aggregateDecl->get_members() ) {
+                        if ( DeclarationWithType * field = dynamic_cast< DeclarationWithType * >( member ) ) {
+                                ObjectDecl * srcParam = new ObjectDecl( "src", Type::StorageClasses(), LinkageSpec::Cforall, 0, field->get_type()->clone(), 0 );
+
+                                FunctionType * memCtorType = ctorType->clone();
+                                memCtorType->get_parameters().push_back( srcParam );
+                                FunctionDecl * ctor = genFunc( "?{}", memCtorType, functionNesting );
+
+                                makeUnionAssignBody( ctor );
+                                memCtors.push_back( ctor );
+                                // only generate a ctor for the first field
                                 break;
                         }
-                        memCtorType->parameters.push_back( new ObjectDecl( field->name, Type::StorageClasses(), LinkageSpec::Cforall, nullptr, field->get_type()->clone(), nullptr ) );
-                        FunctionDecl * ctor = genFunc( "?{}", memCtorType->clone(), functionNesting );
-                        ObjectDecl * srcParam = strict_dynamic_cast<ObjectDecl *>( ctor->type->parameters.back() );
-                        srcParam->fixUniqueId();
-                        ObjectDecl * dstParam = InitTweak::getParamThis( ctor->type );
-                        makeMemberOp( srcParam, dstParam, back_inserter( ctor->statements->kids ) );
-                        resolve( ctor );
-                        // only generate one field ctor for unions
-                        break;
-                }
-                delete memCtorType;
-        }
-
-        void EnumFuncGenerator::genFuncBody( FunctionDecl * funcDecl ) {
-                // xxx - Temporary: make these functions intrinsic so they codegen as C assignment.
-                // Really they're something of a cross between instrinsic and autogen, so should
-                // probably make a new linkage type
-                funcDecl->linkage = LinkageSpec::Intrinsic;
-                FunctionType * ftype = funcDecl->type;
-                if ( InitTweak::isCopyConstructor( funcDecl ) || InitTweak::isAssignment( funcDecl ) ) {
-                        assert( ftype->parameters.size() == 2 );
-                        ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( ftype->parameters.front() );
-                        ObjectDecl * srcParam = strict_dynamic_cast< ObjectDecl * >( ftype->parameters.back() );
-
-                        // enum copy construct and assignment is just C-style assignment.
-                        // this looks like a bad recursive call, but code gen will turn it into
-                        // a C-style assignment.
-                        // This happens before function pointer type conversion, so need to do it manually here
-                        ApplicationExpr * callExpr = new ApplicationExpr( VariableExpr::functionPointer( funcDecl ) );
-                        callExpr->get_args().push_back( new VariableExpr( dstParam ) );
-                        callExpr->get_args().push_back( new VariableExpr( srcParam ) );
-                        funcDecl->statements->push_back( new ExprStmt( noLabels, callExpr ) );
-                } else {
-                        // default ctor/dtor body is empty - add unused attribute to parameter to silence warnings
-                        assert( ftype->parameters.size() == 1 );
-                        ObjectDecl * dstParam = strict_dynamic_cast< ObjectDecl * >( ftype->parameters.front() );
-                        dstParam->attributes.push_back( new Attribute( "unused" ) );
-                }
-        }
-
-        bool EnumFuncGenerator::shouldAutogen() const { return true; }
-        bool EnumFuncGenerator::isConcurrentType() const { return false; }
-        // enums do not have field constructors
-        void EnumFuncGenerator::genFieldCtors() {}
-
-        bool TypeFuncGenerator::shouldAutogen() const { return true; };
-
-        void TypeFuncGenerator::genFuncBody( FunctionDecl * dcl ) {
-                FunctionType * ftype = dcl->type;
-                assertf( ftype->parameters.size() == 1 || ftype->parameters.size() == 2, "Incorrect number of parameters in autogenerated typedecl function: %zd", ftype->parameters.size() );
-                DeclarationWithType * dst = ftype->parameters.front();
-                DeclarationWithType * src = ftype->parameters.size() == 2 ? ftype->parameters.back() : nullptr;
-                // generate appropriate calls to member ctor, assignment
-                UntypedExpr * expr = new UntypedExpr( new NameExpr( dcl->name ) );
-                expr->args.push_back( new CastExpr( new VariableExpr( dst ), new ReferenceType( Type::Qualifiers(), typeDecl->base->clone() ) ) );
-                if ( src ) expr->args.push_back( new CastExpr( new VariableExpr( src ), typeDecl->base->clone() ) );
-                dcl->statements->kids.push_back( new ExprStmt( noLabels, expr ) );
-        };
-
-        // xxx - should reach in and determine if base type is concurrent?
-        bool TypeFuncGenerator::isConcurrentType() const { return false; };
-
-        // opaque types do not have field constructors
-        void TypeFuncGenerator::genFieldCtors() {};
-
-        //=============================================================================================
-        // Visitor definitions
-        //=============================================================================================
+                }
+
+                declsToAdd.push_back( ctorDecl );
+                declsToAdd.push_back( copyCtorDecl );
+                declsToAdd.push_back( dtorDecl );
+                declsToAdd.push_back( assignDecl ); // assignment should come last since it uses copy constructor in return
+                declsToAdd.splice( declsToAdd.end(), memCtors );
+        }
+
         AutogenerateRoutines::AutogenerateRoutines() {
                 // the order here determines the order that these functions are generated.
                 // assignment should come last since it uses copy constructor in return.
-                data.emplace_back( "?{}", genDefaultType );
-                data.emplace_back( "?{}", genCopyType );
-                data.emplace_back( "^?{}", genDefaultType );
-                data.emplace_back( "?=?", genAssignType );
+                data.emplace_back( "?{}", genDefaultType, constructable );
+                data.emplace_back( "?{}", genCopyType, copyable );
+                data.emplace_back( "^?{}", genDefaultType, destructable );
+                data.emplace_back( "?=?", genAssignType, assignable );
         }
 
         void AutogenerateRoutines::previsit( EnumDecl * enumDecl ) {
-                // must visit children (enum constants) to add them to the indexer
-                if ( enumDecl->has_body() ) {
-                        EnumInstType enumInst( Type::Qualifiers(), enumDecl->get_name() );
-                        enumInst.set_baseEnum( enumDecl );
-                        EnumFuncGenerator gen( &enumInst, data, functionNesting, indexer );
-                        generateFunctions( gen, declsToAddAfter );
+                visit_children = false;
+                if ( ! enumDecl->get_members().empty() ) {
+                        EnumInstType *enumInst = new EnumInstType( Type::Qualifiers(), enumDecl->get_name() );
+                        // enumInst->set_baseEnum( enumDecl );
+                        makeEnumFunctions( enumInst, functionNesting, declsToAddAfter );
                 }
         }
@@ -596 +568 @@
         void AutogenerateRoutines::previsit( StructDecl * structDecl ) {
                 visit_children = false;
-                if ( structDecl->has_body() ) {
+                if ( structDecl->has_body() && structsDone.find( structDecl->name ) == structsDone.end() ) {
                         StructInstType structInst( Type::Qualifiers(), structDecl->name );
+                        for ( TypeDecl * typeDecl : structDecl->parameters ) {
+                                // need to visit assertions so that they are added to the appropriate maps
+                                acceptAll( typeDecl->assertions, *visitor );
+                                structInst.parameters.push_back( new TypeExpr( new TypeInstType( Type::Qualifiers(), typeDecl->name, typeDecl ) ) );
+                        }
                         structInst.set_baseStruct( structDecl );
-                        for ( TypeDecl * typeDecl : structDecl->parameters ) {
-                                structInst.parameters.push_back( new TypeExpr( new TypeInstType( Type::Qualifiers(), typeDecl->name, typeDecl ) ) );
-                        }
-                        StructFuncGenerator gen( structDecl, &structInst, data, functionNesting, indexer );
-                        generateFunctions( gen, declsToAddAfter );
+                        makeStructFunctions( structDecl, &structInst, functionNesting, declsToAddAfter, data );
+                        structsDone.insert( structDecl->name );
                 } // if
         }
@@ -609 +583 @@
         void AutogenerateRoutines::previsit( UnionDecl * unionDecl ) {
                 visit_children = false;
-                if ( unionDecl->has_body()  ) {
+                if ( ! unionDecl->get_members().empty() ) {
                         UnionInstType unionInst( Type::Qualifiers(), unionDecl->get_name() );
                         unionInst.set_baseUnion( unionDecl );
@@ -615 +589 @@
                                 unionInst.get_parameters().push_back( new TypeExpr( new TypeInstType( Type::Qualifiers(), typeDecl->get_name(), typeDecl ) ) );
                         }
-                        UnionFuncGenerator gen( unionDecl, &unionInst, data, functionNesting, indexer );
-                        generateFunctions( gen, declsToAddAfter );
+                        makeUnionFunctions( unionDecl, &unionInst, functionNesting, declsToAddAfter );
                 } // if
+        }
+
+        Type * declToTypeDeclBase( Declaration * decl ) {
+                if ( TypeDecl * td = dynamic_cast< TypeDecl * >( decl ) ) {
+                        return td->base;
+                }
+                return nullptr;
         }
 
@@ -625 +605 @@
                 if ( ! typeDecl->base ) return;
 
+                // generate each of the functions based on the supplied FuncData objects
+                std::list< FunctionDecl * > newFuncs;
+                std::list< Declaration * > tds { typeDecl };
+                std::list< TypeDecl * > typeParams;
                 TypeInstType refType( Type::Qualifiers(), typeDecl->name, typeDecl );
-                TypeFuncGenerator gen( typeDecl, &refType, data, functionNesting, indexer );
-                generateFunctions( gen, declsToAddAfter );
+                auto generator = makeFuncGenerator( lazy_map( tds, declToTypeDeclBase ), &refType, functionNesting, typeParams, back_inserter( newFuncs ) );
+                for ( const FuncData & d : data ) {
+                        generator.gen( d, false );
+                }
+
+                if ( functionNesting == 0 ) {
+                        // forward declare if top-level struct, so that
+                        // type is complete as soon as its body ends
+                        // Note: this is necessary if we want structs which contain
+                        // generic (otype) structs as members.
+                        for ( FunctionDecl * dcl : newFuncs ) {
+                                addForwardDecl( dcl, declsToAddAfter );
+                        }
+                }
+
+                for ( FunctionDecl * dcl : newFuncs ) {
+                        FunctionType * ftype = dcl->type;
+                        assertf( ftype->parameters.size() == 1 || ftype->parameters.size() == 2, "Incorrect number of parameters in autogenerated typedecl function: %zd", ftype->parameters.size() );
+                        DeclarationWithType * dst = ftype->parameters.front();
+                        DeclarationWithType * src = ftype->parameters.size() == 2 ? ftype->parameters.back() : nullptr;
+                        // generate appropriate calls to member ctor, assignment
+                        // destructor needs to do everything in reverse, so pass "forward" based on whether the function is a destructor
+                        UntypedExpr * expr = new UntypedExpr( new NameExpr( dcl->name ) );
+                        expr->args.push_back( new CastExpr( new VariableExpr( dst ), new ReferenceType( Type::Qualifiers(), typeDecl->base->clone() ) ) );
+                        if ( src ) expr->args.push_back( new CastExpr( new VariableExpr( src ), typeDecl->base->clone() ) );
+                        dcl->statements->kids.push_back( new ExprStmt( noLabels, expr ) );
+                        if ( CodeGen::isAssignment( dcl->get_name() ) ) {
+                                // assignment needs to return a value
+                                FunctionType * assignType = dcl->type;
+                                assert( assignType->parameters.size() == 2 );
+                                ObjectDecl * srcParam = strict_dynamic_cast< ObjectDecl * >( assignType->parameters.back() );
+                                dcl->statements->kids.push_back( new ReturnStmt( noLabels, new VariableExpr( srcParam ) ) );
+                        }
+                        declsToAddAfter.push_back( dcl );
+                }
         }
 
@@ -648 +665 @@
                 visit_children = false;
                 // record the existence of this function as appropriate
-                managedTypes.handleDWT( functionDecl );
+                insert( functionDecl, constructable, InitTweak::isDefaultConstructor );
+                insert( functionDecl, assignable, InitTweak::isAssignment );
+                insert( functionDecl, copyable, InitTweak::isCopyConstructor );
+                insert( functionDecl, destructable, InitTweak::isDestructor );
 
                 maybeAccept( functionDecl->type, *visitor );
@@ -657 +677 @@
 
         void AutogenerateRoutines::previsit( CompoundStmt * ) {
-                GuardScope( managedTypes );
+                GuardScope( constructable );
+                GuardScope( assignable );
+                GuardScope( copyable );
+                GuardScope( destructable );
                 GuardScope( structsDone );
         }