Changes in src/Parser/parser.yy [3d56d15b:a1c9ddd]

File:

• src/Parser/parser.yy (modified) (15 diffs)

src/Parser/parser.yy

@@ -10 +10 @@
 // Created On       : Sat Sep  1 20:22:55 2001
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Fri Jun 22 13:59:11 2018
-// Update Count     : 3586
+// Last Modified On : Thu Jun  7 10:07:12 2018
+// Update Count     : 3527
 //
 
@@ -136 +136 @@
 } // build_postfix_name
 
-bool forall = false, xxx = false, yyy = false;                  // aggregate have one or more forall qualifiers ?
+bool forall = false, xxx = false;                                               // aggregate have one or more forall qualifiers ?
 
 // https://www.gnu.org/software/bison/manual/bison.html#Location-Type
@@ -304 +304 @@
 %type<en> enumerator_value_opt
 
-%type<decl> external_definition external_definition_list external_definition_list_opt
-
-%type<decl> exception_declaration
+%type<decl> exception_declaration external_definition external_definition_list external_definition_list_no_pop_push external_definition_list_opt
 
 %type<decl> field_declaration field_declaration_list_opt field_declarator_opt field_declaring_list
@@ -1823 +1821 @@
         ;
 
-fred:
-        // empty
-                { yyy = false; }
-        ;
-
 aggregate_type:                                                                                 // struct, union
         aggregate_key attribute_list_opt '{' field_declaration_list_opt '}'
                 { $$ = DeclarationNode::newAggregate( $1, new string( DeclarationNode::anonymous.newName() ), nullptr, $4, true )->addQualifiers( $2 ); }
-        | aggregate_key attribute_list_opt no_attr_identifier fred
+        | aggregate_key attribute_list_opt no_attr_identifier
                 {
                         typedefTable.makeTypedef( *$3, forall ? TYPEGENname : TYPEDEFname ); // create typedef
@@ -1838 +1831 @@
                 }
           '{' field_declaration_list_opt '}'
-                { $$ = DeclarationNode::newAggregate( $1, $3, nullptr, $7, true )->addQualifiers( $2 ); }
-        | aggregate_key attribute_list_opt type_name fred
+                { $$ = DeclarationNode::newAggregate( $1, $3, nullptr, $6, true )->addQualifiers( $2 ); }
+        | aggregate_key attribute_list_opt type_name
                 {
                         typedefTable.makeTypedef( *$3->type->symbolic.name, forall ? TYPEGENname : TYPEDEFname ); // create typedef
@@ -1846 +1839 @@
                 }
           '{' field_declaration_list_opt '}'
-                { $$ = DeclarationNode::newAggregate( $1, $3->type->symbolic.name, nullptr, $7, true )->addQualifiers( $2 ); }
+                { $$ = DeclarationNode::newAggregate( $1, $3->type->symbolic.name, nullptr, $6, true )->addQualifiers( $2 ); }
         | aggregate_key attribute_list_opt '(' type_list ')' '{' field_declaration_list_opt '}' // CFA
                 { $$ = DeclarationNode::newAggregate( $1, new string( DeclarationNode::anonymous.newName() ), $4, $7, false )->addQualifiers( $2 ); }
@@ -1853 +1846 @@
 
 aggregate_type_nobody:                                                                  // struct, union - {...}
-        aggregate_key attribute_list_opt no_attr_identifier fred
+        aggregate_key attribute_list_opt no_attr_identifier
                 {
                         typedefTable.makeTypedef( *$3, forall ? TYPEGENname : TYPEDEFname );
@@ -1860 +1853 @@
                         $$ = DeclarationNode::newAggregate( $1, $3, nullptr, nullptr, false )->addQualifiers( $2 );
                 }
-        | aggregate_key attribute_list_opt type_name fred
+        | aggregate_key attribute_list_opt type_name
                 {
                         // Create new generic declaration with same name as previous forward declaration, where the IDENTIFIER is
@@ -1874 +1867 @@
 aggregate_key:
         STRUCT
-                { yyy = true; $$ = DeclarationNode::Struct; }
+                { $$ = DeclarationNode::Struct; }
         | UNION
-                { yyy = true; $$ = DeclarationNode::Union; }
+                { $$ = DeclarationNode::Union; }
         | EXCEPTION
-                { yyy = true; $$ = DeclarationNode::Exception; }
+                { $$ = DeclarationNode::Exception; }
         | COROUTINE
-                { yyy = true; $$ = DeclarationNode::Coroutine; }
+                { $$ = DeclarationNode::Coroutine; }
         | MONITOR
-                { yyy = true; $$ = DeclarationNode::Monitor; }
+                { $$ = DeclarationNode::Monitor; }
         | THREAD
-                { yyy = true; $$ = DeclarationNode::Thread; }
+                { $$ = DeclarationNode::Thread; }
         ;
 
@@ -2329 +2322 @@
 
 translation_unit:
-        // empty, input file
+        // empty
+                {}                                                                                              // empty input file
         | external_definition_list
                 { parseTree = parseTree ? parseTree->appendList( $1 ) : $1;     }
@@ -2343 +2337 @@
         ;
 
+        // SKULLDUGGERY: Declarations in extern "X" and distribution need to be added to the current lexical scope.
+        // However, external_definition_list creates a new scope around each external_definition, but the pop loses all the
+        // types in the extern "X" and distribution at the end of the block. This version of external_definition_list does
+
+        // not do push/pop for declarations at the level of the extern "X" and distribution block. Any recursive uses of
+        // external_definition_list within the extern "X" and distribution block correctly pushes/pops for that scope level.
+external_definition_list_no_pop_push:
+        external_definition
+        | external_definition_list_no_pop_push
+                { forall = xxx; }
+          external_definition
+                { $$ = $1 ? $1->appendList( $3 ) : $3; }
+        ;
+
 external_definition_list_opt:
         // empty
                 { $$ = nullptr; }
-        | external_definition_list
-        ;
-
-up:
-                { typedefTable.up(); }
-        ;
-
-down:
-                { typedefTable.down(); }
+        | external_definition_list_no_pop_push
         ;
 
@@ -2374 +2374 @@
                         linkage = LinkageSpec::linkageUpdate( yylloc, linkage, $2 );
                 }
-          '{' up external_definition_list_opt down '}'
+          '{' external_definition_list_opt '}'
                 {
                         linkage = linkageStack.top();
                         linkageStack.pop();
-                        $$ = $6;
+                        $$ = $5;
                 }
         | type_qualifier_list
-                {
-                        if ( $1->type->qualifiers.val ) { SemanticError( yylloc, "CV qualifiers cannot be distributed; only storage-class and forall qualifiers." ); }
-                        if ( $1->type->forall ) xxx = forall = true; // remember generic type
-                }
-          '{' up external_definition_list_opt down '}'          // CFA, namespace
-                {
-                        for ( DeclarationNode * iter = $5; iter != nullptr; iter = (DeclarationNode *)iter->get_next() ) {
+                { if ( $1->type->forall ) xxx = forall = true; } // remember generic type
+          '{' external_definition_list_opt '}'                          // CFA, namespace
+                {
+                        for ( DeclarationNode * iter = $4; iter != nullptr; iter = (DeclarationNode *)iter->get_next() ) {
                                 if ( isMangled( iter->linkage ) ) {             // ignore extern "C"
                                         iter->addQualifiers( $1->clone() );
@@ -2394 +2391 @@
                         xxx = false;
                         delete $1;
-                        $$ = $5;
+                        $$ = $4;
                 }
         | declaration_qualifier_list
-                {
-                        if ( $1->type->qualifiers.val ) { SemanticError( yylloc, "CV qualifiers cannot be distributed; only storage-class and forall qualifiers." ); }
-                        if ( $1->type->forall ) xxx = forall = true; // remember generic type
-                }
-          '{' up external_definition_list_opt down '}'          // CFA, namespace
-                {
-                        for ( DeclarationNode * iter = $5; iter != nullptr; iter = (DeclarationNode *)iter->get_next() ) {
+                { if ( $1->type->forall ) xxx = forall = true; } // remember generic type
+          '{' external_definition_list_opt '}'                          // CFA, namespace
+                {
+                        for ( DeclarationNode * iter = $4; iter != nullptr; iter = (DeclarationNode *)iter->get_next() ) {
                                 if ( isMangled( iter->linkage ) ) {             // ignore extern "C"
                                         iter->addQualifiers( $1->clone() );
@@ -2410 +2404 @@
                         xxx = false;
                         delete $1;
-                        $$ = $5;
+                        $$ = $4;
                 }
         | declaration_qualifier_list type_qualifier_list
                 {
-                        if ( ($1->type && $1->type->qualifiers.val) || $2->type->qualifiers.val ) { SemanticError( yylloc, "CV qualifiers cannot be distributed; only storage-class and forall qualifiers." ); }
-                        if ( ($1->type && $1->type->forall) || $2->type->forall ) xxx = forall = true; // remember generic type
-                }
-          '{' up external_definition_list_opt down '}'          // CFA, namespace
-                {
-                        for ( DeclarationNode * iter = $6; iter != nullptr; iter = (DeclarationNode *)iter->get_next() ) {
+                        // forall must be in the type_qualifier_list
+                        if ( $2->type->forall ) xxx = forall = true; // remember generic type
+                }
+          '{' external_definition_list_opt '}'                          // CFA, namespace
+                {
+                        for ( DeclarationNode * iter = $5; iter != nullptr; iter = (DeclarationNode *)iter->get_next() ) {
                                 if ( isMangled( iter->linkage ) && isMangled( $2->linkage ) ) { // ignore extern "C"
                                         iter->addQualifiers( $1->clone() );
@@ -2428 +2422 @@
                         delete $1;
                         delete $2;
-                        $$ = $6;
+                        $$ = $5;
                 }
         ;