Changeset a165495

Timestamp:

Feb 7, 2026, 1:40:26 PM (9 hours ago)

Author:

Matthew Au-Yeung <mw2auyeu@…>

Branches:

stuck-waitfor-destruct

Children:

c7d106a

Parents:

3151bc09

git-author:

Matthew Au-Yeung <mw2auyeu@…> (01/27/26 19:12:37)

git-committer:

Matthew Au-Yeung <mw2auyeu@…> (02/07/26 13:40:26)

Message:

Make generated thread destructor link once instead of inline

• waitfor context switch depends on fn pointers which will differ inline

File:

• src/Validate/Autogen.cpp (modified) (1 diff)

src/Validate/Autogen.cpp

@@ -401 +401 @@
                 add_qualifiers( dst->type, ast::CV::Qualifiers( ast::CV::Mutex ) );
         }
-        return genProto( "^?{}", { dst }, {} );
+
+        ast::FunctionDecl * decl = genProto( "^?{}", { dst }, {} );
+        // For concurrent types, remove static storage and inline specifier, and add
+        // cfa_linkonce attribute so the destructor has external linkage with linkonce
+        // semantics. This is required for waitfor to work correctly across translation
+        // units - the function pointer must be the same everywhere, and cfa_linkonce
+        // ensures only one definition survives linking.
+        if ( isConcurrentType() ) {
+                auto mut = ast::mutate( decl );
+                mut->storage = ast::Storage::Classes();
+                mut->funcSpec = ast::Function::Specs();
+                mut->attributes.push_back( new ast::Attribute( "cfa_linkonce" ) );
+        }
+        return decl;
 }