Changes in src/Validate/ForallPointerDecay.cpp [14c0f7b:9feb34b]

File:

• src/Validate/ForallPointerDecay.cpp (modified) (9 diffs)

src/Validate/ForallPointerDecay.cpp

@@ -23 +23 @@
 #include "Common/CodeLocation.h"
 #include "Common/ToString.hpp"
-#include "Common/utility.h"
 #include "SymTab/FixFunction.h"
+
+#include "AST/Print.hpp"
 
 namespace Validate {
@@ -50 +51 @@
 }
 
-ast::FunctionDecl * updateAssertions( ast::FunctionDecl * decl ) {
-        auto type = ast::mutate( decl->type.get() );
-        type->assertions.clear();
-        type->assertions.reserve( decl->assertions.size() );
-        for ( auto & assertion : decl->assertions ) {
-                type->assertions.emplace_back(
-                        new ast::VariableExpr( decl->location, assertion ) );
-        }
-        decl->type = type;
-        return decl;
+template<typename T>
+void append( std::vector<T> & dst, std::vector<T> & src ) {
+        dst.reserve( dst.size() + src.size() );
+        for ( auto el : src ) {
+                dst.emplace_back( std::move( el ) );
+        }
+        src.clear();
 }
 
@@ -98 +96 @@
                                         decl->get_type() ) ) {
                                 auto moreAsserts = expandTrait( traitInst );
-                                splice( assertions, moreAsserts );
+                                append( assertions, moreAsserts );
                         } else {
                                 assertions.push_back( decl );
@@ -110 +108 @@
         static TypeDeclVec expandTypeDecls( const TypeDeclVec & old ) {
                 TypeDeclVec typeDecls;
-                typeDecls.reserve( old.size() );
                 for ( const ast::TypeDecl * typeDecl : old ) {
                         typeDecls.push_back( ast::mutate_field( typeDecl,
@@ -126 +123 @@
                 mut->assertions = expandAssertions( decl->assertions );
                 // Update the assertion list on the type as well.
-                return updateAssertions( mut );
+                auto mutType = ast::mutate( mut->type.get() );
+                mutType->assertions.clear();
+                for ( auto & assertion : mut->assertions ) {
+                        mutType->assertions.emplace_back(
+                                new ast::VariableExpr( mut->location, assertion ) );
+                }
+                mut->type = mutType;
+                return mut;
         }
 
@@ -150 +154 @@
                 const std::vector<ast::ptr<ast::DeclWithType>> & assertions ) {
         std::vector<ast::ptr<ast::DeclWithType>> ret;
-        ret.reserve( assertions.size() );
         for ( const auto & assn : assertions ) {
                 bool isVoid = false;
@@ -184 +187 @@
         }
 
-        const ast::FunctionDecl * postvisit( const ast::FunctionDecl * decl ) {
-                if ( decl->assertions.empty() ) {
-                        return decl;
-                }
-                return updateAssertions( mutate( decl ) );
-        }
-
         const ast::StructDecl * previsit( const ast::StructDecl * decl ) {
                 if ( decl->params.empty() ) {
@@ -208 +204 @@
 };
 
-struct OperatorChecker final {
+struct OberatorChecker final {
         void previsit( const ast::ObjectDecl * obj ) {
-                if ( !CodeGen::isOperator( obj->name ) ) return;
-                auto type = obj->type->stripDeclarator();
-                if ( dynamic_cast< const ast::FunctionType * >( type ) ) return;
-                SemanticError( obj->location,
-                        toCString( "operator ", obj->name.c_str(),
-                        " is not a function or function pointer." ) );
+                if ( CodeGen::isOperator( obj->name ) ) {
+                        auto type = obj->type->stripDeclarator();
+                        if ( ! dynamic_cast< const ast::FunctionType * >( type ) ) {
+                                SemanticError( obj->location,
+                                        toCString( "operator ", obj->name.c_str(), " is not "
+                                        "a function or function pointer." ) );
+                        }
+                }
         }
 };
@@ -236 +234 @@
         ast::Pass<TraitExpander>::run( transUnit );
         ast::Pass<AssertionFunctionFixer>::run( transUnit );
-        ast::Pass<OperatorChecker>::run( transUnit );
-}
-
-void fixUniqueIds( ast::TranslationUnit & transUnit ) {
+        ast::Pass<OberatorChecker>::run( transUnit );
         ast::Pass<UniqueFixCore>::run( transUnit );
 }