Changes in src/ResolvExpr/CastCost.cc [543159b:9fd97126]

File:

• src/ResolvExpr/CastCost.cc (modified) (4 diffs)

src/ResolvExpr/CastCost.cc

@@ -10 +10 @@
 // Created On       : Sun May 17 06:57:43 2015
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Sun May 17 06:59:10 2015
-// Update Count     : 2
+// Last Modified On : Tue Feb  2 15:34:36 2016
+// Update Count     : 7
 //
 
@@ -56 +56 @@
                                 return Cost::infinity;
                         } else {
+                                // xxx - why are we adding cost 0 here?
                                 return converter.get_cost() + Cost( 0, 0, 0 );
                         } // if
@@ -68 +69 @@
                 PointerType *destAsPointer = dynamic_cast< PointerType* >( dest );
                 if ( destAsPointer && basicType->isInteger() ) {
+                        // necessary for, e.g. unsigned long => void*
                         cost = Cost( 1, 0, 0 );
                 } else {
@@ -82 +84 @@
                                 newEnv.add( pointerType->get_forall() );
                                 newEnv.add( pointerType->get_base()->get_forall() );
-                                int assignResult = ptrsCastable( pointerType->get_base(), destAsPtr->get_base(), newEnv, indexer );
-                                if ( assignResult > 0 ) {
+                                int castResult = ptrsCastable( pointerType->get_base(), destAsPtr->get_base(), newEnv, indexer );
+                                if ( castResult > 0 ) {
                                         cost = Cost( 0, 0, 1 );
-                                } else if ( assignResult < 0 ) {
-                                        cost = Cost( 1, 0, 0 );
+                                } else if ( castResult < 0 ) {
+                                        cost = Cost::infinity;
                                 } // if
                         } // if
                 } else if ( BasicType *destAsBasic = dynamic_cast< BasicType* >( dest ) ) {
                         if ( destAsBasic->isInteger() ) {
+                                // necessary for, e.g. void* => unsigned long
                                 cost = Cost( 1, 0, 0 );
                         } // if