Changes in src/ResolvExpr/ConversionCost.cc [5af7306:98278b3a]

File:

• src/ResolvExpr/ConversionCost.cc (modified) (4 diffs)

src/ResolvExpr/ConversionCost.cc

@@ -20 +20 @@
 #include <string>                        // for operator==, string
 
-#include "Common/GC.h"                   // for new_static_root
 #include "ResolvExpr/Cost.h"             // for Cost
 #include "ResolvExpr/TypeEnvironment.h"  // for EqvClass, TypeEnvironment
@@ -276 +275 @@
                         // xxx - not positive this is correct, but appears to allow casting int => enum
                         cost = Cost::unsafe;
-                } else if ( dynamic_cast< ZeroType* >( dest ) != nullptr || dynamic_cast< OneType* >( dest ) != nullptr ) {
-                        cost = Cost::unsafe;
-                } // if
+                } // if
+                // no cases for zero_t/one_t because it should not be possible to convert int, etc. to zero_t/one_t.
         }
 
@@ -310 +308 @@
                                 // assignResult == 0 means Cost::Infinity
                         } // if
-                } else if ( dynamic_cast< ZeroType * >( dest ) ) {
-                        cost = Cost::unsafe;
+                        // case case for zero_t because it should not be possible to convert pointers to zero_t.
                 } // if
         }
@@ -354 +351 @@
         void ConversionCost::postvisit( EnumInstType * ) {
                 static Type::Qualifiers q;
-                static BasicType* integer = new_static_root<BasicType>( q, BasicType::SignedInt );
-                cost = costFunc( integer, dest, indexer, env );  // safe if dest >= int
+                static BasicType integer( q, BasicType::SignedInt );
+                cost = costFunc( &integer, dest, indexer, env );  // safe if dest >= int
                 if ( cost < Cost::unsafe ) {
                         cost.incSafe();