Changes in libcfa/src/bits/locks.hfa [6ec07e5:92e7631]

File:

• libcfa/src/bits/locks.hfa (modified) (1 diff)

libcfa/src/bits/locks.hfa

@@ -112 +112 @@
         #endif
 
-        extern "C" {
-                char * strerror(int);
-        }
-        #define CHECKED(x) { int err = x; if( err != 0 ) abort("KERNEL ERROR: Operation \"" #x "\" return error %d - %s\n", err, strerror(err)); }
-
         struct __bin_sem_t {
+                bool                    signaled;
                 pthread_mutex_t         lock;
                 pthread_cond_t          cond;
-                int                     val;
         };
 
         static inline void ?{}(__bin_sem_t & this) with( this ) {
-                // Create the mutex with error checking
-                pthread_mutexattr_t mattr;
-                pthread_mutexattr_init( &mattr );
-                pthread_mutexattr_settype( &mattr, PTHREAD_MUTEX_ERRORCHECK_NP);
-                pthread_mutex_init(&lock, &mattr);
-
-                pthread_cond_init (&cond, 0p);
-                val = 0;
+                signaled = false;
+                pthread_mutex_init(&lock, NULL);
+                pthread_cond_init (&cond, NULL);
         }
 
         static inline void ^?{}(__bin_sem_t & this) with( this ) {
-                CHECKED( pthread_mutex_destroy(&lock) );
-                CHECKED( pthread_cond_destroy (&cond) );
+                pthread_mutex_destroy(&lock);
+                pthread_cond_destroy (&cond);
         }
 
         static inline void wait(__bin_sem_t & this) with( this ) {
                 verify(__cfaabi_dbg_in_kernel());
-                CHECKED( pthread_mutex_lock(&lock) );
-                        while(val < 1) {
+                pthread_mutex_lock(&lock);
+                        if(!signaled) {   // this must be a loop, not if!
                                 pthread_cond_wait(&cond, &lock);
                         }
-                        val -= 1;
-                CHECKED( pthread_mutex_unlock(&lock) );
+                        signaled = false;
+                pthread_mutex_unlock(&lock);
         }
 
         static inline bool post(__bin_sem_t & this) with( this ) {
-                bool needs_signal = false;
+                pthread_mutex_lock(&lock);
+                        bool needs_signal = !signaled;
+                        signaled = true;
+                pthread_mutex_unlock(&lock);
 
-                CHECKED( pthread_mutex_lock(&lock) );
-                        if(val < 1) {
-                                val += 1;
-                                pthread_cond_signal(&cond);
-                                needs_signal = true;
-                        }
-                CHECKED( pthread_mutex_unlock(&lock) );
+                if (needs_signal) pthread_cond_signal(&cond);
 
                 return needs_signal;
         }
-
-        #undef CHECKED
 #endif