Changes in libcfa/src/bits/locks.hfa [4069faad:92e7631]

File:

• libcfa/src/bits/locks.hfa (modified) (2 diffs)

libcfa/src/bits/locks.hfa

@@ -113 +113 @@
 
         struct __bin_sem_t {
+                bool                    signaled;
                 pthread_mutex_t         lock;
                 pthread_cond_t          cond;
-                int                     val;
         };
 
         static inline void ?{}(__bin_sem_t & this) with( this ) {
+                signaled = false;
                 pthread_mutex_init(&lock, NULL);
                 pthread_cond_init (&cond, NULL);
-                val = 0;
         }
 
@@ -132 +132 @@
                 verify(__cfaabi_dbg_in_kernel());
                 pthread_mutex_lock(&lock);
-                        while(val < 1) {
+                        if(!signaled) {   // this must be a loop, not if!
                                 pthread_cond_wait(&cond, &lock);
                         }
-                        val -= 1;
+                        signaled = false;
                 pthread_mutex_unlock(&lock);
         }
 
         static inline bool post(__bin_sem_t & this) with( this ) {
-                bool needs_signal = false;
+                pthread_mutex_lock(&lock);
+                        bool needs_signal = !signaled;
+                        signaled = true;
+                pthread_mutex_unlock(&lock);
 
-                pthread_mutex_lock(&lock);
-                        if(val < 1) {
-                                val += 1;
-                                pthread_cond_signal(&cond);
-                                needs_signal = true;
-                        }
-                pthread_mutex_unlock(&lock);
+                if (needs_signal) pthread_cond_signal(&cond);
 
                 return needs_signal;