Changes in / [305581d:90152a4]
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
libcfa/prelude/builtins.c
r305581d r90152a4 111 111 static inline unsigned int ?\=?( unsigned int & x, unsigned long int y ) { x = x \ y; return x; } 112 112 113 // type that wraps a pointer and a destructor-like function - used in generating implicit destructor calls for struct members in user-defined functions 114 forall(dtype T) 115 struct __Destructor { 116 T * object; 117 void (*dtor)(T *); 118 }; 119 120 // defined destructor in the case that non-generated code wants to use __Destructor 121 forall(dtype T) 122 static inline void ^?{}(__Destructor(T) & x) { 123 x.dtor(x.object); 124 } 125 126 // easy interface into __Destructor's destructor for easy codegen purposes 127 extern "C" { 128 forall(dtype T) 129 static inline void __destroy_Destructor(__Destructor(T) * dtor) { 130 ^(*dtor){}; 131 } 132 } 133 113 134 // Local Variables: // 114 135 // mode: c // -
src/ControlStruct/ExceptTranslate.cc
r305581d r90152a4 319 319 } 320 320 321 block->push_back( handler-> get_body());322 handler-> set_body( nullptr );321 block->push_back( handler->body ); 322 handler->body = nullptr; 323 323 324 324 std::list<Statement *> caseBody -
src/InitTweak/FixInit.cc
r305581d r90152a4 54 54 #include "SynTree/Type.h" // for Type, Type::StorageClasses 55 55 #include "SynTree/TypeSubstitution.h" // for TypeSubstitution, operator<< 56 #include "SynTree/DeclReplacer.h" // for DeclReplacer 56 57 #include "SynTree/Visitor.h" // for acceptAll, maybeAccept 57 58 … … 162 163 using Parent::previsit; 163 164 164 void previsit( ObjectDecl * objDecl );165 165 void previsit( FunctionDecl * funcDecl ); 166 166 167 void previsit( CompoundStmt * compoundStmt );168 void postvisit( CompoundStmt * compoundStmt );169 void previsit( ReturnStmt * returnStmt );170 167 void previsit( BranchStmt * stmt ); 171 168 private: … … 207 204 static void generate( std::list< Declaration * > & translationUnit ); 208 205 206 void premutate( StructDecl * structDecl ); 207 209 208 void premutate( FunctionDecl * funcDecl ); 210 209 DeclarationWithType * postmutate( FunctionDecl * funcDecl ); … … 228 227 bool isCtor = false; // true if current function is a constructor 229 228 StructDecl * structDecl = nullptr; 229 230 // special built-in functions necessary for this to work 231 StructDecl * dtorStruct = nullptr; 232 FunctionDecl * dtorStructDestroy = nullptr; 230 233 }; 231 234 … … 732 735 } 733 736 737 DeclarationWithType * getDtorFunc( ObjectDecl * objDecl, Statement * input, std::list< Statement * > & stmtsToAdd ) { 738 // unwrap implicit statement wrapper 739 Statement * dtor = input; 740 if ( ImplicitCtorDtorStmt * implicit = dynamic_cast< ImplicitCtorDtorStmt * >( input ) ) { 741 // dtor = implicit->callStmt; 742 // implicit->callStmt = nullptr; 743 } 744 assert( dtor ); 745 std::list< Expression * > matches; 746 collectCtorDtorCalls( dtor, matches ); 747 748 if ( dynamic_cast< ExprStmt * >( dtor ) ) { 749 // only one destructor call in the expression 750 if ( matches.size() == 1 ) { 751 DeclarationWithType * func = getFunction( matches.front() ); 752 assertf( func, "getFunction failed to find function in %s", toString( matches.front() ).c_str() ); 753 754 // cleanup argument must be a function, not an object (including function pointer) 755 if ( FunctionDecl * dtorFunc = dynamic_cast< FunctionDecl * > ( func ) ) { 756 if ( dtorFunc->type->forall.empty() ) { 757 // simple case where the destructor is a monomorphic function call - can simply 758 // use that function as the cleanup function. 759 delete dtor; 760 return func; 761 } 762 } 763 } 764 } 765 766 // otherwise the cleanup is more complicated - need to build a single argument cleanup function that 767 // wraps the more complicated code. 768 static UniqueName dtorNamer( "__cleanup_dtor" ); 769 FunctionDecl * dtorFunc = FunctionDecl::newFunction( dtorNamer.newName(), SymTab::genDefaultType( objDecl->type->stripReferences(), false ), new CompoundStmt() ); 770 stmtsToAdd.push_back( new DeclStmt( dtorFunc ) ); 771 772 // the original code contains uses of objDecl - replace them with the newly generated 'this' parameter. 773 ObjectDecl * thisParam = getParamThis( dtorFunc->type ); 774 Expression * replacement = new VariableExpr( thisParam ); 775 776 Type * base = replacement->result->stripReferences(); 777 if ( dynamic_cast< ArrayType * >( base ) || dynamic_cast< TupleType * > ( base ) ) { 778 // need to cast away reference for array types, since the destructor is generated without the reference type, 779 // and for tuple types since tuple indexing does not work directly on a reference 780 replacement = new CastExpr( replacement, base->clone() ); 781 } 782 DeclReplacer::replace( dtor, { std::make_pair( objDecl, replacement ) } ); 783 dtorFunc->statements->push_back( strict_dynamic_cast<Statement *>( dtor ) ); 784 785 return dtorFunc; 786 } 787 734 788 DeclarationWithType * FixInit::postmutate( ObjectDecl *objDecl ) { 735 789 // since this removes the init field from objDecl, it must occur after children are mutated (i.e. postmutate) … … 844 898 ctorInit->ctor = nullptr; 845 899 } 900 901 Statement * dtor = ctorInit->dtor; 902 if ( dtor ) { 903 ImplicitCtorDtorStmt * implicit = strict_dynamic_cast< ImplicitCtorDtorStmt * >( dtor ); 904 Statement * dtorStmt = implicit->callStmt; 905 906 // don't need to call intrinsic dtor, because it does nothing, but 907 // non-intrinsic dtors must be called 908 if ( ! isIntrinsicSingleArgCallStmt( dtorStmt ) ) { 909 // set dtor location to the object's location for error messages 910 DeclarationWithType * dtorFunc = getDtorFunc( objDecl, dtorStmt, stmtsToAddBefore ); 911 objDecl->attributes.push_back( new Attribute( "cleanup", { new VariableExpr( dtorFunc ) } ) ); 912 ctorInit->dtor = nullptr; 913 } // if 914 } 846 915 } // if 847 916 } else if ( Initializer * init = ctorInit->init ) { … … 886 955 887 956 888 template<typename Iterator, typename OutputIterator>889 void insertDtors( Iterator begin, Iterator end, OutputIterator out ) {890 for ( Iterator it = begin ; it != end ; ++it ) {891 // extract destructor statement from the object decl and insert it into the output. Note that this is892 // only called on lists of non-static objects with implicit non-intrinsic dtors, so if the user manually893 // calls an intrinsic dtor then the call must (and will) still be generated since the argument may894 // contain side effects.895 ObjectDecl * objDecl = *it;896 ConstructorInit * ctorInit = dynamic_cast< ConstructorInit * >( objDecl->get_init() );897 assert( ctorInit && ctorInit->get_dtor() );898 *out++ = ctorInit->get_dtor()->clone();899 } // for900 }901 902 void InsertDtors::previsit( ObjectDecl * objDecl ) {903 // remember non-static destructed objects so that their destructors can be inserted later904 if ( ! objDecl->get_storageClasses().is_static ) {905 if ( ConstructorInit * ctorInit = dynamic_cast< ConstructorInit * >( objDecl->get_init() ) ) {906 // a decision should have been made by the resolver, so ctor and init are not both non-NULL907 assert( ! ctorInit->get_ctor() || ! ctorInit->get_init() );908 Statement * dtor = ctorInit->get_dtor();909 // don't need to call intrinsic dtor, because it does nothing, but910 // non-intrinsic dtors must be called911 if ( dtor && ! isIntrinsicSingleArgCallStmt( dtor ) ) {912 // set dtor location to the object's location for error messages913 ctorInit->dtor->location = objDecl->location;914 reverseDeclOrder.front().push_front( objDecl );915 } // if916 } // if917 } // if918 }919 920 957 void InsertDtors::previsit( FunctionDecl * funcDecl ) { 921 958 // each function needs to have its own set of labels … … 930 967 } 931 968 932 void InsertDtors::previsit( CompoundStmt * compoundStmt ) {933 // visit statements - this will also populate reverseDeclOrder list. don't want to dump all destructors934 // when block is left, just the destructors associated with variables defined in this block, so push a new935 // list to the top of the stack so that we can differentiate scopes936 reverseDeclOrder.push_front( OrderedDecls() );937 Parent::previsit( compoundStmt );938 }939 940 void InsertDtors::postvisit( CompoundStmt * compoundStmt ) {941 // add destructors for the current scope that we're exiting, unless the last statement is a return, which942 // causes unreachable code warnings943 std::list< Statement * > & statements = compoundStmt->get_kids();944 if ( ! statements.empty() && ! dynamic_cast< ReturnStmt * >( statements.back() ) ) {945 insertDtors( reverseDeclOrder.front().begin(), reverseDeclOrder.front().end(), back_inserter( statements ) );946 }947 reverseDeclOrder.pop_front();948 }949 950 void InsertDtors::previsit( ReturnStmt * ) {951 // return exits all scopes, so dump destructors for all scopes952 for ( OrderedDecls & od : reverseDeclOrder ) {953 insertDtors( od.begin(), od.end(), back_inserter( stmtsToAddBefore ) );954 } // for955 }956 957 969 // Handle break/continue/goto in the same manner as C++. Basic idea: any objects that are in scope at the 958 970 // BranchStmt but not at the labelled (target) statement must be destructed. If there are any objects in scope … … 982 994 if ( ! diff.empty() ) { 983 995 SemanticError( stmt, std::string("jump to label '") + stmt->get_target().get_name() + "' crosses initialization of " + (*diff.begin())->get_name() + " " ); 984 } // if985 // S_G-S_L results in set of objects that must be destructed986 diff.clear();987 std::set_difference( curVars.begin(), curVars.end(), lvars.begin(), lvars.end(), std::inserter( diff, diff.end() ) );988 DTOR_PRINT(989 std::cerr << "S_G-S_L = " << printSet( diff ) << std::endl;990 )991 if ( ! diff.empty() ) {992 // create an auxilliary set for fast lookup -- can't make diff a set, because diff ordering should be consistent for error messages.993 std::unordered_set<ObjectDecl *> needsDestructor( diff.begin(), diff.end() );994 995 // go through decl ordered list of objectdecl. for each element that occurs in diff, output destructor996 OrderedDecls ordered;997 for ( OrderedDecls & rdo : reverseDeclOrder ) {998 // add elements from reverseDeclOrder into ordered if they occur in diff - it is key that this happens in reverse declaration order.999 copy_if( rdo.begin(), rdo.end(), back_inserter( ordered ), [&]( ObjectDecl * objDecl ) { return needsDestructor.count( objDecl ); } );1000 } // for1001 insertDtors( ordered.begin(), ordered.end(), back_inserter( stmtsToAddBefore ) );1002 996 } // if 1003 997 } … … 1025 1019 } 1026 1020 1021 void GenStructMemberCalls::premutate( StructDecl * structDecl ) { 1022 if ( ! dtorStruct && structDecl->name == "__Destructor" ) { 1023 dtorStruct = structDecl; 1024 } 1025 } 1026 1027 1027 void GenStructMemberCalls::premutate( FunctionDecl * funcDecl ) { 1028 1028 GuardValue( function ); … … 1037 1037 unhandled.clear(); 1038 1038 usedUninit.clear(); 1039 1040 if ( ! dtorStructDestroy && funcDecl->name == "__destroy_Destructor" ) { 1041 dtorStructDestroy = funcDecl; 1042 return; 1043 } 1039 1044 1040 1045 function = funcDecl; … … 1048 1053 if ( structType ) { 1049 1054 structDecl = structType->get_baseStruct(); 1055 if ( structDecl == dtorStruct ) return; 1050 1056 for ( Declaration * member : structDecl->get_members() ) { 1051 1057 if ( ObjectDecl * field = dynamic_cast< ObjectDecl * >( member ) ) { … … 1116 1122 callStmt->acceptMutator( *visitor ); 1117 1123 if ( isCtor ) { 1118 function-> get_statements()->push_front( callStmt );1124 function->statements->push_front( callStmt ); 1119 1125 } else { 1120 1126 // destructor statements should be added at the end 1121 function->get_statements()->push_back( callStmt ); 1127 // function->get_statements()->push_back( callStmt ); 1128 1129 // Destructor _dtor0 = { &b.a1, (void (*)(void *)_destroy_A }; 1130 std::list< Statement * > stmtsToAdd; 1131 1132 static UniqueName memberDtorNamer = { "__memberDtor" }; 1133 assertf( dtorStruct, "builtin __Destructor not found." ); 1134 assertf( dtorStructDestroy, "builtin __destroy_Destructor not found." ); 1135 1136 Expression * thisExpr = new AddressExpr( new VariableExpr( thisParam ) ); 1137 Expression * dtorExpr = new VariableExpr( getDtorFunc( thisParam, callStmt, stmtsToAdd ) ); 1138 1139 // cast destructor pointer to void (*)(void *), to silence GCC incompatible pointer warnings 1140 FunctionType * dtorFtype = new FunctionType( Type::Qualifiers(), false ); 1141 dtorFtype->parameters.push_back( ObjectDecl::newObject( "", new PointerType( Type::Qualifiers(), new VoidType( Type::Qualifiers() ) ), nullptr ) ); 1142 Type * dtorType = new PointerType( Type::Qualifiers(), dtorFtype ); 1143 1144 ObjectDecl * destructor = ObjectDecl::newObject( memberDtorNamer.newName(), new StructInstType( Type::Qualifiers(), dtorStruct ), new ListInit( { new SingleInit( thisExpr ), new SingleInit( new CastExpr( dtorExpr, dtorType ) ) } ) ); 1145 function->statements->push_front( new DeclStmt( destructor ) ); 1146 destructor->attributes.push_back( new Attribute( "cleanup", { new VariableExpr( dtorStructDestroy ) } ) ); 1147 1148 function->statements->kids.splice( function->statements->kids.begin(), stmtsToAdd ); 1122 1149 } 1123 1150 } catch ( SemanticErrorException & error ) { -
src/InitTweak/InitTweak.cc
r305581d r90152a4 339 339 std::list< Expression * > matches; 340 340 collectCtorDtorCalls( stmt, matches ); 341 assert ( matches.size() <= 1);341 assertf( matches.size() <= 1, "%zd constructor/destructors found in %s", matches.size(), toString( stmt ).c_str() ); 342 342 return matches.size() == 1 ? matches.front() : nullptr; 343 343 } -
src/SymTab/Autogen.cc
r305581d r90152a4 45 45 /// Data used to generate functions generically. Specifically, the name of the generated function and a function which generates the routine protoype 46 46 struct FuncData { 47 typedef FunctionType * (*TypeGen)( Type * );47 typedef FunctionType * (*TypeGen)( Type *, bool ); 48 48 FuncData( const std::string & fname, const TypeGen & genType ) : fname( fname ), genType( genType ) {} 49 49 std::string fname; … … 231 231 232 232 /// given type T, generate type of default ctor/dtor, i.e. function type void (*) (T *) 233 FunctionType * genDefaultType( Type * paramType ) { 234 const auto & typeParams = getGenericParams( paramType ); 233 FunctionType * genDefaultType( Type * paramType, bool maybePolymorphic ) { 235 234 FunctionType *ftype = new FunctionType( Type::Qualifiers(), false ); 236 cloneAll( typeParams, ftype->forall ); 235 if ( maybePolymorphic ) { 236 // only copy in 237 const auto & typeParams = getGenericParams( paramType ); 238 cloneAll( typeParams, ftype->forall ); 239 } 237 240 ObjectDecl *dstParam = new ObjectDecl( "_dst", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, new ReferenceType( Type::Qualifiers(), paramType->clone() ), nullptr ); 238 241 ftype->parameters.push_back( dstParam ); … … 241 244 242 245 /// given type T, generate type of copy ctor, i.e. function type void (*) (T *, T) 243 FunctionType * genCopyType( Type * paramType ) {244 FunctionType *ftype = genDefaultType( paramType );246 FunctionType * genCopyType( Type * paramType, bool maybePolymorphic ) { 247 FunctionType *ftype = genDefaultType( paramType, maybePolymorphic ); 245 248 ObjectDecl *srcParam = new ObjectDecl( "_src", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType->clone(), nullptr ); 246 249 ftype->parameters.push_back( srcParam ); … … 249 252 250 253 /// given type T, generate type of assignment, i.e. function type T (*) (T *, T) 251 FunctionType * genAssignType( Type * paramType ) {252 FunctionType *ftype = genCopyType( paramType );254 FunctionType * genAssignType( Type * paramType, bool maybePolymorphic ) { 255 FunctionType *ftype = genCopyType( paramType, maybePolymorphic ); 253 256 ObjectDecl *returnVal = new ObjectDecl( "_ret", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType->clone(), nullptr ); 254 257 ftype->returnVals.push_back( returnVal ); … … 308 311 for ( const FuncData & d : data ) { 309 312 // generate a function (?{}, ?=?, ^?{}) based on the current FuncData. 310 FunctionType * ftype = d.genType( type );313 FunctionType * ftype = d.genType( type, true ); 311 314 312 315 // destructor for concurrent type must be mutex -
src/SymTab/Autogen.h
r305581d r90152a4 45 45 extern FunctionDecl * dereferenceOperator; 46 46 47 // generate the type of an assignment function for paramType 48 FunctionType * genAssignType( Type * paramType ); 49 50 // generate the type of a default constructor or destructor for paramType 51 FunctionType * genDefaultType( Type * paramType ); 52 53 // generate the type of a copy constructor for paramType 54 FunctionType * genCopyType( Type * paramType ); 47 /// generate the type of an assignment function for paramType. 48 /// maybePolymorphic is true if the resulting FunctionType is allowed to be polymorphic 49 FunctionType * genAssignType( Type * paramType, bool maybePolymorphic = true ); 50 51 /// generate the type of a default constructor or destructor for paramType. 52 /// maybePolymorphic is true if the resulting FunctionType is allowed to be polymorphic 53 FunctionType * genDefaultType( Type * paramType, bool maybePolymorphic = true ); 54 55 /// generate the type of a copy constructor for paramType. 56 /// maybePolymorphic is true if the resulting FunctionType is allowed to be polymorphic 57 FunctionType * genCopyType( Type * paramType, bool maybePolymorphic = true ); 55 58 56 59 /// inserts into out a generated call expression to function fname with arguments dstParam and srcParam. Intended to be used with generated ?=?, ?{}, and ^?{} calls. -
src/SynTree/DeclReplacer.cc
r305581d r90152a4 38 38 void previsit( TypeInstType * inst ); 39 39 }; 40 41 /// Mutator that replaces uses of declarations with arbitrary expressions, according to the supplied mapping 42 struct ExprDeclReplacer { 43 private: 44 const ExprMap & exprMap; 45 bool debug; 46 public: 47 ExprDeclReplacer( const ExprMap & exprMap, bool debug = false ); 48 49 // replace variable with new node from expr map 50 Expression * postmutate( VariableExpr * varExpr ); 51 }; 40 52 } 41 53 … … 53 65 DeclMap declMap; 54 66 replace( node, declMap, typeMap, debug ); 67 } 68 69 void replace( BaseSyntaxNode *& node, const ExprMap & exprMap, bool debug ) { 70 PassVisitor<ExprDeclReplacer> replacer( exprMap, debug ); 71 node = maybeMutate( node, replacer ); 55 72 } 56 73 … … 79 96 } 80 97 } 98 99 ExprDeclReplacer::ExprDeclReplacer( const ExprMap & exprMap, bool debug ) : exprMap( exprMap ), debug( debug ) {} 100 101 Expression * ExprDeclReplacer::postmutate( VariableExpr * varExpr ) { 102 if ( exprMap.count( varExpr->var ) ) { 103 Expression * replacement = exprMap.at( varExpr->var )->clone(); 104 if ( debug ) { 105 std::cerr << "replacing variable reference: " << (void*)varExpr->var << " " << varExpr->var << " with " << (void*)replacement << " " << replacement << std::endl; 106 } 107 std::swap( varExpr->env, replacement->env ); 108 delete varExpr; 109 return replacement; 110 } 111 return varExpr; 112 } 81 113 } 82 114 } // namespace VarExprReplacer -
src/SynTree/DeclReplacer.h
r305581d r90152a4 26 26 typedef std::map< DeclarationWithType *, DeclarationWithType * > DeclMap; 27 27 typedef std::map< TypeDecl *, TypeDecl * > TypeMap; 28 typedef std::map< DeclarationWithType *, Expression * > ExprMap; 28 29 29 30 void replace( BaseSyntaxNode * node, const DeclMap & declMap, bool debug = false ); 30 31 void replace( BaseSyntaxNode * node, const TypeMap & typeMap, bool debug = false ); 31 32 void replace( BaseSyntaxNode * node, const DeclMap & declMap, const TypeMap & typeMap, bool debug = false ); 33 34 void replace( BaseSyntaxNode *& node, const ExprMap & exprMap, bool debug = false); 35 template<typename T> 36 void replace( T *& node, const ExprMap & exprMap, bool debug = false ) { 37 if ( ! node ) return; 38 BaseSyntaxNode * arg = node; 39 replace( arg, exprMap, debug ); 40 node = dynamic_cast<T *>( arg ); 41 assertf( node, "DeclReplacer fundamentally changed the type of its argument." ); 42 } 32 43 } 33 44 -
tests/raii/.expect/memberCtors.txt
r305581d r90152a4 98 98 end copy construct A 99 99 End of main 100 begin destruct B 100 101 constructing int 101 102 constructing int … … 146 147 destructing int: 0 147 148 destructing int: 1000 148 destructing int: 0 149 destructing int: 0 150 destructing int: 999 151 destructing int: 0 152 destructing int: 0 153 destructing int: 0 154 destructing int: 0 155 destructing int: 0 156 destructing int: 999 149 end destruct B 150 destructing int: 0 151 destructing int: 0 152 destructing int: 999 153 destructing int: 0 154 destructing int: 0 155 destructing int: 0 156 destructing int: 0 157 destructing int: 0 158 destructing int: 999 159 begin destruct B 157 160 constructing int 158 161 constructing int … … 203 206 destructing int: 0 204 207 destructing int: 1000 205 destructing int: 0 206 destructing int: 0 207 destructing int: 999 208 destructing int: 0 209 destructing int: 0 210 destructing int: 0 211 destructing int: 0 212 destructing int: 0 213 destructing int: 999 208 end destruct B 209 destructing int: 0 210 destructing int: 0 211 destructing int: 999 212 destructing int: 0 213 destructing int: 0 214 destructing int: 0 215 destructing int: 0 216 destructing int: 0 217 destructing int: 999 -
tests/raii/memberCtors.c
r305581d r90152a4 22 22 } 23 23 24 void ?=?(WrappedInt & this, int x) {24 /* WrappedInt */ void ?=?(WrappedInt & this, int x) { 25 25 printf("assigning int: %d %d\n", this.x, x); 26 26 this.x = x; 27 // return this; 27 28 } 29 30 // WrappedInt ?=?(WrappedInt & this, WrappedInt other) { 31 // printf("assigning int: %d %d\n", this.x, other.x); 32 // this.x = other.x; 33 // return this; 34 // } 28 35 29 36 struct A { … … 79 86 80 87 void ^?{}(B & b) { 88 printf("begin destruct B\n"); 81 89 b.a2 = (A) { 0 }; 82 90 ^(b.a1){}; 91 printf("end destruct B\n"); 83 92 } // a2, a3 never destructed - will be automatically destructed 84 93 85 94 int main() { 86 95 printf("Before declaration of b1\n"); 87 B b1; 96 B b1; // b1 = { { 1000, 0, 0 }, { 1001, 0, 0 }, { 0, 0, 0 } } 88 97 printf("Before declaration of b2\n"); 89 98 B b2 = b1;
Note: See TracChangeset
for help on using the changeset viewer.