Changeset 8b34df0

Timestamp:

Jun 17, 2019, 1:08:35 PM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

aba20d2

Parents:

120a28c3

Message:

Removed incorrect copying in InferredParameters? conversion

File:

• src/AST/Convert.cpp (modified) (3 diffs)

src/AST/Convert.cpp

@@ -576 +576 @@
                 if ( srcInferred.mode == ast::Expr::InferUnion::Params ) {
                         const ast::InferredParams &srcParams = srcInferred.inferParams();
-                        for (auto srcParam : srcParams) {
-                                tgtInferParams[srcParam.first] = ParamEntry(
+                        for (auto & srcParam : srcParams) {
+                                auto res = tgtInferParams.emplace(srcParam.first, ParamEntry(
                                         srcParam.second.decl,
                                         get<Declaration>().accept1(srcParam.second.declptr),
@@ -583 +583 @@
                                         get<Type>().accept1(srcParam.second.formalType),
                                         get<Expression>().accept1(srcParam.second.expr)
-                                );
+                                ));
+                                assert(res.second);
                         }
                 } else if ( srcInferred.mode == ast::Expr::InferUnion::Slots  ) {
@@ -2002 +2003 @@
                 if ( !oldInferParams.empty() ) {
                         ast::InferredParams &tgt = newInferred.inferParams();
-                        for (auto old : oldInferParams) {
+                        for (auto & old : oldInferParams) {
                                 tgt[old.first] = ast::ParamEntry(
                                         old.second.decl,