Changeset 8abca06 for src/SymTab

Timestamp:

Feb 11, 2020, 3:15:42 PM (5 years ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

eeaa3e2

Parents:

7102540

Message:

rewrite isPrefix using memcmp to increase performance, same change in Demangle but untested

File:

• src/SymTab/Demangle.cc (modified) (4 diffs)

src/SymTab/Demangle.cc

@@ -10 +10 @@
 // Created On       : Thu Jul 19 12:52:41 2018
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Fri Dec 13 14:54:15 2019
-// Update Count     : 4
+// Last Modified On : Tue Feb 11 15:09:18 2020
+// Update Count     : 10
 //
 
@@ -19 +19 @@
 #include "CodeGen/GenType.h"
 #include "Common/PassVisitor.h"
+#include "Common/utility.h"                                                             // isPrefix
 #include "Mangler.h"
 #include "SynTree/Type.h"
@@ -416 +417 @@
 
                         bool StringView::isPrefix(const std::string & pref) {
-                                if ( pref.size() > str.size()-idx ) return false;
-                                auto its = std::mismatch( pref.begin(), pref.end(), std::next(str.begin(), idx) );
-                                if (its.first == pref.end()) {
+                                // if ( pref.size() > str.size()-idx ) return false;
+                                // auto its = std::mismatch( pref.begin(), pref.end(), std::next(str.begin(), idx) );
+                                // if (its.first == pref.end()) {
+                                //      idx += pref.size();
+                                //      return true;
+                                // }
+
+                                // This update is untested because there are no tests for this code.
+                                if ( ::isPrefix( str, pref, idx ) ) {
                                         idx += pref.size();
                                         return true;
@@ -429 +436 @@
                                 PRINT( std::cerr << "====== " << str.size() << " " << str << std::endl; )
                                 if (str.size() < 2+Encoding::manglePrefix.size()) return false; // +2 for at least _1 suffix
-                                if (! isPrefix(Encoding::manglePrefix) || ! isdigit(str.back())) return false;
+                                if ( ! isPrefix(Encoding::manglePrefix) || ! isdigit(str.back() ) ) return false;
 
                                 // get name